[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Marcel de Rooy changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > Trivial, skipping QA. Please adjust status if you do so. This has been pushed while still in the signoff queue. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 --- Comment #3 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 M. Tompsett changed: What|Removed |Added Attachment #70812|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 70817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70817&action=edit Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 --- Comment #1 from Jonathan Druart --- Created attachment 70812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70812&action=edit Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/