[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #8 from Nick Clemens  ---
(In reply to Charles Farmer from comment #4)
> > 975 from record:
> > =975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 
> > 
> > You will need to adjust subfield $h to the name of on of your funds that is
> > duplicated
> 
> This will definitely have to be rephrased, because like Zoe Bennett, I
> couldn't reproduce the issue.
> 
> I did as you said, created two budgets, with one fund that had the same
> code, and yet, when I used the staged file to add items to a new basket,
> there was only one budget name in the dropdown menu.

I added an example file and screenshots, I changed the fund name to show that
both are selected, the problem persists if the names are the same or different

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #7 from Nick Clemens  ---
Created attachment 76115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76115=edit
Example marc file for staging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #6 from Nick Clemens  ---
Created attachment 76114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76114=edit
View of double selected elements on adding to basket

View of the issue when adding from staged to basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #5 from Nick Clemens  ---
Created attachment 76113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76113=edit
Budget setup

Example budgets/funds to illustrate issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #4 from Charles Farmer  ---
> 975 from record:
> =975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 
> 
> You will need to adjust subfield $h to the name of on of your funds that is
> duplicated

This will definitely have to be rephrased, because like Zoe Bennett, I couldn't
reproduce the issue.

I did as you said, created two budgets, with one fund that had the same code,
and yet, when I used the staged file to add items to a new basket, there was
only one budget name in the dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #3 from Nick Clemens  ---
Retested on master, I can recreate:

Setup a budget with some funds
Duplicate the budget,make one of them inactive

MarcFieldsToOrder:
price: 975$p
quantity: 975$q
budget_code: 975$h

MarcItemFieldsToOrder:
homebranch: 975$a
holdingbranch: 975$b
itype: 975$y
nonpublic_note: 975$x
public_note: 975$z
loc: 975$c
ccode: 975$8
notforloan: 975$7
quantity: 975$q
price: 975$g
replacementprice: 975$v
uri: 975$u

975 from record:
=975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 

You will need to adjust subfield $h to the name of on of your funds that is
duplicated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code , not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Zoe Bennett  changed:

   What|Removed |Added

 CC||zoebennett1...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Zoe Bennett  ---
We couldn't reproduce the bug we have tried putting two funds with the same
code in one budget and two funds with the same code in two separate budgets and
both times nothing was selected in the drop down.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code , not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code , not id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #1 from Nick Clemens  ---
Created attachment 70638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70638=edit
Bug 20014: Preselect item budget based on id not code

To test:
1 - Have the same fund code in two budgets
2 - Have budget code defined in MarcItemFieldsToOrder
3 - Stage a file with some order items as defined above
4 - Inspect the fuinds drop down in the item, notice two lines are
marked selected
5 - Apply patch
6 - Repeat
7 - Only one field should be selected, with a preference for active
budget

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/