[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #67 from Martin Renvoize  ---
As that's now two RM's who have asked for more work on this I think it's safe
to call it FQA and look at it again with fresh light.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #66 from Fridolin Somers  ---
I'm looking at it.

It is quite a complex code scrapping DBIx datas.

I my opinion it should not send "type":"Borrower".
The database names are not the current terminology for objects.
Better use module name Koha::Patron, so it is easy to guess one must call API
on route '/api/v1/patron'

I will try to gather feedback at hackfest next week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_22_05_candidate

--- Comment #65 from Jonathan Druart  ---
I am very sorry but I am not confident in pushing this for 21.11. Also sorry to
have been so slow to provide you feedback.

I think it should get more eyes from the QA team. Postponed and letting the
next RM decide.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #124161|0   |1
is obsolete||

--- Comment #64 from Lari Taskula  ---
Created attachment 124168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124168=edit
Bug 20028: (QA follow-up) Add atomic update for new pref

Setting the initial value to 0 just to be on the safe side.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #124160|0   |1
is obsolete||

--- Comment #63 from Lari Taskula  ---
Created attachment 124167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124167=edit
Bug 20028: (QA follow-up) Fix test plan for Patron.t

t/db_dependent/Koha/Patron.t .. 8/8 # Looks like you planned 8 tests but ran 9.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #124159|0   |1
is obsolete||

--- Comment #62 from Lari Taskula  ---
Created attachment 124166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124166=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #124157|0   |1
is obsolete||

--- Comment #61 from Lari Taskula  ---
Created attachment 124165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124165=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

Signed-off-by: Michal Denar 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #124156|0   |1
is obsolete||

--- Comment #60 from Lari Taskula  ---
Created attachment 124164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124164=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #59 from Marcel de Rooy  ---
(In reply to Lari Taskula from comment #58)
> Good spot, I'm pretty sure this happened by accident. I probably didn't pull
> Michal's signed-off patches before rebasing. Shall I add it back?

If you do not remove mine :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #58 from Lari Taskula  ---
(In reply to Marcel de Rooy from comment #50)
> You removed the signoff lines of Michal?

Good spot, I'm pretty sure this happened by accident. I probably didn't pull
Michal's signed-off patches before rebasing. Shall I add it back?

Also I agree with setting syspref default to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #57 from Marcel de Rooy  ---

Lari raised various questions on this bug, but did not receive (many) answers.
I do like what he wrote and I think it would be a good starting point to
refine. Since it is controlled by a pref, I would not see much harm in pushing
this first step and refining later.

> Should we first implement something that simply returns all the data related 
> to a patron, and if someone wants to focus on formatting it nicely, then 
> solve that issue in another Bug?
I would agree with that direction.

> Another issue is how far do we want to expand the results?
Hmm. This will open up a lot of trouble? Since there are so many relations, we
would imo need some mechanism to do so instead of ad-hoc stuff.

> The current patches completely ignore any REST API terminology guidelines we 
> use. [...] This will become a terminology hell.
Sure. Your approach is understandable. And you are using to_api now.

> We also need pagination, but paginating the currently proposed model would be 
> weird. How would one paginate such response? Should we instead return an 
> array of objects with the same structure ...
You added basic pagination with "_per_page" and "_page". Hard to say what would
be the best pagination approach here ;)

> I will ask these questions on koha-devel mailing list.
I may have missed that one. I have searched in the archive, but could not find
anything.

Passing QA to stir up the discussion ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #56 from Marcel de Rooy  ---
Created attachment 124161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124161=edit
Bug 20028: (QA follow-up) Add atomic update for new pref

Setting the initial value to 0 just to be on the safe side.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #55 from Marcel de Rooy  ---
Created attachment 124160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124160=edit
Bug 20028: (QA follow-up) Fix test plan for Patron.t

t/db_dependent/Koha/Patron.t .. 8/8 # Looks like you planned 8 tests but ran 9.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #120847|0   |1
is obsolete||

--- Comment #54 from Marcel de Rooy  ---
Created attachment 124159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124159=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #120846|0   |1
is obsolete||

--- Comment #53 from Marcel de Rooy  ---
Created attachment 124158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124158=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #120845|0   |1
is obsolete||

--- Comment #52 from Marcel de Rooy  ---
Created attachment 124157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124157=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #120844|0   |1
is obsolete||

--- Comment #51 from Marcel de Rooy  ---
Created attachment 124156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124156=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #50 from Marcel de Rooy  ---
(In reply to Lari Taskula from comment #48)
> Rebased

You removed the signoff lines of Michal?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 Status|Signed Off  |BLOCKED

--- Comment #49 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #48 from Lari Taskula  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #119977|0   |1
is obsolete||

--- Comment #47 from Lari Taskula  ---
Created attachment 120847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120847=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #119976|0   |1
is obsolete||

--- Comment #46 from Lari Taskula  ---
Created attachment 120846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120846=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #119975|0   |1
is obsolete||

--- Comment #45 from Lari Taskula  ---
Created attachment 120845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120845=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #119974|0   |1
is obsolete||

--- Comment #44 from Lari Taskula  ---
Created attachment 120844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120844=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #43 from Michal Denar  ---
Created attachment 119977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119977=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #42 from Michal Denar  ---
Created attachment 119976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119976=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

 Attachment #119968|0   |1
is obsolete||
 Attachment #119969|0   |1
is obsolete||
 Attachment #119970|0   |1
is obsolete||
 Attachment #119972|0   |1
is obsolete||

--- Comment #40 from Michal Denar  ---
Created attachment 119974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119974=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #41 from Michal Denar  ---
Created attachment 119975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119975=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #119971|0   |1
is obsolete||

--- Comment #39 from Lari Taskula  ---
Created attachment 119972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119972=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117109|0   |1
is obsolete||

--- Comment #38 from Lari Taskula  ---
Created attachment 119971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119971=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117108|0   |1
is obsolete||

--- Comment #37 from Lari Taskula  ---
Created attachment 119970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119970=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117107|0   |1
is obsolete||

--- Comment #36 from Lari Taskula  ---
Created attachment 119969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119969=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117106|0   |1
is obsolete||

--- Comment #35 from Lari Taskula  ---
Created attachment 119968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119968=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #34 from Lari Taskula  ---
(In reply to Michal Denar from comment #33)
> Lari,
> is this patch ready to testing? Because status is still In Discussion.
> 
> Thank you.

Short answer: Sign-off testing no, testing out of curiosity yes.

Longer answer: In discussion is the correct status. There are many ways to
implement this feature, and as mentioned in comment #32, I'm still curious of
what others think of this approach.

The response body is something that needs to be discussed. There are open
questions regarding terminology, property extension and pagination.

The current patches completely ignore any REST API terminology guidelines we
use. In comment #21 I have asked if we should first implement something that
just returns all the data, and later enhance it in a different Bug. This will
become a terminology hell, because there are many many many related objects
(around 50) that ideally should be terminologically consistent. I'm not sure if
this Bug is the correct place for that.

In comment #22, I have asked about extending properties so that for example
items would include a biblio.title.

We also need pagination, but paginating the currently proposed model would be
weird. How would one paginate such response? Should we instead return an array
of objects with the same structure, such as:

[
  {
"type": "MESSAGE",
"object": {
  "message_id": 123,
  ... // the message object
}
  },
  { 
"type": "CHECKOUT",
"object": {
   "checkout_id": 456,
   ... // the checkout object
 }

]

Here the pagination would be clearer.

I will ask these questions on koha-devel mailing list.

Also related:
https://wiki.koha-community.org/wiki/Public_patrons_export_endpoint_RFC

Anyway, the patches are working and can be tested, but I wouldn't yet sign-off
them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #33 from Michal Denar  ---
Lari,
is this patch ready to testing? Because status is still In Discussion.

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #32 from Lari Taskula  ---
Added four patches containing a very basic functionality for exporting patron
related data. It iterates DBIx Borrower relationships and returns a huge
hashref in the following format:

>{
>  "Accountline": [
>{ "accountline_id": 1, "borrowernumber": 1481, ... },
>{ "accountline_id": 2, "borrowernumber": 1481, ... }
>  ],
>  "Borrower": { "borrowernumber": 1481, "firstname": "Export", ... },
>  ...,
>  "Virtualshelve": [
>{ "shelfnumber": 1, "owner": 1481, ... },
>{ "shelfnumber": 2, "owner": 1481, ... }
>  ]
>}

Returns the same thing from REST API, from these two endpoints:

GET /api/v1/patrons/123/export(privileged)
GET /api/v1/public/patrons/123/export (unprivileged)

So it does not yet follow our terminology rules nor add any pagination.

Anyway, thoughts about the DBIx relationship approach?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #31 from Lari Taskula  ---
Created attachment 117109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117109=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #30 from Lari Taskula  ---
Created attachment 117108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117108=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #29 from Lari Taskula  ---
Created attachment 117107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117107=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #116604|0   |1
is obsolete||

--- Comment #28 from Lari Taskula  ---
Created attachment 117106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117106=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower source.

This patch does not care about terminology - it returns related data in
a hashref containing keys of DBIx source class names, such as Borrower.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

  Attachment #79381|0   |1
is obsolete||
 Attachment #116344|0   |1
is obsolete||

--- Comment #27 from Lari Taskula  ---
Created attachment 116604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116604=edit
Bug 20028: Add Koha::Patron->takeout

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #26 from Lari Taskula  ---
(In reply to Johanna Räisä from comment #25)
> If we return only itemnumbers then the item data have to be fetched from
> items-endpoint. It is not very efficient to have hundreds of API calls to
> get rest of the data. I think it is better to have at least an expanded
> endpoint for more information.
Good point. While one could argue that since item data is not directly part of
patron related data and should not be returned, I can see use cases where it
makes sense to expand.

Expanded objects contain a lot unwanted data, so we would have to select which
columns to expand.

By the way, there are 52 tables that are directly related to a patron via DBIx
relationship (meaning foreign keys in borrowers table, or foreign keys in other
tables pointing to borrowers). These are:

3 belongs_to relationship (borrowers refer to primary key in other table):
branches
categories
sms_providers

(the three tables above have a lot of data that should probably be left out?)

49 has_many relationship (tables that refer to borrowers):
accountlines
advanced_editor_macros
alert
api_keys
aqbasketusers
aqbudgetborrowers
aqorder_users
aqorders
article_requests
borrower_attributes
borrower_debarments
borrower_files
borrower_message_preferences
borrower_relationships
cash_register_actions
club_enrollments
club_holds_to_patron_holds
course_instructors
creator_batches
discharges
hold_fill_targets
housebound_profile
housebound_role
housebound_visit
illcomments
illrequests
issues
items_last_borrower
message_queue
messages
old_issues
old_reserves
opac_news
patron_consent
patron_list_patrons
patron_lists
patronimage
problem_reports
ratings
reserves
return_claims
reviews
subscriptionroutinglist
tags_all
tags_approval
user_permissions
virtualshelfcontents
virtualshelfshares
virtualshelves

(most of the ones above could be fully included?)

> Pagination options are mandatory since the return data be massive.
It's a costly operation to get all of that data in the first place. Especially
if we expand it. If we paginate it (it's a good idea), should we cache the
result for some time? Performance tests will come in handy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Depends on|27630   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630
[Bug 27630] TestBuilder real number formatting is different to DBI(x)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Johanna Räisä  changed:

   What|Removed |Added

 CC||johanna.ra...@koha-suomi.fi

--- Comment #25 from Johanna Räisä  ---
(In reply to Lari Taskula from comment #22)
> Another issue is how far do we want to expand the results? As an example, a
> patron has checked out items, do we return just the itemnumbers or should we
> expand the item object such that eventually we have the biblio itself (it
> might be interesting to know, say, the biblio.title)? I suppose expanding it
> all the way to biblio_metadata.metadata would be pretty hardcore?

If we return only itemnumbers then the item data have to be fetched from
items-endpoint. It is not very efficient to have hundreds of API calls to get
rest of the data. I think it is better to have at least an expanded endpoint
for more information. Pagination options are mandatory since the return data be
massive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #24 from Lari Taskula  ---
(In reply to Lari Taskula from comment #21)
> What about using DBIx to determine the chain of relations to the
> borrowers-table? This way we could keep it dynamic, only relying on the
> foreign keys in our database schema.
Example of this in comment #23. I have also created an RFC for the endpoint,
see https://wiki.koha-community.org/wiki/Public_patrons_export_endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #23 from Lari Taskula  ---
Created attachment 116344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116344=edit
Bug 20028: Add Koha::Patron->takeout

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Depends on||27630


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630
[Bug 27630] TestBuilder real number precision to use column's size
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #22 from Lari Taskula  ---
Another issue is how far do we want to expand the results? As an example, a
patron has checked out items, do we return just the itemnumbers or should we
expand the item object such that eventually we have the biblio itself (it might
be interesting to know, say, the biblio.title)? I suppose expanding it all the
way to biblio_metadata.metadata would be pretty hardcore?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #21 from Lari Taskula  ---
What about using DBIx to determine the chain of relations to the
borrowers-table? This way we could keep it dynamic, only relying on the foreign
keys in our database schema.

The issue then is to format this data in a nice way, suitable for REST API
output. But I believe this is an issue with any approach we take. Of course
some Koha::Schema::Result::* already correspond to a Koha::Object that may have
a database.column <=> API-terminology mapping, but I would imagine a lot of
them do not.

Should we first implement something that simply returns all the data related to
a patron, and if someone wants to focus on formatting it nicely, then solve
that issue in another Bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #20 from Lari Taskula  ---
(In reply to Josef Moravec from comment #11)
> Hm, i am just thinking about using $RESULTSET_PATRON_ID_MAPPING from
> Koha::Patron and define the method Koha::Patron->takeout - does it make
> sense?
This looks interesting. Can we consider it a reliable source of information for
all patron data? It should be easy to return all that data from the method
itself, but how would we convert the schema names themselves to match desired
REST API terminology? Perhaps with the help of
Koha::Schema::Result::*->koha_object_class() (can we assume the class names of
Koha objects follow the expected terminology)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

   Assignee|j.p.kni...@lboro.ac.uk  |lari.task...@hypernova.fi

--- Comment #19 from Lari Taskula  ---
(In reply to Lari Taskula from comment #18)
> I can try to rescue this Bug.
Jon kindly agreed to this. Setting myself as assignee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@hypernova.fi

--- Comment #18 from Lari Taskula  ---
(In reply to Magnus Enger from comment #17)
> I wonder if it would make sense to implement this as a plugin? Not to bypass
> QA, but because the functionality will only be of interest to a subset of
> those libraries that do have patrons. It would also decouple the development
> from the release cycles of Koha itself. Thoughts?
It does make sense to have it as a plugin, and some other systems have taken
such approach. But personally I'd prefer making it a part of core Koha. This
way we are by default advancing good privacy conventions in Koha.

(In reply to Jon Knight from comment #16)
> Is it even wanted?
It is, and I wanted to ask if you are still going to work on this? If not, I
can try to rescue this Bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #17 from Magnus Enger  ---
(In reply to Jon Knight from comment #16)
> I'm not sure what is now expected for me to take this forward? Were there
> other opinions? Is there a particular module this should be going in? Is it
> even wanted?

I think the "verdict" from the QA-team is that the code needs to be moved to a
module in the Koha namespace, with tests. 

I wonder if it would make sense to implement this as a plugin? Not to bypass
QA, but because the functionality will only be of interest to a subset of those
libraries that do have patrons. It would also decouple the development from the
release cycles of Koha itself. Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #16 from Jon Knight  ---
I'm not sure what is now expected for me to take this forward? Were there other
opinions? Is there a particular module this should be going in? Is it even
wanted?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #15 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #14)
> Please move code to module. Makes it easier to test too.

I wanted to get other opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #14 from Marcel de Rooy  ---
Please move code to module. Makes it easier to test too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #13 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #10)
> IMO it's not conceivable to push this code as it. We cannot have such code
> in .pl, without tests, etc.
> 
> Why not just a $patron->unblessed then use columns.def instead of listing of
> the patron's attributes?
> 
> Also found a typo: +  'dateoffbirth' => $patron->dateofbirth,

Please adjust status if something fails qa ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #12 from Jon Knight  ---
I'm not sure I understand how columns.def is going to useful in this case. 
That file appears to be some sort of vaguely XML file mapping tables & columns
to human readable names in a given language. However we don't want language
dependent human readable attributes in the output - we're after consistent
machine readable output for GDPR.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #11 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #10)
> IMO it's not conceivable to push this code as it. We cannot have such code
> in .pl, without tests, etc.
> 
> Why not just a $patron->unblessed then use columns.def instead of listing of
> the patron's attributes?

Hm, i am just thinking about using $RESULTSET_PATRON_ID_MAPPING from
Koha::Patron and define the method Koha::Patron->takeout - does it make sense?

> 
> Also found a typo: +  'dateoffbirth' => $patron->dateofbirth,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
IMO it's not conceivable to push this code as it. We cannot have such code in
.pl, without tests, etc.

Why not just a $patron->unblessed then use columns.def instead of listing of
the patron's attributes?

Also found a typo: +'dateoffbirth' => $patron->dateofbirth,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #9 from Michal Denar  ---
Jon,
sorry ... forgota my last comment. I tried export data from devbox with limited
circulation history. So export contains limitex range of data, ofcourse. We
talked about with Josef and debate around Your code. All relevant date are in
export. 

Good work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #8 from Michal Denar  ---
Patch is working. But circulation history is collection of personal data too.
We should extend functionality this way. It's first good step.

Thank You

Mike.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

  Attachment #79376|0   |1
is obsolete||

--- Comment #7 from Michal Denar  ---
Created attachment 79381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79381=edit
Bug 20028: Export all patron related personal data in one package

Add a system preference to determine whether patron data export is permitted,
and if it is an extra option in the staff UI to initiate the export.  At this
stage the API for patron data isn't ready so as a placeholder it just goes
to the readingrec.pl script.

Testing plan:

* Apply patch.

* Turn the AllowGDPRPatronExport in the administration sysprefs

* Search for a patron (eg Mabel in the standard test data) and then
  click on the "More" button on the right hand side of the button bar.
  You should see "Export patron's GDPR data" option. Selecting that will
  generate and download a JSON file containing the patron's data to
  your client machine.

* Turn off AllowGDPRPatronExport in the administration sysprefs

* The "Export patron's GDPR data" option should no long be visible from
  the "More" button in the patron page.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

  Attachment #75622|0   |1
is obsolete||
  Attachment #78095|0   |1
is obsolete||

--- Comment #6 from Jon Knight  ---
Created attachment 79376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79376=edit
Bug 20028: Export all patron related personal data in one package

Add a system preference to determine whether patron data export is permitted,
and if it is an extra option in the staff UI to initiate the export.  At this
stage the API for patron data isn't ready so as a placeholder it just goes
to the readingrec.pl script.

Testing plan:

* Apply patch.

* Turn the AllowGDPRPatronExport in the administration sysprefs

* Search for a patron (eg Mabel in the standard test data) and then
  click on the "More" button on the right hand side of the button bar.
  You should see "Export patron's GDPR data" option. Selecting that will
  generate and download a JSON file containing the patron's data to
  your client machine.

* Turn off AllowGDPRPatronExport in the administration sysprefs

* The "Export patron's GDPR data" option should no long be visible from
  the "More" button in the patron page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

  Attachment #75622|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |j.p.kni...@lboro.ac.uk
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

  Attachment #75622|0   |1
is obsolete||

--- Comment #5 from Jon Knight  ---
Created attachment 78095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78095=edit
Bug 20028: Export all patron related personal data in one package

Modifies the readingrec.pl script to give the option to generate a JSON
encoded version of the data held about the patron. Currently exports basic
patron (borrower table) data, patron image, holds (reserves), old holds,
checkouts (issues), old checkouts and accounting information.

Test plan:

Turn on the syspref, select a patron from the staff intranet,
and then choose "Export patron's GDPR data" from the "More..." menu.  You
should then get a JSON file downloaded to the machine running your web
browser.  Compare the data in that file with the data shown on the
intranet displays for that patron.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Pablo AB  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #4 from Pablo AB  ---
Related: To export patron images on a package ready for upload I create [this
script](https://wiki.koha-community.org/wiki/Debian_packages_script_library#Bulk_export_patrons_images).
Also in bug 12996.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #3 from Jon Knight  ---
Note that my patch above is just the scaffolding to support this - it needs the
APIs to extract all the data to be available and then call those.  The
alternative is to write a new script to gather all the patron data in a single
data structure and then return that as JSON.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #2 from Jon Knight  ---
Created attachment 75622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75622=edit
Bug 20028: Export all patron related personal data in one package

Add a system preference to determine whether patron data export is permitted,
and if it is an extra option in the staff UI to initiate the export.  At this
stage the API for patron data isn't ready so as a placeholder it just goes
to the readingrec.pl script.

Testing plan:

* Apply patch.

* Turn the AllowGDPRPatronExport in the administration sysprefs

* Search for a patron (eg Mabel in the standard test data) and then
  click on the "More" button on the right hand side of the button bar.
  You should see "Export patron's GDPR data" option. Selecting that will
  currently just go to the readingrec.pl page.

* Turn off AllowGDPRPatronExport in the  administration sysprefs

* The "Export patron's GDPR data" option should no long be visible from
  the "More" button in the patron page.

Full description of what the patch does

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #1 from Josef Moravec  ---
We discussed it on GDPR meeting and agreed it could be done as API endpoint
with access via a button in staff client and opac.

By the GDPR, the data should be in commonly used machine readable format. So
JSON from REST API is OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Mike  changed:

   What|Removed |Added

Summary|Export all petron related   |Export all patron related
   |personal data in one|personal data in one
   |package |package

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/