[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Pushed to Master|Pushed to Stable --- Comment #7 from Nick Clemens --- Awesome work all, pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard changed: What|Removed |Added Attachment #70973|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 71086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71086&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer Signed-off-by: Nick Clemens Fix for QA: Corrected ID reference in circ/offline.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Status|Passed QA |Failed QA
--- Comment #4 from Jonathan Druart
---
git grep tells me we are going to affect that line:
koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt:
$('ul[aria-labelledby="drop3"]').html('You cannot
change your branch or logout while using offline circulation');
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens changed: What|Removed |Added Attachment #70783|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 70973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70973&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Charles Farmer changed: What|Removed |Added Attachment #70777|0 |1 is obsolete|| --- Comment #2 from Charles Farmer --- Created attachment 70783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70783&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 --- Comment #1 from Owen Leonard --- Created attachment 70777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70777&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
