[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #17 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Martin Renvoize --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Chris Cormack changed: What|Removed |Added Attachment #78851|0 |1 is obsolete|| --- Comment #14 from Chris Cormack --- Created attachment 80316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80316&action=edit Bug 20131: Inventory optional filters correct "For loan" addition In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value. It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__". Test plan: 1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value 2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost" 3) Go to inventory /cgi-bin/koha/tools/inventory.pl 4) Without patch you see "For loan" on both items.notforloan and items.itemlost 5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost" 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 Signed-off-by: Séverine QUEUNE Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #13 from sandbo...@biblibre.com --- Created attachment 78851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78851&action=edit Bug 20131: Inventory optional filters correct "For loan" addition In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value. It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__". Test plan: 1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value 2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost" 3) Go to inventory /cgi-bin/koha/tools/inventory.pl 4) Without patch you see "For loan" on both items.notforloan and items.itemlost 5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost" 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 sandbo...@biblibre.com changed: What|Removed |Added Attachment #78830|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Failed QA |Signed Off --- Comment #12 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What|Removed |Added Attachment #72923|0 |1 is obsolete|| --- Comment #11 from Fridolin SOMERS --- Created attachment 78830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78830&action=edit Bug 20131: Inventory optional filters correct "For loan" addition In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value. It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__". Test plan: 1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value 2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost" 3) Go to inventory /cgi-bin/koha/tools/inventory.pl 4) Without patch you see "For loan" on both items.notforloan and items.itemlost 5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost" 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #10 from Katrin Fischer --- Hm, ok, I might not understand the reasoning behind this patch or even the bug it tries to fix :( >From my testing: 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 When I do that, I end up with 2 values showing on the inventory form: For loan and Available - both actually meaning the same. Also: On the edit item form the Available appears twice(!) in the pull down and the X to empty the field is no longer present. What I can see is an inconsistency on the inventory form as we only have a "0" value for not for loan, while we don't have that for lost, withdrawn and damaged. I'd suggest to either remove it or add an empty option for all of them. But also not using 'for loan' - because it still might not be, but something like 'not set'. Or: Not lost, not withdrawn, not damaged,... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #9 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #8) > (In reply to Katrin Fischer from comment #7) > > >8) Without patch you see "For loan" in items.notforloan for value 0 > > >9) With patch you see "Available" in items.notforloan for value 0 > > > > Still 'For loan' for me. Please fix test plan or patch! > > If you have memcached and/or plack, you need to restart them when you change > authorized values. Hi Frido, that should not be necessary in current versions, but I am retesting anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #8 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #7) > >8) Without patch you see "For loan" in items.notforloan for value 0 > >9) With patch you see "Available" in items.notforloan for value 0 > > Still 'For loan' for me. Please fix test plan or patch! If you have memcached and/or plack, you need to restart them when you change authorized values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- >8) Without patch you see "For loan" in items.notforloan for value 0 >9) With patch you see "Available" in items.notforloan for value 0 Still 'For loan' for me. Please fix test plan or patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #6 from Séverine Queune --- Everything work as expected playing with authorized_values and mapping for the concerned fields on bibliographic framework menu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Séverine Queune changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Séverine Queune changed: What|Removed |Added Attachment #71149|0 |1 is obsolete|| --- Comment #5 from Séverine Queune --- Created attachment 72923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72923&action=edit Bug 20131: Inventory optional filters correct "For loan" addition In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value. It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__". Test plan: 1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value 2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost" 3) Go to inventory /cgi-bin/koha/tools/inventory.pl 4) Without patch you see "For loan" on both items.notforloan and items.itemlost 5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost" 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Victor Grousset/tuxayo --- @Fridolin can you test on a BibLibre's sandbox? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Lucie Gay changed: What|Removed |Added CC||lucie.gay@ens-paris-saclay. ||fr --- Comment #3 from Lucie Gay --- We can't test because there is only one inventory filter notforloan but the values are from the authorized value "statut" and not "notforloan". There are no filter for "lost". Tested on unimarc sandbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #2 from Fridolin SOMERS --- Created attachment 71149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71149&action=edit Bug 20131: Inventory optional filters correct "For loan" addition In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value. It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__". Test plan: 1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value 2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost" 3) Go to inventory /cgi-bin/koha/tools/inventory.pl 4) Without patch you see "For loan" on both items.notforloan and items.itemlost 5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost" 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What|Removed |Added Depends on||12913 --- Comment #1 from Fridolin SOMERS --- "For loan" string has been added by Bug 12913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 [Bug 12913] Fix wrong inventory results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
