[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Text to go in the|This development changes|This development changes release notes|how the orders table on |how the orders table on |receiving in acquisitions |receiving in acquisitions |is rendered. |is rendered. |Before this |Before these |patches all active orders |patches all active orders |data was fetched from the |data was fetched from the |database, along with all|database, along with all |the related data (patrons, |the related data (patrons, |biblio). This lead to |biblio). This leads to |significant delays because |significant delays because |all orders matching the |all orders matching the |filtering criteria were |filtering criteria were |loaded, even when only 20 |loaded, even when only 20 |rows are displayed on the |rows were displayed on the |UI. |UI. |With this patch, the|With this patch, the |table is rendering using|table is rendering using |server-side pagination, |server-side pagination, |provided by the REST API. |provided by the REST API. |This means |This means |(1) only the|(1) only the |information to be rendered |information to be rendered |is fetched (faster drawing |is fetched (faster drawing |(2) the page doesn't reload |(2) the page doesn't reload |anymore when a new filter |anymore when a new filter |is added: it just refreshes |is added: it just refreshes |the table, very fastly. |the table, very fastly. || |Sponsored by: Camden County |Sponsored by: Camden County |Library System |Library System | | |Sponsored |Sponsored |by: ByWater Solutions |by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Text to go in the|This development changes|This development changes release notes|how the orders table on |how the orders table on |receiving in acquisitions |receiving in acquisitions |is rendered. |is rendered. |Before this |Before this |patches all active orders |patches all active orders |data was fetched from the |data was fetched from the |database, along with all|database, along with all |the related data (patrons, |the related data (patrons, |biblio). This lead to |biblio). This lead to |significant delays because |significant delays because |all orders matching the |all orders matching the |filtering criteria were |filtering criteria were |loaded, even when only 20 |loaded, even when only 20 |rows are displayed on the |rows are displayed on the |UI. |UI. |With this patch, the|With this patch, the |table is rendering using|table is rendering using |server-side pagination, |server-side pagination, |provided by the REST API. |provided by the REST API. |This means |This means |(1) only the|(1) only the |information to be rendered |information to be rendered |is fetched (faster drawing |is fetched (faster drawing |(2) the page doesn't reload |(2) the page doesn't reload |anymore when a new filter |anymore when a new filter |is added: it just refreshes |is added: it just refreshes |the table, very fastly. |the table, very fastly. || |Sponsored-by: Camden County |Sponsored by: Camden County |Library System |Library System |Sponsored-by: ByWater | |Solutions |Sponsored ||by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28248 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Fridolin Somers changed: What|Removed |Added Blocks||27930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930 [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Agustín Moyano changed: What|Removed |Added Blocks||27719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 [Bug 27719] receiving orders hangs on processing when missing a replacement price -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||18967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18967 [Bug 18967] Acquisitions receipt search filter is too sticky -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the|This development changes|This development changes release notes|how the orders table on |how the orders table on |receiving in acquisitions |receiving in acquisitions |is rendered. |is rendered. |Before this |Before this |patches all active orders |patches all active orders |data was fetched from the |data was fetched from the |database, along with all|database, along with all |the related data (patrons, |the related data (patrons, |biblio). This lead to |biblio). This lead to |significant delays because |significant delays because |all orders matching the |all orders matching the |filtering criteria were |filtering criteria were |loaded, even when only 20 |loaded, even when only 20 |rows are displayed on the |rows are displayed on the |UI. |UI. |With this patch, the|With this patch, the |table is rendering using|table is rendering using |server-side pagination, |server-side pagination, |provided by the REST API. |provided by the REST API. |This means |This means |(1) only the|(1) only the |information to be rendered |information to be rendered |is fetched (faster drawing |is fetched (faster drawing |(2) the page doesn't reload |(2) the page doesn't reload |anymore when a new filter |anymore when a new filter |is added: it just refreshes |is added: it just refreshes |the table, very fastly. |the table, very fastly. || ||Sponsored-by: Camden County ||Library System ||Sponsored-by: ByWater ||Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m --- Comment #219 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #218 from Jonathan Druart --- Oops, looks like I forgot to amend the changes I made locally to add the filter! Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #217 from Jonathan Druart --- Created attachment 116139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116139&action=edit Bug 20212: Add missing html filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #216 from Tomás Cohen Arazi --- (In reply to Nicolas Legrand from comment #215) > Thank you everyone! We binge watched this one like the trendiest series with > plot twists and cliffhangers. We were hooked like on a soap opera, with > signed off, passed QA and failed QA in places of affairs and divorces. Great > suspense, great results, we're thrilled! Thank you all a lot for this > incredible work! Acquisitions, REST API, rewriting Koha. It's a good mix for a soap opera haha. The cool thing is it didn't end up being just a stand-up :-D. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #215 from Nicolas Legrand --- Thank you everyone! We binge watched this one like the trendiest series with plot twists and cliffhangers. We were hooked like on a soap opera, with signed off, passed QA and failed QA in places of affairs and divorces. Great suspense, great results, we're thrilled! Thank you all a lot for this incredible work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #214 from Tomás Cohen Arazi --- Thank you all, this was an important piece of teamwork. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #213 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #212 from Martin Renvoize --- I'm happy to say this all works well and I think we should go with it. I'd love to see a little love given to the styling as followup bugs as I think this make the table a bit 'Chunky' with fields changing width and wrapping more often.. and the filters bar being larger etc. I also can see someone asking for the left bar filters back... but again don't think that should hold this up. Final comment, the QA script is upset about a missing filter (but it's a variable that's built within the template so I don't think it's a big issue and Jonathan has promised to fix on push). Soo. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115941|0 |1 is obsolete|| --- Comment #211 from Martin Renvoize --- Created attachment 115965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115965&action=edit Bug 20212: Restore price formatting for ecost and replacement_price Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115921|0 |1 is obsolete|| --- Comment #210 from Martin Renvoize --- Created attachment 115964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115964&action=edit Bug 20212: Filter on publisher and notes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115906|0 |1 is obsolete|| --- Comment #209 from Martin Renvoize --- Created attachment 115963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115963&action=edit Bug 20212: Remove fix_query and assume ugliness It seems better to do things in an ugly way but simple than complicated. This patch removes the fix_query method that deals with ean and isbn and explicitly tell that it's a trick that must not be reused somewhere else. It should only be used by Koha internally and we should not advertised it until it's ready. This problem will have to be fixed properly when the GET /biblios route will be implemented. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115905|0 |1 is obsolete|| --- Comment #208 from Martin Renvoize --- Created attachment 115962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115962&action=edit Bug 20212: Fix query for the global filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115904|0 |1 is obsolete|| --- Comment #207 from Martin Renvoize --- Created attachment 115961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115961&action=edit Bug 20212: Re-add EAN for UNIMARC Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115903|0 |1 is obsolete|| --- Comment #206 from Martin Renvoize --- Created attachment 115960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115960&action=edit Bug 20212: Use the DT column filtering provided by the wrapper Bug 27402 is adding it, we do not longer need the query_from_filters JS function. This patch also remove the filters on the left. As we have DT remembering the filter on the table we don't need them anymore. Technical note: Prior to this patch, the search on biblio.author, biblio.title and biblio.isbn was done by adding hidden columns. Now we are using: "data": "biblio.author:biblio.title:biblio.isbn" to tell the wrapper we are going to build a search on these 3 attributes. Another trick is to pass a default_filters parameters to the wrapper, to tell it we want to filter on the orders of a given vendor (this is a bugfix, the original implementation was returning all the orders). However We should not use /acq/orders?vendor_id=42 but /acq/vendor/42/orders instead (which does not exist yet), otherwise (with bug 27353 ) we are going to display the wrong number of non-filtering rows. The change in Orders.pm is only formatting to match what's done in Bug 27353: Set X-Base-Total-Count header for REST API Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115902|0 |1 is obsolete|| --- Comment #205 from Martin Renvoize --- Created attachment 115959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115959&action=edit Bug 20212: Remove fixedHeader It's an extension that needs to be added. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115901|0 |1 is obsolete|| --- Comment #204 from Martin Renvoize --- Created attachment 115958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115958&action=edit Bug 20212: Search on fund's name instead of id Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115900|0 |1 is obsolete|| --- Comment #203 from Martin Renvoize --- Created attachment 115957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115957&action=edit Bug 20212: (follow-up) Avoid pagination on full resultset test Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115899|0 |1 is obsolete|| --- Comment #202 from Martin Renvoize --- Created attachment 115956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115956&action=edit Bug 20212: Use functions to escape variables Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115898|0 |1 is obsolete|| --- Comment #201 from Martin Renvoize --- Created attachment 115955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115955&action=edit Bug 20212: Fix test after 25670 follow-up Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115897|0 |1 is obsolete|| --- Comment #200 from Martin Renvoize --- Created attachment 115954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115954&action=edit Bug 20212: (QA follow-up) Fix escaping Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115896|0 |1 is obsolete|| --- Comment #199 from Martin Renvoize --- Created attachment 115953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115953&action=edit Bug 20212: (QA follow-up) Spelling typo fix Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115894|0 |1 is obsolete|| --- Comment #197 from Martin Renvoize --- Created attachment 115951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115951&action=edit Bug 20212: Make all biblioitems.* fields searchable Prior to this bug, only a few bilbio fields were actually searchable through the orders API. This patch adds all of them to the mapping, so other pages can take advantage of them. My first approach was to add things as needed. But this is trivial to make complete. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115895|0 |1 is obsolete|| --- Comment #198 from Martin Renvoize --- Created attachment 115952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115952&action=edit Bug 20212: (QA follow-up) Restore missing comma Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115893|0 |1 is obsolete|| --- Comment #196 from Martin Renvoize --- Created attachment 115950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115950&action=edit Bug 20212: (QA follow-up) Resurrect column filtering This patch adds per-column filtering to the order receiving table. The order cost column proved difficult to filter, because of the syntax DBIC requires for comparing replacement_cost * quantity, and passing that all the way down from the API request to DBIC itself. I'm still looking for options. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115892|0 |1 is obsolete|| --- Comment #195 from Martin Renvoize --- Created attachment 115949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115949&action=edit Bug 20212: (QA follow-up) Restore table filter sticky Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115891|0 |1 is obsolete|| --- Comment #194 from Martin Renvoize --- Created attachment 115948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115948&action=edit Bug 20212: Controller changes regression tests This patchset did a copy and paste of the objects->search helper inside the controller, to handle a very special case that wasn't worth generalizing: the fact that the biblio object (that this patchset makes embeddable) is actually built from two tables, and we want to filter by fields in both tables. This requires us to translate: - Any filter reference to fields in biblioitems we allow to search on, through an allow list. - For filtering to work, we need to tweak the stashed 'embed' object so the prefetch is done correctly This patchset also adds a new query parameter: only_active. It is used to only request active orders (see the spec for more details). This patch adds tests for: - Filtering by a column in bilbioitems (this implies correctly prefetching the bilbio => biblioitems relation, and translating the filtering parameter. - Using the only_active query parameter to retrieve only active orders To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Verify the tests check for the explained behaviours. => SUCCESS: They do! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115890|0 |1 is obsolete|| --- Comment #193 from Martin Renvoize --- Created attachment 115947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115947&action=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115889|0 |1 is obsolete|| --- Comment #192 from Martin Renvoize --- Created attachment 115946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115946&action=edit Bug 20212: Use API to render orders datatable This patch makes the pending orders datatable render using the API instead of hte old controller script. It implements native server-side pagination thanks to the API and the datatables wrapper. On polishing it, we found that data can contain many null values, and it got dirtier in the process. This code with all the checks that are done on the data is the result of testing this dev with real-life production databases, huge ones with thousands of orderlines. To test: 1. You should compare the behaviour between this table, and the original one in master. Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115888|0 |1 is obsolete|| --- Comment #191 from Martin Renvoize --- Created attachment 115945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115945&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115887|0 |1 is obsolete|| --- Comment #190 from Martin Renvoize --- Created attachment 115944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115944&action=edit Bug 20212: Clean parcel.pl Signed-off-by: Tomas Cohen Arazi Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What|Removed |Added Attachment #115886|0 |1 is obsolete|| --- Comment #189 from Martin Renvoize --- Created attachment 115943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115943&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio. gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
--- Comment #188 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #186)
> 2) Search filter texts are reversed ('Search replacement price' vs
> 'Replacement price search') - I prefer the old way as you see the relevant
> information first as opposed to 'Search ...' with the relevant data getting
> cut off on narrow columns.
Fixed on bug 27402 (Reverse search filter texts)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #187 from Martin Renvoize --- OK, First one is now fixed already :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
--- Comment #186 from Martin Renvoize ---
Some minor issues present I'm afraid:
1) We appear to have lost money formatting on some columns (i.e "8.00" vs "8")
- QA Fail
2) Search filter texts are reversed ('Search replacement price' vs 'Replacement
price search') - I prefer the old way as you see the relevant information first
as opposed to 'Search ...' with the relevant data getting cut off on narrow
columns.
3) Columns appear to be wrapping more often.. not sure why but it means the
table displays less rows in the viewport.
The first is a QA failure, but the second two points are more a matter of style
and could be fixed later in my opinion.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #185 from Jonathan Druart --- Created attachment 115941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115941&action=edit Bug 20212: Restore price formatting for ecost and replacement_price -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #184 from Martin Renvoize --- Created attachment 115940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115940&action=edit Screenshot of table after again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #183 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #182) > I was wondering about the removed search options on the left: Are there any > issues to be expected performance wise? As I understand if you can't limit > by search, you will always filter on the full data by using the datatable > options? Searches are very fast (at least compared to the original implementation). The key, to streamline the receiving process, will be bug 8179, which will let the users perform several queries and accumulate to orders to receive, so they are all received in one step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #182 from Katrin Fischer --- I was wondering about the removed search options on the left: Are there any issues to be expected performance wise? As I understand if you can't limit by search, you will always filter on the full data by using the datatable options? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #181 from Jonathan Druart --- Created attachment 115921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115921&action=edit Bug 20212: Filter on publisher and notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Attachment #115920|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #180 from Jonathan Druart --- Created attachment 115920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115920&action=edit Bug 20212: Add filter for publisher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #179 from Andrew Fuerste-Henry --- I've signed off, but have one thing to fix. The Summary column doesn't search publisher information, internal notes, or vendor notes. Otherwise, it looks great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #115822|0 |1 is obsolete|| --- Comment #178 from Andrew Fuerste-Henry --- Created attachment 115906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115906&action=edit Bug 20212: Remove fix_query and assume ugliness It seems better to do things in an ugly way but simple than complicated. This patch removes the fix_query method that deals with ean and isbn and explicitly tell that it's a trick that must not be reused somewhere else. It should only be used by Koha internally and we should not advertised it until it's ready. This problem will have to be fixed properly when the GET /biblios route will be implemented. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #115821|0 |1 is obsolete|| --- Comment #177 from Andrew Fuerste-Henry --- Created attachment 115905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115905&action=edit Bug 20212: Fix query for the global filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #115820|0 |1 is obsolete|| --- Comment #176 from Andrew Fuerste-Henry --- Created attachment 115904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115904&action=edit Bug 20212: Re-add EAN for UNIMARC Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #115819|0 |1 is obsolete|| --- Comment #175 from Andrew Fuerste-Henry --- Created attachment 115903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115903&action=edit Bug 20212: Use the DT column filtering provided by the wrapper Bug 27402 is adding it, we do not longer need the query_from_filters JS function. This patch also remove the filters on the left. As we have DT remembering the filter on the table we don't need them anymore. Technical note: Prior to this patch, the search on biblio.author, biblio.title and biblio.isbn was done by adding hidden columns. Now we are using: "data": "biblio.author:biblio.title:biblio.isbn" to tell the wrapper we are going to build a search on these 3 attributes. Another trick is to pass a default_filters parameters to the wrapper, to tell it we want to filter on the orders of a given vendor (this is a bugfix, the original implementation was returning all the orders). However We should not use /acq/orders?vendor_id=42 but /acq/vendor/42/orders instead (which does not exist yet), otherwise (with bug 27353 ) we are going to display the wrong number of non-filtering rows. The change in Orders.pm is only formatting to match what's done in Bug 27353: Set X-Base-Total-Count header for REST API Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #115818|0 |1 is obsolete|| --- Comment #174 from Andrew Fuerste-Henry --- Created attachment 115902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115902&action=edit Bug 20212: Remove fixedHeader It's an extension that needs to be added. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #115817|0 |1 is obsolete|| --- Comment #173 from Andrew Fuerste-Henry --- Created attachment 115901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115901&action=edit Bug 20212: Search on fund's name instead of id Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114959|0 |1 is obsolete|| --- Comment #172 from Andrew Fuerste-Henry --- Created attachment 115900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115900&action=edit Bug 20212: (follow-up) Avoid pagination on full resultset test Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114956|0 |1 is obsolete|| --- Comment #171 from Andrew Fuerste-Henry --- Created attachment 115899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115899&action=edit Bug 20212: Use functions to escape variables Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114954|0 |1 is obsolete|| --- Comment #170 from Andrew Fuerste-Henry --- Created attachment 115898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115898&action=edit Bug 20212: Fix test after 25670 follow-up Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114942|0 |1 is obsolete|| --- Comment #169 from Andrew Fuerste-Henry --- Created attachment 115897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115897&action=edit Bug 20212: (QA follow-up) Fix escaping Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114617|0 |1 is obsolete|| --- Comment #168 from Andrew Fuerste-Henry --- Created attachment 115896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115896&action=edit Bug 20212: (QA follow-up) Spelling typo fix Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114616|0 |1 is obsolete|| --- Comment #167 from Andrew Fuerste-Henry --- Created attachment 115895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115895&action=edit Bug 20212: (QA follow-up) Restore missing comma Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114615|0 |1 is obsolete|| --- Comment #166 from Andrew Fuerste-Henry --- Created attachment 115894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115894&action=edit Bug 20212: Make all biblioitems.* fields searchable Prior to this bug, only a few bilbio fields were actually searchable through the orders API. This patch adds all of them to the mapping, so other pages can take advantage of them. My first approach was to add things as needed. But this is trivial to make complete. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114614|0 |1 is obsolete|| --- Comment #165 from Andrew Fuerste-Henry --- Created attachment 115893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115893&action=edit Bug 20212: (QA follow-up) Resurrect column filtering This patch adds per-column filtering to the order receiving table. The order cost column proved difficult to filter, because of the syntax DBIC requires for comparing replacement_cost * quantity, and passing that all the way down from the API request to DBIC itself. I'm still looking for options. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114613|0 |1 is obsolete|| --- Comment #164 from Andrew Fuerste-Henry --- Created attachment 115892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115892&action=edit Bug 20212: (QA follow-up) Restore table filter sticky Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114612|0 |1 is obsolete|| --- Comment #163 from Andrew Fuerste-Henry --- Created attachment 115891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115891&action=edit Bug 20212: Controller changes regression tests This patchset did a copy and paste of the objects->search helper inside the controller, to handle a very special case that wasn't worth generalizing: the fact that the biblio object (that this patchset makes embeddable) is actually built from two tables, and we want to filter by fields in both tables. This requires us to translate: - Any filter reference to fields in biblioitems we allow to search on, through an allow list. - For filtering to work, we need to tweak the stashed 'embed' object so the prefetch is done correctly This patchset also adds a new query parameter: only_active. It is used to only request active orders (see the spec for more details). This patch adds tests for: - Filtering by a column in bilbioitems (this implies correctly prefetching the bilbio => biblioitems relation, and translating the filtering parameter. - Using the only_active query parameter to retrieve only active orders To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Verify the tests check for the explained behaviours. => SUCCESS: They do! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114611|0 |1 is obsolete|| --- Comment #162 from Andrew Fuerste-Henry --- Created attachment 115890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115890&action=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114610|0 |1 is obsolete|| --- Comment #161 from Andrew Fuerste-Henry --- Created attachment 115889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115889&action=edit Bug 20212: Use API to render orders datatable This patch makes the pending orders datatable render using the API instead of hte old controller script. It implements native server-side pagination thanks to the API and the datatables wrapper. On polishing it, we found that data can contain many null values, and it got dirtier in the process. This code with all the checks that are done on the data is the result of testing this dev with real-life production databases, huge ones with thousands of orderlines. To test: 1. You should compare the behaviour between this table, and the original one in master. Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114609|0 |1 is obsolete|| --- Comment #160 from Andrew Fuerste-Henry --- Created attachment 115888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115888&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114608|0 |1 is obsolete|| --- Comment #159 from Andrew Fuerste-Henry --- Created attachment 115887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115887&action=edit Bug 20212: Clean parcel.pl Signed-off-by: Tomas Cohen Arazi Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #114607|0 |1 is obsolete|| --- Comment #158 from Andrew Fuerste-Henry --- Created attachment 115886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115886&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio. gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #157 from Jonathan Druart --- An additional change to note: the filters on the left have been removed. The column filters provide the same functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #156 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #155) > This has moved a fair bit since the first QA run.. the code updates look > good to me.. but as we're back to NSO it might be good to get a library to > test this again.. Yeah, I totally agree. Some remarks about 'what to expect' from the latest changes: - The fact that all 'new' orders were displayed, was solved properly on bug 25670 with regression tests and all. It should solved here, that's something to test, specifically. - Jonathan provided a less hand-crafted way to implement the column filtering feature on bug 27402. It will serve any other API-driven DataTable, so YAY! Jonathan made this table use that instead of the original implementation. Besides that, you shouldn't expect any noticeable behavior change compared to previous testing sessions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #155 from Martin Renvoize --- This has moved a fair bit since the first QA run.. the code updates look good to me.. but as we're back to NSO it might be good to get a library to test this again.. Andrew perhaps, do you have time to go through the test plan one last time given all the extra work that has now taken place and double-check it all still performs as expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #154 from Tomás Cohen Arazi --- Created attachment 115822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115822&action=edit Bug 20212: Remove fix_query and assume ugliness It seems better to do things in an ugly way but simple than complicated. This patch removes the fix_query method that deals with ean and isbn and explicitly tell that it's a trick that must not be reused somewhere else. It should only be used by Koha internally and we should not advertised it until it's ready. This problem will have to be fixed properly when the GET /biblios route will be implemented. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #153 from Tomás Cohen Arazi --- Created attachment 115821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115821&action=edit Bug 20212: Fix query for the global filter Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #151 from Tomás Cohen Arazi --- Created attachment 115819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115819&action=edit Bug 20212: Use the DT column filtering provided by the wrapper Bug 27402 is adding it, we do not longer need the query_from_filters JS function. This patch also remove the filters on the left. As we have DT remembering the filter on the table we don't need them anymore. Technical note: Prior to this patch, the search on biblio.author, biblio.title and biblio.isbn was done by adding hidden columns. Now we are using: "data": "biblio.author:biblio.title:biblio.isbn" to tell the wrapper we are going to build a search on these 3 attributes. Another trick is to pass a default_filters parameters to the wrapper, to tell it we want to filter on the orders of a given vendor (this is a bugfix, the original implementation was returning all the orders). However We should not use /acq/orders?vendor_id=42 but /acq/vendor/42/orders instead (which does not exist yet), otherwise (with bug 27353 ) we are going to display the wrong number of non-filtering rows. The change in Orders.pm is only formatting to match what's done in Bug 27353: Set X-Base-Total-Count header for REST API Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #152 from Tomás Cohen Arazi --- Created attachment 115820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115820&action=edit Bug 20212: Re-add EAN for UNIMARC Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #150 from Tomás Cohen Arazi --- Created attachment 115818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115818&action=edit Bug 20212: Remove fixedHeader It's an extension that needs to be added. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #149 from Tomás Cohen Arazi --- Created attachment 115817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115817&action=edit Bug 20212: Search on fund's name instead of id Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115062|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Attachment #114963|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115050|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115109|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115108|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Attachment #115107|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #148 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #147) > Tomas, if you agree with this last patch please reset the status to NSO. A proper solution should be implemented in Koha::REST::Plugin::Query, in the merge_q_params and dbic_merge_prefetch helpers. They both have the resultset object available, so if we added the mapping at Koha::Object level, we could make the translations there, and thus have a 'global' solution in a fairly easy way. To do: - Add the attribute mapping hash in Koha::Biblio and make it available in Koha::Biblios too. A sample mapping would be isbn => biblioitem.isbn. It could be hardcoded (as the table doesn't change, or calculated. - Add a way for Koha::Biblio(s) to tell 'biblioitem' needs to be prefetch (a way for a Koha::Object to tell which other tables need to be prefect). - Make Koha::REST::Plugin::Query::_parse_prefetch add those prefetches using the above. Note that the 'biblio' name in this case is used because x-koha-embed calls it 'biblio' but it could (a) not exist, as in /biblios, where the biblio is top level (b) it could be named in a different way, as happens to (say) 'biblio.suggestions.suggester' which is a Koha::Patron object, but it is not called 'patron'. - Make Koha::REST::Plugin::Query::_parse_dbic_query accumulate the translations to be done while building the query. Then merge_q_params should call a new helper that applies those translations to the already created DBIC query (pretty much a copy and paste of fix_query). That said, we could move forward with the ugly-but-simple implementation. And once I'm back I can work on the above, unless someone does it first ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart changed: What|Removed |Added Assignee|[email protected] |[email protected] |ommunity.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #147 from Jonathan Druart --- Tomas, if you agree with this last patch please reset the status to NSO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #146 from Jonathan Druart --- Created attachment 115109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115109&action=edit Bug 20212: Remove fix_query and assume ugliness It seems better to do things in an ugly way but simple than complicated. This patch removes the fix_query method that deals with ean and isbn and explicitly tell that it's a trick that must not be reused somewhere else. It should only be used by Koha internally and we should not advertised it until it's ready. This problem will have to be fixed properly when the GET /biblios route will be implemented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #145 from Jonathan Druart --- Created attachment 115108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115108&action=edit Bug 20212: Fix query for the global filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #144 from Jonathan Druart --- Created attachment 115107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115107&action=edit Bug 20212: Re-add EAN for UNIMARC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #143 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #142) > What about the "make it dirty but simple" suggestion? I didn't manage to, because that's not how merge_dbic_query is designed to work. It felt 'simpler' to just use the fix_query function to munge the query parameters and let the tool do its job. I'm open to ideas. Not attached to this Implementation > (In reply to Jonathan Druart from comment #140) > > We are doing it for only one purpose: search on isbn. In that case why don't > > we have a hidden feature to allow that (instead of having ton of code that > > is dealing with all biblioitem attributes)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #142 from Jonathan Druart --- What about the "make it dirty but simple" suggestion? (In reply to Jonathan Druart from comment #140) > We are doing it for only one purpose: search on isbn. In that case why don't > we have a hidden feature to allow that (instead of having ton of code that > is dealing with all biblioitem attributes)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #141 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #140) > I am sorry but I cannot persuade myself that pushing the "fix_query" trick > is a good idea. > > We are doing it for only one purpose: search on isbn. In that case why don't > we have a hidden feature to allow that (instead of having ton of code that > is dealing with all biblioitem attributes)? > Tomas told me that this fix_query won't be reused somewhere else, but > actually IMO we will need to implement it correctly everywhere we search on > biblio. > Like a simple route GET /biblios will need it :) > > If we push it "as it", what would be the next step? If we push it, and it makes sense (i.e. we really need it in other places) we need a second loop similar to that of ->to_api to gather information about the bestest objects with each of them specifying the transformations required for the query. And pass that to the build_query helper. It felt too much for a single case, but can be done if course. > Is there plan to have a > GET /biblios route? Development shifted to routes we need to implement things. There's no plan for that route, still. > I've just noticed I remove the search by ean, that was using the same trick. > We could re-add it easily but we should then display it in the summary > column, for consistency. The EAN filter is dependent on UNIMARC being set. Keep it in mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #140 from Jonathan Druart --- I am sorry but I cannot persuade myself that pushing the "fix_query" trick is a good idea. We are doing it for only one purpose: search on isbn. In that case why don't we have a hidden feature to allow that (instead of having ton of code that is dealing with all biblioitem attributes)? Tomas told me that this fix_query won't be reused somewhere else, but actually IMO we will need to implement it correctly everywhere we search on biblio. Like a simple route GET /biblios will need it :) If we push it "as it", what would be the next step? Is there plan to have a GET /biblios route? I've just noticed I remove the search by ean, that was using the same trick. We could re-add it easily but we should then display it in the summary column, for consistency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
