[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #57 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #56 from Nick Clemens --- This works well, I don't pretend to fully understand the regex,but it does what it says. Possibly the options could be named to be a little more clear. If I understand correctly: Escape - this essentially disables regex searching since all the slashes get escaped and you cannot escape them yourself Don't Escape - does nothing, regex searching works, but slashes must be escaped for normal searching Unescape escaped - enables regex if you escape the regex slashes So maybe? Disable regex searching Enable regex searching (users must escape slashes) Enable regex searching for advanced users I think it is fine as is but needs release notes/documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #55 from Nick Clemens --- Created attachment 93700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93700&action=edit Bug 20334: Move new system preference into right spot in alphabet Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #54 from Nick Clemens --- Created attachment 93699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93699&action=edit Bug 20334: Improve syspref description and set more sensible defaults Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Nick Clemens changed: What|Removed |Added Attachment #93664|0 |1 is obsolete|| Attachment #93665|0 |1 is obsolete|| Attachment #93666|0 |1 is obsolete|| --- Comment #53 from Nick Clemens --- Created attachment 93697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93697&action=edit Bug 20334: Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed Signed-off-by: Nicolas Legrand Signed-off-by: Maksim Sen Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #51 from sandbo...@biblibre.com --- Created attachment 93665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93665&action=edit Bug 20334: Improve syspref description and set more sensible defaults Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #52 from sandbo...@biblibre.com --- Created attachment 93666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93666&action=edit Bug 20334: Move new system preferene into right spot in alphabet Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #50 from sandbo...@biblibre.com --- Created attachment 93664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93664&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed Signed-off-by: Nicolas Legrand Signed-off-by: Maksim Sen Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93586|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93585|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 sandbo...@biblibre.com changed: What|Removed |Added Attachment #93584|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 sandbo...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off CC||sandbo...@biblibre.com --- Comment #49 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #85131|0 |1 is obsolete|| --- Comment #48 from David Gustafsson --- Created attachment 93586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93586&action=edit Bug 20334: Move new system preferene into right spot in alphabet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #85129|0 |1 is obsolete|| --- Comment #46 from David Gustafsson --- Created attachment 93584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93584&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed Signed-off-by: Nicolas Legrand Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #85130|0 |1 is obsolete|| --- Comment #47 from David Gustafsson --- Created attachment 93585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93585&action=edit Bug 20334: Improve syspref description and set more sensible defaults -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #85129|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #93478|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #45 from David Gustafsson --- Realized screwed up when attaching the last patch (using an older version, so mismatch between commits etc). Will restore and rebase again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #44 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 20334: Something went wrong !Applying: Bug 20334: Improve syspref description and set more sensible defaults fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_20334-add-syspref-QueryRegexEscapeOptions.sql). error: could not build fake ancestor Patch failed at 0001 Bug 20334: Improve syspref description and set more sensible defaults -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Ere Maijala changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #43 from Ere Maijala --- Looks like this should do it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #42 from Katrin Fischer --- Ere and David, are more changes needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #41 from David Gustafsson --- Hi! I have not made any changes to the patch, but I had a more recent rebase of this branch locally that had not submitted, So patch should at least apply now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #85129|0 |1 is obsolete|| --- Comment #40 from David Gustafsson --- Created attachment 93478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93478&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #39 from Ere Maijala --- David, are you able to work on this? I'd really like to get this in 19.11, so let my know if you need a hand here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #38 from Katrin Fischer --- Is there something we can do to help get this moving again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Johanna Räisä changed: What|Removed |Added CC||johanna.ra...@koha-suomi.fi --- Comment #37 from Johanna Räisä --- Is anything happening with this bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #36 from Ere Maijala --- I'm ok with disabling regexp altogether for the time being. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #35 from David Gustafsson --- Yes, that change would perhaps be pretty trivial. Still not completely obvious how to try to "autocorrect" the regexps though. The regexps in lucene are always anchored according to https://stackoverflow.com/questions/34312196/elastic-search-query-string-regex That might be the reason why I got strange results when trying out regexps on the format "foo/bar/", which produced no results, while /foobar/ did. I also assume that the regexp is run on the tokenized values in ElasticSearch, with possible stemming, n-grams etc applied (even though I don't think we do any of these at the moment), so it's not very obvious for the user what values are actually matched against. Regexp against a ".raw" subfield behaves more like you would expect, matching against the exact value of the mapped data. I's because of theses issue I think it might be better to disable regexps altogether, possibly with a an option for enabling a less accessible syntax for expert users who know what they are doing. Slashes embedded in word characters are also interpreted as regexp by Elastic since the string "foo/bar" also results in an error. So I also believe it to be a real problem that librarians will input such strings with matching and/or not matching delimiters and get unexpected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #34 from Ere Maijala --- It'd be fine for me to change _truncate_terms to something more general. That'd be a good place to do any other clean up, escaping or query terms transformations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #33 from David Gustafsson --- Yes, it would be much easier to work on a tokenized search string with regards to quotes etc. But do we really do this? We do it in _truncate_terms, but that's only if auto-truncation is enabled. It would be nice if there was some intermediate query format that could be used instead of the raw search string though, but that seems outside the scope of this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #32 from Ere Maijala --- That wouldn't be considered a regexp search since the search term doesn't start and end with a slash. We already split the query to terms, so adding a per-term check is not that complicated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #31 from David Gustafsson --- Hi! I see two major problems with this approach. Firstly, I don't think librarians generally expect, for example, the search terms "Directive 95/46/EC" to be interpreted as containing a regular expression. I would guess that the fraction of librarians who would ever use regular expressions in searches can be rounded down to zero :) I would probably never use it myself. The second problem is that it's probably really nasty to implement as a regular expression, perhaps not even possible, that is: escaping of unescaped slashes if the slash is odd and not in a quoted context. Would probably have to write some kind of parser. Since I think that strings within slashes are generally not meant to be regexps by those who generally use the search interface I went for the two options either to disable them completely, or be allowed, but using a syntax that one would probably not enter accidentally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Hi Ere, thx for your input. What you suggest makes sense for me. Marking FQA to get feedback from David on the suggestion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #29 from Ere Maijala --- I don't really like the fact that a pref may affect how the search terms are interpreted. I'd rather go without the pref and try to do the right automatically: if the term looks like a regexp (i.e. start and ends with a slash), don't escape it so that regexp can be used. Otherwise escape the slashes. Could also additionally validate the regexp to make sure it works. I think this would eliminate the need to for the pref while keeping the versatility and the regular searches working properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #28 from Katrin Fischer --- Thx David! Please reset the status back to signed off next time :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #27 from David Gustafsson --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #80978|0 |1 is obsolete|| --- Comment #25 from David Gustafsson --- Created attachment 85130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85130&action=edit Bug 20334: Improve syspref description and set more sensible defaults -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #81597|0 |1 is obsolete|| --- Comment #26 from David Gustafsson --- Created attachment 85131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85131&action=edit Bug 20334: Move new system preferene into right spot in alphabet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #73222|0 |1 is obsolete|| --- Comment #24 from David Gustafsson --- Created attachment 85129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85129&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed Signed-off-by: Nicolas Legrand Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||ere.maij...@helsinki.fi --- Comment #23 from Katrin Fischer --- Patch doesn't apply right now, conflict looks small. Could we get a rebase please? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20334 - Option for escaping slashes in search queries Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20334 - Option for escaping slashes in search queries The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20334---Option-for-escaping-slashes-in-search--Co2Ks4.patch Also adding Ere here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #81613|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #22 from David Gustafsson --- Ops, didn't realize this was already fix. Will remove the latest patch. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Attachment #81517|0 |1 is obsolete|| --- Comment #21 from David Gustafsson --- Created attachment 81613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81613&action=edit Bug 20334: Add entry in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #20 from Katrin Fischer --- Couldn't resist, being a librarian and all. Moving back to "Signed off" as last 2 follow-ups have been trivial and this was already signed-off before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #19 from Katrin Fischer --- Created attachment 81597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81597&action=edit Bug 20334: Move new system preferene into right spot in alphabet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #18 from Katrin Fischer --- The file is sorted alphabetically to avoid conflicts ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #17 from David Gustafsson --- Ok! I must have missed that for my previous patches. I hope the release manager or someone in the QU team has added the entry in those cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #16 from David Gustafsson --- Created attachment 81517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81517&action=edit Bug 20334: Add entry in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #15 from Katrin Fischer --- Hi David, >I added an entry in the atomicupdate directory, has there been a change so it >>should be added in sysprefs.sql instead? No change, you need both: the atomicupdate is for updating existing installations. The sysprefs.sql is used to create the needed entries in new installations. See: https://wiki.koha-community.org/wiki/Database_updates Thx for the fixes and explanations! Please do the sysprefs.sql as another follow-up and switch back to signed-off instead of needs sign-off as the changes have been trivial. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #14 from David Gustafsson --- @Katrin Fischer: And to clarify, right now the default (Escape) is to disable regular expressions in searches (all "/", which is used as regexp delimiter in Elasticsearch, will be escaped). The "Escape unescaped" will allow regexps, but instead of "/test(ing)?/" you have to write "\/test(ing)?\/" which is harder to do by mistake. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #13 from David Gustafsson --- Created attachment 80978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80978&action=edit Bug 20334: Improve syspref description and set more sensible defaults -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #12 from David Gustafsson --- (In reply to Katrin Fischer from comment #11) > Hi David, > > 1) Can you please add an entry for the new system preference in sysprefs.sql? I added an entry in the atomicupdate directory, has there been a change so it should be added in sysprefs.sql instead? > 2) I wonder, is this something where picking a sensible default behaviour > could make sense? Honestly I am more than a little confused by the different > options, but I can confirm that searching for something containing / won't > work right now, which is a problem. For example, it will break when someone > copies a MARC record for search. Example: > > Dutch : an essential grammar / William Z. Shetter and Inge Van der > Cruysse-Van Antwerpen I changed the default to "Escape", from "Don't escape" since that's probably what most people want (think very few actually uses regexps in search strings). I also expanded the explanation on the system-preferences page. > 3) The system preference doesn't mention that it applies to Elasticsearch > only - I think we need to add this information. I added this info on the system-preferences page. > 4) My sample search: Dutch / William doesn't work with any of the settings. > What am I missing? I think the reason might be that if you included the ":" it will be interpreted as a field query (this could be the subject for another bug). Try just: an essential grammar / William Z. Shetter, for example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi David, 1) Can you please add an entry for the new system preference in sysprefs.sql? 2) I wonder, is this something where picking a sensible default behaviour could make sense? Honestly I am more than a little confused by the different options, but I can confirm that searching for something containing / won't work right now, which is a problem. For example, it will break when someone copies a MARC record for search. Example: Dutch : an essential grammar / William Z. Shetter and Inge Van der Cruysse-Van Antwerpen 3) The system preference doesn't mention that it applies to Elasticsearch only - I think we need to add this information. 4) My sample search: Dutch / William doesn't work with any of the settings. What am I missing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What|Removed |Added Summary|Option for escaping slashes |Elasticsearch - Option for |in search queries |escaping slashes in search ||queries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
