[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #147 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36609

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #146 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #145)
> Small notes from testing (for future follow-ups, not here)
> 
> The 'Add' button cannot be tabbed to - this feels like a small accessibility
> lack
> After adding a field, I must save before I can add mappings - seems ok
> I was able to, in the interface, delete a field with a mapping, but saving
> gave an error and all was restored - ok

Could you please file bugs for these? So we don't lose sight of them. Thank
you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #145 from Nick Clemens  ---
Small notes from testing (for future follow-ups, not here)

The 'Add' button cannot be tabbed to - this feels like a small accessibility
lack
After adding a field, I must save before I can add mappings - seems ok
I was able to, in the interface, delete a field with a mapping, but saving gave
an error and all was restored - ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #144 from Nick Clemens  ---
Created attachment 164793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164793=edit
Bug 20388: (QA follow-up) Tidy

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #143 from Nick Clemens  ---
Created attachment 164792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164792=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 
Signed-off-by: Thomas Klausner 
Signed-off-by: David Schmidt 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #142 from Nick Clemens  ---
Created attachment 164791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164791=edit
Bug 20388: Add trash icon to the delete button

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #141 from Nick Clemens  ---
Created attachment 164790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164790=edit
Bug 20388: Adjust code

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Nick Clemens  changed:

   What|Removed |Added

 Attachment #164532|0   |1
is obsolete||
 Attachment #164533|0   |1
is obsolete||
 Attachment #164534|0   |1
is obsolete||
 Attachment #164535|0   |1
is obsolete||

--- Comment #140 from Nick Clemens  ---
Created attachment 164789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164789=edit
Bug 20388: Elasticsearch - Ability to add search fields from UI

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

davew...@gmx.at changed:

   What|Removed |Added

 Attachment #164531|0   |1
is obsolete||

--- Comment #139 from davew...@gmx.at ---
Created attachment 164535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164535=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 
Signed-off-by: Thomas Klausner 
Signed-off-by: David Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

davew...@gmx.at changed:

   What|Removed |Added

 Attachment #163462|0   |1
is obsolete||

--- Comment #138 from davew...@gmx.at ---
Created attachment 164534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164534=edit
Bug 20388: Add trash icon to the delete button

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

davew...@gmx.at changed:

   What|Removed |Added

 Attachment #163461|0   |1
is obsolete||

--- Comment #137 from davew...@gmx.at ---
Created attachment 164533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164533=edit
Bug 20388: Adjust code

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

davew...@gmx.at changed:

   What|Removed |Added

 Attachment #163460|0   |1
is obsolete||

--- Comment #136 from davew...@gmx.at ---
Created attachment 164532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164532=edit
Bug 20388: Elasticsearch - Ability to add search fields from UI

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #164530|0   |1
is obsolete||

--- Comment #135 from Thomas Klausner  ---
Created attachment 164531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164531=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

davew...@gmx.at changed:

   What|Removed |Added

 Attachment #164529|0   |1
is obsolete||

--- Comment #134 from davew...@gmx.at ---
Created attachment 164530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164530=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: David Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #163463|0   |1
is obsolete||

--- Comment #133 from Thomas Klausner  ---
Created attachment 164529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164529=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35138


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138
[Bug 35138] Elasticsearch - manage facets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michaela Sieber  changed:

   What|Removed |Added

 CC||clemens.tub...@kit.edu,
   ||lukasz.kos...@kit.edu
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #163452|0   |1
is obsolete||

--- Comment #132 from PTFS Europe Sandboxes  ---
Created attachment 163463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163463=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #163451|0   |1
is obsolete||

--- Comment #131 from PTFS Europe Sandboxes  ---
Created attachment 163462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163462=edit
Bug 20388: Add trash icon to the delete button

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #163450|0   |1
is obsolete||

--- Comment #130 from PTFS Europe Sandboxes  ---
Created attachment 163461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163461=edit
Bug 20388: Adjust code

Sponsored-by: The Research University in the Helmholtz Association (KIT)
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #163449|0   |1
is obsolete||

--- Comment #129 from PTFS Europe Sandboxes  ---
Created attachment 163460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163460=edit
Bug 20388: Elasticsearch - Ability to add search fields from UI

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|alex.arn...@biblibre.com|jonathan.dru...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #128 from Jonathan Druart  ---
Created attachment 163452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163452=edit
Bug 20388: Alert if the search field already exists

Sponsored-by: The Research University in the Helmholtz Association (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #127 from Jonathan Druart  ---
Created attachment 163451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163451=edit
Bug 20388: Add trash icon to the delete button

Sponsored-by: The Research University in the Helmholtz Association (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #126 from Jonathan Druart  ---
Created attachment 163450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163450=edit
Bug 20388: Adjust code

Sponsored-by: The Research University in the Helmholtz Association (KIT)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #120104|0   |1
is obsolete||

--- Comment #125 from Jonathan Druart  ---
Created attachment 163449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163449=edit
Bug 20388: Elasticsearch - Ability to add search fields from UI

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2024-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Mathieu Saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2023-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #124 from Michaela Sieber  ---
Is it possible to rebase?

It seems that many libraries and support providers are interested.
And a lot of work has already been done, it would be a pity if it did not
continue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2023-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2023-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #123 from Katrin Fischer  ---
Just ran into this again - especially with us not updating the default mappings
on update it would be important to allow libraries to add indexes i think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2022-05-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #122 from David Nind  ---
Patch no longer applies 8-(..

git bz apply 20388

Bug 20388 - Elasticsearch - Ability to add search fields from UI

120104 - Bug 20388 - Elasticsearch - Ability to add search fields from UI

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20388 - Elasticsearch - Ability to add search fields from UI
Using index info to reconstruct a base tree...
M   Koha/SearchField.pm
M   admin/searchengine/elasticsearch/mappings.pl
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
M   koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
Auto-merging admin/searchengine/elasticsearch/mappings.pl
Auto-merging Koha/SearchField.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20388 - Elasticsearch - Ability to add search fields
from UI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388
Bug 20388 depends on bug 19482, which changed state.

Bug 19482 Summary: Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #121 from Katrin Fischer  ---
(In reply to Gérard Simon Voyer from comment #120)
> Hi Alex!
> 
> I'm trying my hand at sign offs. On a koha-docker-testing CT using master
> branch, I seem to fall on this error upon entering the ElasticSearch
> mappings setup : https://pastebin.com/8Mj7LzvM
> 
> Something I'm doing wrong? I remember this message being addressed in one of
> the obsoleted patches.
> 
> Thanks a lot!

Hi, you can try Actions > Refresh Schema to see if this fixes the issue. An
Actions > Restart services also sometimes doesn't hurt (restarts Plack,
Memcached, Apache etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #120 from Gérard Simon Voyer  ---
Hi Alex!

I'm trying my hand at sign offs. On a koha-docker-testing CT using master
branch, I seem to fall on this error upon entering the ElasticSearch mappings
setup : https://pastebin.com/8Mj7LzvM

Something I'm doing wrong? I remember this message being addressed in one of
the obsoleted patches.

Thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #119 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #118)
> Needs Signoff, again? How was the rebase Alex?

The last one was tiny. But the one 2 weeks ago was tricky. A new signoff
wouldn't be too much.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #118 from Jonathan Druart  
---
Needs Signoff, again? How was the rebase Alex?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #117 from Alex Arnaud  ---
Patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #119318|0   |1
is obsolete||

--- Comment #116 from Alex Arnaud  ---
Created attachment 120104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120104=edit
Bug 20388 - Elasticsearch - Ability to add search fields from UI

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #115 from Gérard Simon Voyer  ---
Is there any way to apply this functionnality on top of the master branch as of
now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #114 from Martin Renvoize  ---
Sorry chaps, this one no longer applies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #113 from Gérard Simon Voyer  ---
What a great way for me to say "Hey, I'm the new in-house dev for Collecto's
version of Koha!"

Thanks again, I swear next time I have to break something, it'll be much more
impressive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #112 from Alex Arnaud  ---
Patches rebased and squashed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #119317|0   |1
is obsolete||

--- Comment #111 from Alex Arnaud  ---
Created attachment 119318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119318=edit
Bug 20388 - Elasticsearch - Ability to add search fields from UI

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #99960|0   |1
is obsolete||
  Attachment #99961|0   |1
is obsolete||
  Attachment #99962|0   |1
is obsolete||
  Attachment #99963|0   |1
is obsolete||
  Attachment #99964|0   |1
is obsolete||
  Attachment #99965|0   |1
is obsolete||
  Attachment #99966|0   |1
is obsolete||
  Attachment #99967|0   |1
is obsolete||

--- Comment #110 from Alex Arnaud  ---
Created attachment 119317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119317=edit
Bug 20388 - Elasticsearch - Ability to add search fields from UI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #109 from Alex Arnaud  ---
(In reply to Gérard Simon Voyer from comment #108)
> (In reply to Gérard Simon Voyer from comment #107)
> > Created attachment 119296 [details] [review] [review]
> > Issue #6 - Restore continue, skip and abort
> 
> All the Saints in the World, what have I done??
> This is completely unintentional, I will cease right now my tinkering with
> git-bz and just apply patches the like I used to.
> 
> Please forgive this dumb mistake

Don't worry Gérard, i marked your patch as obsolete. No consequence

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #119296|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Gérard Simon Voyer  changed:

   What|Removed |Added

 CC||simon.vo...@collecto.ca

--- Comment #108 from Gérard Simon Voyer  ---
(In reply to Gérard Simon Voyer from comment #107)
> Created attachment 119296 [details] [review]
> Issue #6 - Restore continue, skip and abort

All the Saints in the World, what have I done??
This is completely unintentional, I will cease right now my tinkering with
git-bz and just apply patches the like I used to.

Please forgive this dumb mistake

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #107 from Gérard Simon Voyer  ---
Created attachment 119296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119296=edit
Issue #6 - Restore continue, skip and abort

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-12-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #106 from Fridolin Somers  ---
OK for QA ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #105 from Fridolin SOMERS  ---
bug 19482 is pushed master, I reset to previous status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-07-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #104 from Katrin Fischer  ---
This depends on bug 19482 which is currently Failed QA. Marking as BLOCKED
until this is resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_20_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #101 from Michal Denar  ---
Created attachment 99965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99965=edit
Bug 20388: QA fixe : delete line who add elements in biblios and authorities in
the same time

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #100 from Michal Denar  ---
Created attachment 99964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99964=edit
Bug 20388: QA fixes: - pass search field objects in template instead of
unblessed ones - disable drag n drop

Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #102 from Michal Denar  ---
Created attachment 99966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99966=edit
Bug 20388: add of types in the new entries dropdown of searchfiels

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #103 from Michal Denar  ---
Created attachment 99967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99967=edit
Bug 20388: QA fixe : add searchfield only if it doesn't exist

To test:

Without the fix:
- in search field configuration -> search field
- add the search field "uri" at the bottom of the tab
- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg

Then apply the fix
- try to add the search field uri
- this time an alert should appear with the message :
" SearchField uri already exist "

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #99 from Michal Denar  ---
Created attachment 99963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99963=edit
Bug 20388: Use live handler for deleting elements

Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #97 from Michal Denar  ---
Created attachment 99961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99961=edit
Bug 20388: Keep data consistency when adding/removing mapping

Test plan:
  - create a new search field, save,
  - create a mapping using it (don't save),
  - check that you can't delete the search field.

  - delete all the mapping related to a search field (biblios and
authorities), don't save,
  - check that you can delete this search field.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #98 from Michal Denar  ---
Created attachment 99962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99962=edit
Bug 20388: Prevent user from using a search field for a mapping after removing
it

Test plan:

 - add a search field,
 - save,
 - remove this search field
 - check that it has been removed from the mapping lists (bottom
   select).

Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-03-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michal Denar  changed:

   What|Removed |Added

  Attachment #98011|0   |1
is obsolete||
  Attachment #98012|0   |1
is obsolete||
  Attachment #98013|0   |1
is obsolete||
  Attachment #98014|0   |1
is obsolete||
  Attachment #98015|0   |1
is obsolete||
  Attachment #98016|0   |1
is obsolete||
  Attachment #98017|0   |1
is obsolete||
  Attachment #98018|0   |1
is obsolete||

--- Comment #96 from Michal Denar  ---
Created attachment 99960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99960=edit
Bug 20388: Add/delete search fields from search engine configuration page

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Depends on||19482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
[Bug 19482] Elasticsearch - prevent removal / editing of required indexes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #95 from Alex Arnaud  ---
Patches have been rebased on upon bug 19482 which prevent removing mandatory
fields.

So set back to need signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90523|0   |1
is obsolete||

--- Comment #93 from Alex Arnaud  ---
Created attachment 98017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98017=edit
Bug 20388: add of types in the new entries dropdown of searchfiels

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90524|0   |1
is obsolete||

--- Comment #94 from Alex Arnaud  ---
Created attachment 98018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98018=edit
Bug 20388: QA fixe : add searchfield only if it doesn't exist

To test:

Without the fix:
- in search field configuration -> search field
- add the search field "uri" at the bottom of the tab
- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg

Then apply the fix
- try to add the search field uri
- this time an alert should appear with the message :
" SearchField uri already exist "

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90522|0   |1
is obsolete||

--- Comment #92 from Alex Arnaud  ---
Created attachment 98016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98016=edit
Bug 20388: QA fixe : delete line who add elements in biblios and authorities in
the same time

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90521|0   |1
is obsolete||

--- Comment #91 from Alex Arnaud  ---
Created attachment 98015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98015=edit
Bug 20388: QA fixes: - pass search field objects in template instead of
unblessed ones - disable drag n drop

Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90520|0   |1
is obsolete||

--- Comment #90 from Alex Arnaud  ---
Created attachment 98014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98014=edit
Bug 20388: Use live handler for deleting elements

Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90519|0   |1
is obsolete||

--- Comment #89 from Alex Arnaud  ---
Created attachment 98013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98013=edit
Bug 20388: Prevent user from using a search field for a mapping after removing
it

Test plan:

 - add a search field,
 - save,
 - remove this search field
 - check that it has been removed from the mapping lists (bottom
   select).

Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90517|0   |1
is obsolete||

--- Comment #87 from Alex Arnaud  ---
Created attachment 98011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98011=edit
Bug 20388: Add/delete search fields from search engine configuration page

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #90518|0   |1
is obsolete||

--- Comment #88 from Alex Arnaud  ---
Created attachment 98012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98012=edit
Bug 20388: Keep data consistency when adding/removing mapping

Test plan:
  - create a new search field, save,
  - create a mapping using it (don't save),
  - check that you can't delete the search field.

  - delete all the mapping related to a search field (biblios and
authorities), don't save,
  - check that you can delete this search field.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

anne-cecile.bor...@iepg.fr changed:

   What|Removed |Added

 CC||anne-cecile.bor...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20589
 Status|Signed Off  |ASSIGNED
 QA Contact||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #84 from Michal Denar  ---
Created attachment 90522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90522=edit
Bug 20388: QA fixe : delete line who add elements in biblios and authorities in
the same time

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #85 from Michal Denar  ---
Created attachment 90523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90523=edit
Bug 20388: add of types in the new entries dropdown of searchfiels

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #82 from Michal Denar  ---
Created attachment 90520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90520=edit
Bug 20388: Use live handler for deleting elements

Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #86 from Michal Denar  ---
Created attachment 90524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90524=edit
Bug 20388: QA fixe : add searchfield only if it doesn't exist

To test:

Without the fix:
- in search field configuration -> search field
- add the search field "uri" at the bottom of the tab
- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg

Then apply the fix
- try to add the search field uri
- this time an alert should appear with the message :
" SearchField uri already exist "

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #83 from Michal Denar  ---
Created attachment 90521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90521=edit
Bug 20388: QA fixes: - pass search field objects in template instead of
unblessed ones - disable drag n drop

Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #81 from Michal Denar  ---
Created attachment 90519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90519=edit
Bug 20388: Prevent user from using a search field for a mapping after removing
it

Test plan:

 - add a search field,
 - save,
 - remove this search field
 - check that it has been removed from the mapping lists (bottom
   select).

Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #80 from Michal Denar  ---
Created attachment 90518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90518=edit
Bug 20388: Keep data consistency when adding/removing mapping

Test plan:
  - create a new search field, save,
  - create a mapping using it (don't save),
  - check that you can't delete the search field.

  - delete all the mapping related to a search field (biblios and
authorities), don't save,
  - check that you can delete this search field.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Michal Denar  changed:

   What|Removed |Added

  Attachment #88079|0   |1
is obsolete||
  Attachment #88080|0   |1
is obsolete||
  Attachment #88081|0   |1
is obsolete||
  Attachment #88082|0   |1
is obsolete||
  Attachment #88083|0   |1
is obsolete||
  Attachment #89121|0   |1
is obsolete||
  Attachment #89733|0   |1
is obsolete||
  Attachment #89894|0   |1
is obsolete||

--- Comment #79 from Michal Denar  ---
Created attachment 90517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90517=edit
Bug 20388: Add/delete search fields from search engine configuration page

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 
Signed-off-by: Julian Maurice 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

axel Amghar  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #78 from axel Amghar  ---
Created attachment 89894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89894=edit
Bug 20388: QA fixe : add searchfield only if it doesn't exist

To test:

Without the fix:
- in search field configuration -> search field
- add the search field "uri" at the bottom of the tab
- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg

Then apply the fix
- try to add the search field uri
- this time an alert should appear with the message :
" SearchField uri already exist "

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #77 from Jonathan Druart  
---
Like that, adding a new 'uri' field: https://snag.gy/BpxcIq.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #75 from axel Amghar  ---
(In reply to Liz Rea from comment #73)
> Re-checked this today, and the fields showed up. Quite sure I didn't do
> anything differently, sorry for the noise.
> 
> As Jonathan noted, the types for the new entries don't match with the types
> in the existing entries. Is that intentional?
> 
> When I tested adding a name and label that already existed, it added it for
> me - I don't know if that is correct or incorrect behaviour.

Hi, 
I fix the types for the new entries ( I don't think it was intentional).
But for the adding, I didn't succeed to reproduce your bug.
How did you do it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #75 from axel Amghar  ---
(In reply to Liz Rea from comment #73)
> Re-checked this today, and the fields showed up. Quite sure I didn't do
> anything differently, sorry for the noise.
> 
> As Jonathan noted, the types for the new entries don't match with the types
> in the existing entries. Is that intentional?
> 
> When I tested adding a name and label that already existed, it added it for
> me - I don't know if that is correct or incorrect behaviour.

Hi, 
I fix the types for the new entries ( I don't think it was intentional).
But for the adding, I didn't succeed to reproduce your bug.
How did you do it?

--- Comment #76 from axel Amghar  ---
(In reply to Liz Rea from comment #73)
> Re-checked this today, and the fields showed up. Quite sure I didn't do
> anything differently, sorry for the noise.
> 
> As Jonathan noted, the types for the new entries don't match with the types
> in the existing entries. Is that intentional?
> 
> When I tested adding a name and label that already existed, it added it for
> me - I don't know if that is correct or incorrect behaviour.

Hi, 
I fix the types for the new entries ( I don't think it was intentional).
But for the adding, I didn't succeed to reproduce your bug.
How did you do it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #74 from axel Amghar  ---
Created attachment 89733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89733=edit
Bug 20388: add of types in the new entries dropdown of searchfiels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #73 from Liz Rea  ---
Re-checked this today, and the fields showed up. Quite sure I didn't do
anything differently, sorry for the noise.

As Jonathan noted, the types for the new entries don't match with the types in
the existing entries. Is that intentional?

When I tested adding a name and label that already existed, it added it for me
- I don't know if that is correct or incorrect behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #72 from Jonathan Druart  
---
Also, if you add a field that already exists, it is ignored (no warning, no
updated).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #71 from Jonathan Druart  
---
The new "add" line appears for me, but the "Type" dropdown does not contain the
same values as above. Please double check.

In case of misunderstanding it's always good to share a screenshot, so here it
is:
https://snag.gy/2XiGEd.jpg # Scroll down!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-05-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #70 from axel Amghar  ---
(In reply to Liz Rea from comment #69)
> there were no entry boxes at the bottom of either tab, sorry.

If you realy are in search engine configuration. 

Remove the patch, so you should be in master.
- return to search engine configuration 
- go to bibliographic records or authorities
- at the bottom of the tab, you should see the add line because this patch just
add the line at the bottom of search field
- if you don't, there is a issue on your side

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >