[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID

--- Comment #4 from Jonathan Druart  
---
This is no longer valid since bug 20538

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

--- Comment #3 from M. Tompsett  ---
I confirmed the sensibility of the regular expression by running this in the
kohaclone directory:

git grep KOHA_VERSION | sed -E 's#(^.*:).*(=".*KOHA_VERSION ).*#\1: \2#g' |
sort -u | less

For some reason two paths are hard coded with opac-tmpl.
Most things have interface, but there is themelang.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

--- Comment #2 from M. Tompsett  ---
Created attachment 72972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72972=edit
Bug 20425: Improve regular expression.

See comment #1 for test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

--- Comment #1 from M. Tompsett  ---
Created attachment 72968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72968=edit
Bug 20425: [DO NOT PUSH] False Positive AND Failure

TEST PLAN
-
1) Apply this first patch to your kohaclone
2) run qa test tools in kohaclone
   -- two issues will be raised
3) Apply the second patch to your qa-test-tools
4) run qa test tools again in your kohaclone
   -- only one issue will be raised
5) confirm that the one issue is the requiring KOHA_VERSION

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20425] Reducing false positives on KOHA_VERSION

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20425

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|jonathan.dru...@bugs.koha-c |mtomp...@hotmail.com
   |ommunity.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/