[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #33 from Jonathan Druart --- (In reply to Colin Campbell from comment #31) > Any finds in quote processing are redundant > > logic is > > Create basket > if return is ok [; >

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Marcel de Rooy changed: What|Removed |Added Attachment #73736|0

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #31 from Colin Campbell --- Any finds in quote processing are redundant logic is Create basket if return is ok [; create orderline create orderline ]; The find was introduced on

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Josef Moravec changed: What|Removed |Added Attachment #73424|0 |1

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #29 from Colin Campbell --- Its not sensible it adds a lot of code to test something we already have the result of. The only basket info we want is the basketno, returned on creation which

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #28 from Jonathan Druart --- I have attached an alternative patch for this issue. Could you please test and confirm it makes sense? I have tried but failed writing tests for

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Jonathan Druart changed: What|Removed |Added Attachment #73156|0

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #25) > (In reply to Jonathan Druart from comment #22) > > It's more about consistency: AcqCreateItem pref's value should

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Bug 20446 depends on bug 15685, which changed state. Bug 15685 Summary: Allow creation of items (AcqCreateItem) to be customizable per-basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 What

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #23 from Nick Clemens --- Picking this for 17.11.04 to restore functionality - will watch here for final resolution and update as needed -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #22 from Jonathan Druart --- It's more about consistency: AcqCreateItem pref's value should not be retrieved directly, the logic should be stay in Koha::Acquisition::Basket --

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #21 from Colin Campbell --- (In reply to Jonathan Druart from comment #20) > The original problem is that we are calling ->find on Koha::Object instead > of the set class (Koha::Objects)

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #20 from Jonathan Druart --- The original problem is that we are calling ->find on Koha::Object instead of the set class (Koha::Objects) -my $basket =

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Kyle M Hall changed: What|Removed |Added Attachment #73104|0 |1

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #17 from Katrin Fischer --- Kyle, can you QA please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #16 from Kyle M Hall --- (In reply to Colin Campbell from comment #7) > Kyle your patch is illogical the baskets in question CANNOT override the > syspreference, because we have just created

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 M. Tompsett changed: What|Removed |Added Status|Failed QA |Signed

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #14 from Katrin Fischer --- We can ask why no tests was submitted initially OR when the new feature was added, but this doesn't change that this is a critical bug and we broke an important

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #13 from Colin Campbell --- (In reply to M. Tompsett from comment #12) > My mistake. Colin is correct. misc/cronjobs/edi_cron.pl calls > process_quote() in Koha::EDI, which calls

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #12 from M. Tompsett --- My mistake. Colin is correct. misc/cronjobs/edi_cron.pl calls process_quote() in Koha::EDI, which calls quote_item in Koha::EDI. As far as I can tell there is no other way

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #11 from Colin Campbell --- (In reply to Colin Campbell from comment #10) > There is and cannot be a user interaction - you bare processing a file there > is no user satr at a terminal.

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #10 from Colin Campbell --- There is and cannot be a user interaction - you bare processing a file there is no user satr at a terminal. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Colin Campbell changed: What|Removed |Added Attachment #73103|0

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #7 from Colin Campbell --- Kyle your patch is illogical the baskets in question CANNOT override the syspreference, because we have just created them in accordance with that syspreference

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #6 from Kyle M Hall --- (In reply to Colin Campbell from comment #4) > Where was the test when this code was introduced to break EDI? A lack of a test does not obviate our responsibility to

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Kyle M Hall changed: What|Removed |Added Attachment #73090|0 |1

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Mason James changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #4 from Colin Campbell --- Where was the test when this code was introduced to break EDI? Basically people cant run Edifact EDI with the addition of this code It undoes a change that

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 M. Tompsett changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Colin Campbell changed: What|Removed |Added

[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

2018-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Colin Campbell changed: What|Removed |Added Severity|enhancement