[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Blocks|20472 | Referenced Bugs:

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #25 from Jonathan Druart --- Created attachment 77169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77169=edit Bug 20468: (follow-up) Changes to checkbox/menu interactions This patch makes a couple

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #27 from Jonathan Druart --- Created attachment 77171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77171=edit Bug 20468: (QA follow-up) Deactivate select/clear all for empty tab This only pertains

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Jonathan Druart changed: What|Removed |Added Attachment #74711|0 |1 is obsolete|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #26 from Jonathan Druart --- Created attachment 77170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77170=edit Bug 20468: (follow-up) Cancel multiple items for same reason The repeated prompts for

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #23 from Marcel de Rooy --- Created attachment 76626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76626=edit Bug 20468: (QA follow-up) Deactivate select/clear all for empty tab This only pertains to

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > Marcel, (last patch) could not we use only null (instead of undefined vs > null)? Please see comment19. I need both values. These are standard

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #21 from Jonathan Druart --- Marcel, (last patch) could not we use only null (instead of undefined vs null)? There is also a tiny ergonomic issue, hit /circ/article-requests.pl, click the "processing" tab. There are

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Attachment #75846|0 |1 is obsolete|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #18) > undefined vs null is confusing here. Null comes back from a cancelled prompt. And I want to differentiate between no prompt and a cancelled

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #18 from Jonathan Druart --- undefined vs null is confusing here. Moreover cannot we display the title of the biblio in the popup? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #17 from Marcel de Rooy --- Created attachment 75846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75846=edit Bug 20468: (follow-up) Cancel multiple items for same reason The repeated prompts for

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > There are several "Reason for cancellation:" pop-ups, it that expected? Yes, HandleMulti makes repeated calls here. I agree that it is not

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #15 from Jonathan Druart --- There are several "Reason for cancellation:" pop-ups, it that expected? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #14 from Marcel de Rooy --- Merged the last two patches into the last one of Owen. Thx Owen. Great design improvements ! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Attachment #75720|0 |1 is obsolete|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #12 from Owen Leonard --- Created attachment 75741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75741=edit Bug 20468: (follow-up) Changes to checkbox/menu interactions This patch makes a couple of

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > Created attachment 75720 [details] [review] > Bug 20468: (QA follow-up) Design issues > > Moving selection stuff to the top. > Why does the

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #10 from Marcel de Rooy --- Created attachment 75720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75720=edit Bug 20468: (QA follow-up) Design issues Moving selection stuff to the top. Why does the

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #9 from Marcel de Rooy --- (In reply to Owen Leonard from comment #6) > I agree with Joubu. In order to be consistent with every similar interface > in Koha the select all/clear all links should be at the top of the

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #8 from Marcel de Rooy --- (In reply to Owen Leonard from comment #7) > By the way, I get an error when I try to print a slip: "Undefined subroutine > ::Letters::GetPreparedLetter called at >

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #7 from Owen Leonard --- By the way, I get an error when I try to print a slip: "Undefined subroutine ::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/circ/article-request-slip.pl line 49." -- You are

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Owen Leonard changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > Why did you put it at the bottom of the page? > > IMO it seems better to place it on top of the table (inside the tab). IMO it apparently did

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #3 from Marcel de Rooy --- (In reply to Dilan Johnpullé from comment #2) > Signed-off-by: Dilan Johnpullé Thx Dilan -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Dilan Johnpullé changed: What|Removed |Added Attachment #73280|0 |1

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 Marcel de Rooy changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #1 from Marcel de Rooy --- Created attachment 73280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73280=edit Bug 20468: Add multi-select to staff article request form Adds a