[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED

--- Comment #13 from Martin Renvoize  ---
Enhancement, not back porting for 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75653|0   |1
is obsolete||
  Attachment #75654|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 75716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75716=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #11 from Jonathan Druart  
---
Created attachment 75717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75717=edit
Bug 20495: (follow-up) Correct search for report by name

Ultimately we should probably remove name access as it is not a unique
id, but this should preserve existing behaviour

To test:
Create a report
Use the service link to confirm the report runs
Replace id=# parameter with name=XX
Confirm URL works

Signed-off-by: Jonathan Druart 
Note: We should not remove the param "name", it's a feature, see bug 8256.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #9 from Nick Clemens  ---
Created attachment 75654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75654=edit
Bug 20495: (follow-up) Correct search for report by name

Ultimately we should probably remove name access as it is not a unique
id, but this should preserve existing behaviour

To test:
Create a report
Use the service link to confirm the report runs
Replace id=# parameter with name=XX
Confirm URL works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Nick Clemens  changed:

   What|Removed |Added

  Attachment #74870|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 75653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75653=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Jonathan Druart  
---
+my $report_rec = Koha::Reports->find( $report_name ? { 'name' => $report_name
} : { 'id' => $report_id } );

This is wrong: there is no saved_sql.name column, and saved_sql.report_name is
not a uniq key (so you should ->search instead of find).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495
Bug 20495 depends on bug 20052, which changed state.

Bug 20052 Summary: Add Reports object class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

  Attachment #74869|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 74870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74870=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #5 from M. Tompsett  ---
(In reply to M. Tompsett from comment #4)
> Nick, could you confirm that compound reports are not possible? I think one
> of your changes is valid, but pointless.

I jumped back to 3.0.x and:
   git grep "Create Compound Report"
only displays in guided reports once!

If you can't create compound reports, then you can't save them.
I think I'll create a bug to remove those parts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #4 from M. Tompsett  ---
Nick, could you confirm that compound reports are not possible? I think one of
your changes is valid, but pointless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73423|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 74869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74869=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

NOTE: rebased and fixed typo "fund" vs. "find"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #74868|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #2 from M. Tompsett  ---
Created attachment 74868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74868=edit
Bug 20495: Follow up to refactor tools/scheduler

TEST PLAN
-
This doesn't require the other patch applied.

-- Make sure you have at least 2 saved reports.
   If you create them from an empty DB, they are 1 and 2
   otherwise, you'll need to know their ID numbers.

Home -> Tools -> Task Scheduler
-- The Report Dropdown has content!

localhost:8081/cgi-bin/koha/tools/scheduler.pl?id=1
-- The Report Dropdown is non-empty and correctly selected
-- Attempt with id=2, different report selected.

apply this patch
restart_all

Home -> Tools -> Task Scheduler
-- Report dropdown has same content!

localhost:8081/cgi-bin/koha/tools/scheduler.pl?id=1
-- The Report Dropdown is non-empty and correctly selected
-- Attempt with id=2, different report selected.
-- effectively no change.

run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Nick Clemens  changed:

   What|Removed |Added

 Depends on||20052


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052
[Bug 20052] Add Reports object class
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #1 from Nick Clemens  ---
Created attachment 73423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73423=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/