[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #8 from Nick Clemens --- Enhancement, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 --- Comment #6 from Katrin Fischer --- I think this is a good cosmetic fix, but we could rethink removing some in favor of the existing button separately. That said, I think the add link makes sense when there are already some messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- We already have "Add message" in the toolbar, should not we remove this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Katrin Fischer changed: What|Removed |Added Attachment #73787|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 73827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73827&action=edit Bug 20518 - Don't show "Messages" header and link on patron details if there are no messages This patch modifies the patron detail page so that the "Messages" header is not displayed if there are no messages. Unrelated: A minor change was made to moremember.pl to quiet an error in the log, "Use of uninitialized value $print in string eq at members/moremember.pl line 219." To test, apply the patch and open the detail page for a patron who has no messages. There should be no "Messages" header or "add message" link. Add a message to the patron's account. The message should appear, along with the "Messages" header and "add message" link. The error logs should show no errors. Signed-off-by: Maksim Sen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I wonder if we should make the same changes on the checkouts tab. The button in the toolbar has been implemented with 16.xx I think, so it should hopefully be well established by now (separate bug). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Maksim Sen changed: What|Removed |Added CC||maksim@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Maksim Sen changed: What|Removed |Added Attachment #73654|0 |1 is obsolete|| --- Comment #2 from Maksim Sen --- Created attachment 73787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73787&action=edit Bug 20518 - Don't show "Messages" header and link on patron details if there are no messages This patch modifies the patron detail page so that the "Messages" header is not displayed if there are no messages. Unrelated: A minor change was made to moremember.pl to quiet an error in the log, "Use of uninitialized value $print in string eq at members/moremember.pl line 219." To test, apply the patch and open the detail page for a patron who has no messages. There should be no "Messages" header or "add message" link. Add a message to the patron's account. The message should appear, along with the "Messages" header and "add message" link. The error logs should show no errors. Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Maksim Sen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Owen Leonard changed: What|Removed |Added Blocks||20520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 [Bug 20520] Re-indent moremember.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 --- Comment #1 from Owen Leonard --- Created attachment 73654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73654&action=edit Bug 20518 - Don't show "Messages" header and link on patron details if there are no messages This patch modifies the patron detail page so that the "Messages" header is not displayed if there are no messages. Unrelated: A minor change was made to moremember.pl to quiet an error in the log, "Use of uninitialized value $print in string eq at members/moremember.pl line 219." To test, apply the patch and open the detail page for a patron who has no messages. There should be no "Messages" header or "add message" link. Add a message to the patron's account. The message should appear, along with the "Messages" header and "add message" link. The error logs should show no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
