[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added CC|bugzi...@warmlight.co.uk| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #18 from Fridolin SOMERS --- Depends on Bug 20284 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Bug 20548 depends on bug 20941, which changed state. Bug 20941 Summary: Displaying requests does not display request material type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Bug 20548 depends on bug 20284, which changed state. Bug 20284 Summary: ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Blocks||20996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 [Bug 20996] Fix API response time on ILL request endpoint -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Depends on||20941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 [Bug 20941] Displaying requests does not display request material type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Martin Renvoize changed: What|Removed |Added Blocks|18589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Martin Renvoize changed: What|Removed |Added Keywords||rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #17 from Martin Renvoize --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Chris Cormack changed: What|Removed |Added Attachment #79414|0 |1 is obsolete|| --- Comment #15 from Chris Cormack --- Created attachment 80244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80244&action=edit Bug 20548: (follow-up) Fix unit tests Removed the "Backend create: copyright clearance" unit test since we no longer have a "copyrightclearance" stage, hence we don't have a block in the template handling it, hence the test failure! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Chris Cormack changed: What|Removed |Added Attachment #79051|0 |1 is obsolete|| --- Comment #14 from Chris Cormack --- Created attachment 80243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80243&action=edit Bug 20548: Remove copyright clearance for staff This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood Signed-off-by: Barry Cannon Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 --- Comment #13 from Andrew Isherwood --- Thanks Nick. It actually required the removal of a test that is no longer applicable due to the original patch removing the code that it tested! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 --- Comment #12 from Andrew Isherwood --- Created attachment 79414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79414&action=edit Bug 20548: (follow-up) Fix unit tests Removed the "Backend create: copyright clearance" unit test since we no longer have a "copyrightclearance" stage, hence we don't have a block in the template handling it, hence the test failure! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- please add unit tests to cover this change. After applying: vagrant@kohadevbox:kohaclone(master)$ prove /home/vagrant/kohaclone/t/db_dependent/Illrequests.t /home/vagrant/kohaclone/t/db_dependent/Illrequests.t .. 4/11 Use of uninitialized value $backend_dir in join or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 665. # Failed test 'Backend create: copyright clearance.' # at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 412. # Structures begin differing at: # $got->{value} = Does not exist # $expected->{value} = HASH(0x971d1e0) # Failed test 'Backend create: arbitrary stage.' # at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 426. # Structures begin differing at: # $got->{stage} = 'commit' # $expected->{stage} = 'bar' Use of uninitialized value $stage in string eq at /home/vagrant/kohaclone/Koha/Illrequest.pm line 630. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 666. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/Illrequest.pm line 668. # Failed test 'Backend create: arbitrary stage, permitted.' # at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 444. # Structures begin differing at: # $got->{permitted} = Does not exist # $expected->{permitted} = '1' # Looks like you failed 3 tests of 18. # Failed test 'Backend core methods' # at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 534. # Looks like you failed 1 test of 11. /home/vagrant/kohaclone/t/db_dependent/Illrequests.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 --- Comment #10 from Andrew Isherwood --- A patch for this is now at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 --- Comment #9 from Andrew Isherwood --- Hi Jonathan, this is actually a bug in master. I spotted it the other day but completely forgot to do anything about it, thanks for the reminder. It seems that at some point the "| html" filter was erroneously added to some variable declarations that weren't strings, these specifically: https://github.com/PTFS-Europe/koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt#L483-L485 Since these variables are either hashrefs or arrayrefs, the filter breaks them, hence the problem you're seeing. I'll create a new bug and get them fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Andrew, did you notice the empty button (with and without the patch): https://snag.gy/9PQ5yL.jpg on /cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Jonathan Druart changed: What|Removed |Added Attachment #74549|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 79051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79051&action=edit Bug 20548: Remove copyright clearance for staff This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood Signed-off-by: Barry Cannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 --- Comment #6 from Claire Gravely --- dependency is pushed, changing back to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Claire Gravely changed: What|Removed |Added Status|BLOCKED |Signed Off CC||claire_grav...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Joe McGlynn changed: What|Removed |Added CC||joe.mcgl...@educampus.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Blocks||18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Martin Renvoize changed: What|Removed |Added Depends on|7317| CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Dependency in FQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Barry Cannon changed: What|Removed |Added Attachment #74155|0 |1 is obsolete|| --- Comment #4 from Barry Cannon --- Created attachment 74549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74549&action=edit Remove copyright clearance for staff This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood Signed-off-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Barry Cannon changed: What|Removed |Added CC||b...@interleaf.ie Status|Needs Signoff |Signed Off --- Comment #3 from Barry Cannon --- This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood Signed-off-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Attachment #73871|0 |1 is obsolete|| --- Comment #2 from Andrew Isherwood --- Created attachment 74155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74155&action=edit Bug 20548: Remove copyright clearance for staff This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) As an OPAC user make an ILL request: a) Navigate to a search results page in the catalog b) Click the "Make an Interlibrary Loan request" link at the bottom c) Choose "Create a new request", then select a backend d) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing 5) As a staff user, select the "ILL requests" button on the front page of the intranet site a) Choose "Create a new request", then select a backend b) Observe that you are NOT prompted to agree to the text you added earlier Assigned-to: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 --- Comment #1 from Andrew Isherwood --- Created attachment 73871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73871&action=edit Bug [20548] - [Remove copyright clearance workfl..] This patch removes the erroneously added workflow that requires staff users to agree to the copyright clearance declaration defined in the ILLModuleCopyrightClearance preference. Only OPAC users should be required to accept the declaration. TEST PLAN - - Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends - Ensure you have the "ILLModule" preference enabled - Add some text to the "ILLModuleCopyrightClearance" preference - As an OPAC user make an ILL request: - Navigate to a search results page in the catalog - Click the "Make an Interlibrary Loan request" link at the bottom - Choose "Create a new request", then select a backend - TEST: Check the text you added earlier is displayed with buttons for agreeing or disagreeing - As a staff user, select the "ILL requests" button on the front page of the intranet site - Choose "Create a new request", then select a backend - TEST: Check that you are NOT prompted to agree to the text you added earlier -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Andrew Isherwood changed: What|Removed |Added Depends on||20284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 [Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/