[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #76 from David Gustafsson  ---
Must have forgotten to change status, setting to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #75 from David Gustafsson  ---
Thanks again for the feedback, I think at least the most important issues
should now be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #74 from David Gustafsson  ---
Created attachment 132937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132937=edit
Bug 20551: Refactor unmotivated partially applied validator function

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #73 from David Gustafsson  ---
Created attachment 132936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132936=edit
Bug 20551: Fetch deleted biblios through _get_record_export

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #72 from David Gustafsson  ---
(_get_record_for_export is still called to fetch the other records though, so
no functionality has been removed there, but reading what it does don't se how
most of the same operations should not work also on deleted biblios)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #71 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #62)
> -my $record = _get_record_for_export( { %$params, record_id =>
> $record_id } );
> 
> +for my $record (@records, @deleted_records) {
> +print MARC::File::XML::record($record);
> 
> Noting that get_record_for_export does a lot more and we seem to loose that
> now?

Yes, right now I can't think of any reason why deleted records should not be a
new record type in _get_record_for_export and processed in the same way as the
others (authorities and biblios). I will look into this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #70 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #61)
> +my ($record_type) = @_;
> 
> +my $validator = $encoding_validator->('Record');
> 
> +$validator = $encoding_validator->('Deleted record');
> 
> Deleted flag ?

I don't think I understand. The string is correct, but looking at the code I
wonder why creating a closure instead of just providing the argument further
down, I should probably change this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #69 from David Gustafsson  ---
Sorry, the last comment was meant to be a response to:

> And functionally: why not deleted records in csv ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #68 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #59)
> sub export
> 
> binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
> } else {
> binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
> 
> What happens if we choose csv? Are we not doing UTF-8 ?
> Later we do:
> 
> print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );

marc2csv uses GetMarcBiblio to load biblios that does not support loading
deleted biblios which resides in another table. marc2csv would have to be
carefully reviewed and refactored to ensure it can handle deleted biblios, this
would increase the scope of this patch and I just did not think it was worth
the effort. A separate issues could perhaps be created in case there is an
interest implementing support for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #67 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #59)
> sub export
> 
> binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
> } else {
> binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
> 
> What happens if we choose csv? Are we not doing UTF-8 ?
> Later we do:
> 
> print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );

I had a look at this and don't think this block is part of the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #66 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #57)
> +my $marc_flavour = C4::Context->preference('marcflavour');
> +my $biblio_metadata = $resultset->find({
> +'biblionumber' => $biblionumber,
> +'format' => 'marcxml',
> +'marcflavour' => $marc_flavour
> +});
> +my $marc_xml = $biblio_metadata->metadata;
> +$marc_xml = StripNonXmlChars($marc_xml);
> +
> +my $record = eval {
> +MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
> +};
> +if (!$record) {
> 
> You test $record, but you should have tested $biblio_metadata too ?
> Otherwise you already crash on ->metadata..

Hi, thanks for the feedback. There is no definite right or wrong, but
personally try to avoid defensive programming where things are very unlikely to
fail. Ids should be valid since have been previously fetched from database, in
case of the XML-decoding it's highly unlikely to go wrong, but I can imagine
cases where it could.(In reply to Marcel de Rooy from comment #58)
> +return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
> 'csv');
> 
> Parentheses here would be more helpful inside. The outer ones are not needed.
> But in order to read easier, you could do A || ( B && C )

Yes,they could be removed. Personally I think it's more confusing, or at least
a bit unsightly, to use parenthesis for anything else than changing operator
precedence. At least with "||" and "&&" where there really should be no
confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #65 from David Gustafsson  ---
(In reply to Marcel de Rooy from comment #57)
> +my $marc_flavour = C4::Context->preference('marcflavour');
> +my $biblio_metadata = $resultset->find({
> +'biblionumber' => $biblionumber,
> +'format' => 'marcxml',
> +'marcflavour' => $marc_flavour
> +});
> +my $marc_xml = $biblio_metadata->metadata;
> +$marc_xml = StripNonXmlChars($marc_xml);
> +
> +my $record = eval {
> +MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
> +};
> +if (!$record) {
> 
> You test $record, but you should have tested $biblio_metadata too ?
> Otherwise you already crash on ->metadata..

Hi, thanks for the feedback. There is no definite right or wrong, but
personally try to avoid defensive programming where things are very unlikely to
fail. Ids should be valid since have been previously fetched from database, in
case of the XML-decoding it's highly unlikely to go wrong, but I can imagine
cases where it could.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #64 from Cab Vinton  ---
(In reply to Katrin Fischer from comment #56)
> From looking at the patch set this will only appear in the command line
> script. But as this has been waiting a while now, I suggest we file a
> separate report for making this available on GUI side. What do you think?

I missed this earlier, but Yes, a separate report for the GUI side makes sense.
I would wait until this one is fully signed off, but others are welcome to
proceed if they wish.

Not sure how prevalent this is, but I believe quite a few union catalogs still
ask contributing members to regularly send updates w/ lists of records added &
deleted. So this feature would come in handy for all the folks who don't have
access to the command line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #63 from Marcel de Rooy  ---
Ok, not all my questions have the same importance and I realize that this dev
is already too long in the pipeline, but I like to have feedback now.

Changing status to reflect that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #62 from Marcel de Rooy  ---
-my $record = _get_record_for_export( { %$params, record_id =>
$record_id } );

+for my $record (@records, @deleted_records) {
+print MARC::File::XML::record($record);

Noting that get_record_for_export does a lot more and we seem to loose that
now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #61 from Marcel de Rooy  ---
+my ($record_type) = @_;

+my $validator = $encoding_validator->('Record');

+$validator = $encoding_validator->('Deleted record');

Deleted flag ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #60 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #58)
> +return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
> 'csv');
> 
> Parentheses here would be more helpful inside. The outer ones are not needed.
> But in order to read easier, you could do A || ( B && C )

And functionally: why not deleted records in csv ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #59 from Marcel de Rooy  ---
sub export

binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
} else {
binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';

What happens if we choose csv? Are we not doing UTF-8 ?
Later we do:

print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #58 from Marcel de Rooy  ---
+return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
'csv');

Parentheses here would be more helpful inside. The outer ones are not needed.
But in order to read easier, you could do A || ( B && C )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #57 from Marcel de Rooy  ---
+my $marc_flavour = C4::Context->preference('marcflavour');
+my $biblio_metadata = $resultset->find({
+'biblionumber' => $biblionumber,
+'format' => 'marcxml',
+'marcflavour' => $marc_flavour
+});
+my $marc_xml = $biblio_metadata->metadata;
+$marc_xml = StripNonXmlChars($marc_xml);
+
+my $record = eval {
+MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
+};
+if (!$record) {

You test $record, but you should have tested $biblio_metadata too ?
Otherwise you already crash on ->metadata..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #56 from Katrin Fischer  ---
(In reply to Cab Vinton from comment #55)
> Will this enhancement be available from the staff interface? i.e., Tools >
> Export data (.../cgi-bin/koha/tools/export.pl)

From looking at the patch set this will only appear in the command line script.
But as this has been waiting a while now, I suggest we file a separate report
for making this available on GUI side. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #55 from Cab Vinton  ---
Will this enhancement be available from the staff interface? i.e., Tools >
Export data (.../cgi-bin/koha/tools/export.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #125216|0   |1
is obsolete||

--- Comment #54 from Frank Hansen  ---
Created attachment 128900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128900=edit
Bug 20551: Fix tests

Signed-off-by: Frank Hansen 

Works fine for me.
Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #125215|0   |1
is obsolete||

--- Comment #53 from Frank Hansen  ---
Created attachment 128899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128899=edit
Bug 20551: Add missing subroutine import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #125214|0   |1
is obsolete||

--- Comment #52 from Frank Hansen  ---
Created attachment 128898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128898=edit
Bug 20551: Improve documentation and make compatible with more options

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #125213|0   |1
is obsolete||

--- Comment #51 from Frank Hansen  ---
Created attachment 128897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128897=edit
Bug 20551: Rename "marcflavour" field to "schema"

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #125212|0   |1
is obsolete||

--- Comment #50 from Frank Hansen  ---
Created attachment 128896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128896=edit
Bug 20551: Fix option name in pod

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #125211|0   |1
is obsolete||

--- Comment #49 from Frank Hansen  ---
Created attachment 128895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128895=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #48 from David Gustafsson  ---
Rebase against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #123102|0   |1
is obsolete||

--- Comment #47 from David Gustafsson  ---
Created attachment 125216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125216=edit
Bug 20551: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #123101|0   |1
is obsolete||

--- Comment #46 from David Gustafsson  ---
Created attachment 125215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125215=edit
Bug 20551: Add missing subroutine import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #116411|0   |1
is obsolete||

--- Comment #45 from David Gustafsson  ---
Created attachment 125214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125214=edit
Bug 20551: Improve documentation and make compatible with more options

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #116410|0   |1
is obsolete||

--- Comment #44 from David Gustafsson  ---
Created attachment 125213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125213=edit
Bug 20551: Rename "marcflavour" field to "schema"

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #116409|0   |1
is obsolete||

--- Comment #43 from David Gustafsson  ---
Created attachment 125212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125212=edit
Bug 20551: Fix option name in pod

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #116408|0   |1
is obsolete||

--- Comment #42 from David Gustafsson  ---
Created attachment 125211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125211=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #41 from David Gustafsson  ---
(In reply to Katrin Fischer from comment #36)
> > 
> > 5). There actually is a "deleteditems" table so I guess it would be possible
> > to include these, even though it's hard to imagine why you would want to do
> > this. Since the default is to include items perhaps it would be best to
> > leave this as is and never include items for deleted biblios, or you will
> > get more data than you probably want by default. It would also increase code
> > complexity, probably with little benefit. If someone requests this it can be
> > fixed later perhaps. Will point it out in the documentation that items are
> > not included.
> 
> I think introducing the export of deleted records and deleted items
> separately would be a good idea. Let's start with this well defined feature
> and think about the deleted items some more.
> 
> While records have a flag to say "deleted", we don't have the same for
> items. So we could start exporting deleted items that belonged to deleted
> records, but what about other deleted items on existing records? How to
> "mark" them as deleted?

Now the tests are fixed. Regarding export of deleted items from a first glance
I can see how you would expect this just as matter of symmetry with the regular
export, but both conceptually and for lots of other reasons it makes no sense
at all.

1. Exporting deleted records is probably never done to save the record
information somewhere else, but to use data in records to match a record
somewhere else to remove. I cannot imagine a case where this data would be
found on an item-level.

2. It would require us to refactor C4::Biblio::EmbedItemsInMarcBiblio just for
this specific case (which is an edge case that in practice will probably never
be utilized), further increasing the burden of code maintenance and risk of
introducing new bugs.

If I'm incorrect and this feature is requested by many users it's always
possible to implement later, but I would be very surprised if this turns out to
be the case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #40 from David Gustafsson  ---
Created attachment 123102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123102=edit
Bug 20551: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Attachment #123099|0   |1
is obsolete||

--- Comment #39 from David Gustafsson  ---
Created attachment 123101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123101=edit
Bug 20551: Add missing subroutine import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #38 from David Gustafsson  ---
Created attachment 123099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123099=edit
Bug 20551: fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Katrin Fischer  ---
I am sorry, but tests are failing :(

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Exporter/Record.t
t/db_dependent/Exporter/Record.t .. 1/6 Use of uninitialized value in
concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 397,
<$fh> chunk 7.

#   Failed test 'Deleted record has the correct leader value'
#   at t/db_dependent/Exporter/Record.t line 179.
#  got: '00134dam a22000617a 4500'
# expected: '00136dam a22000617a 4500'
# Looks like you failed 1 test of 4.

#   Failed test 'export xml'
#   at t/db_dependent/Exporter/Record.t line 180.

#   Failed test 'Deleted record has the correct leader value'
#   at t/db_dependent/Exporter/Record.t line 211.
#  got: '00134dam a22000617a 4500'
# expected: '00136dam a22000617a 4500'
# Looks like you failed 1 test of 4.

#   Failed test 'export iso2709'
#   at t/db_dependent/Exporter/Record.t line 212.
# Looks like you failed 2 tests of 6.
t/db_dependent/Exporter/Record.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #36 from Katrin Fischer  ---

> 
> 5). There actually is a "deleteditems" table so I guess it would be possible
> to include these, even though it's hard to imagine why you would want to do
> this. Since the default is to include items perhaps it would be best to
> leave this as is and never include items for deleted biblios, or you will
> get more data than you probably want by default. It would also increase code
> complexity, probably with little benefit. If someone requests this it can be
> fixed later perhaps. Will point it out in the documentation that items are
> not included.

I think introducing the export of deleted records and deleted items separately
would be a good idea. Let's start with this well defined feature and think
about the deleted items some more.

While records have a flag to say "deleted", we don't have the same for items.
So we could start exporting deleted items that belonged to deleted records, but
what about other deleted items on existing records? How to "mark" them as
deleted?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Attachment #105403|0   |1
is obsolete||

--- Comment #35 from Frank Hansen  ---
Created attachment 116411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116411=edit
Bug 20551: Improve documentation and make compatible with more options

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

  Attachment #93621|0   |1
is obsolete||

--- Comment #34 from Frank Hansen  ---
Created attachment 116410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116410=edit
Bug 20551: Rename "marcflavour" field to "schema"

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

  Attachment #93620|0   |1
is obsolete||

--- Comment #33 from Frank Hansen  ---
Created attachment 116409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116409=edit
Bug 20551: Fix option name in pod

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

  Attachment #93619|0   |1
is obsolete||

--- Comment #32 from Frank Hansen  ---
Created attachment 116408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116408=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

Great job!

Signed-off-by: Frank Hansen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #31 from David Gustafsson  ---
Created attachment 105403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105403=edit
Bug 20551: Improve documentation and make compatible with more options

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #30 from David Gustafsson  ---
(In reply to Jonathan Druart from comment #26)
> 1. Doesn't it make sense to have this for authority records as well?
> 
> 2. Why is --date mandatory?
> 
> 3. POD does not tell that --deleted_only and --include_deleted is only
> available for bibs
> 
> 4. --id_list_file does not work with --deleted_only
> 
> 5. Items are not exported, I guess that's expected but maybe we should have
> it noted somewhere?

2) I think I just assumed it was required since included in the SQL-query, also
before the patch. Did not realize that 
"SELECT * FROM biblio_metadata WHERE timestamp > ''" is equivalent with "SELECT
* FROM biblio_metadata" if every timestamp entry has a value. So with that in
mind an empty timestamp is ok, though the code is a real eyesore :)

3) I think it's already pretty clear since will produce an error message is
--included_deleted or --deleted_only is used in conjunction with record_type
other than 'bibs'. But I clarified this in the usage documentation for said
options. 

4) Did not work since have to add special case for @deleted_record_ids, fixed
this.

5). There actually is a "deleteditems" table so I guess it would be possible to
include these, even though it's hard to imagine why you would want to do this.
Since the default is to include items perhaps it would be best to leave this as
is and never include items for deleted biblios, or you will get more data than
you probably want by default. It would also increase code complexity, probably
with little benefit. If someone requests this it can be fixed later perhaps.
Will point it out in the documentation that items are not included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #29 from Katrin Fischer  ---
Hi Frank, you are right, we do not keep the deleted authorities, so that takes
care of 1. I think some of the other questions could still be
answered/improved:


(In reply to Jonathan Druart from comment #26)
> 1. Doesn't it make sense to have this for authority records as well?

Because we don't keep them ;)

> 2. Why is --date mandatory?

Not sure about this one, can you explain?

> 3. POD does not tell that --deleted_only and --include_deleted is only
> available for bibs

Easy fix to documentation I think and it could help people who are not aware of
database structure.

> 4. --id_list_file does not work with --deleted_only

Cannot tell about this one, but sounds worth looking into.

> 5. Items are not exported, I guess that's expected but maybe we should have
> it noted somewhere?

Maybe also a note in the docs?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #28 from Frank Hansen  ---
(In reply to Jonathan Druart from comment #26)
> 1. Doesn't it make sense to have this for authority records as well?

The authority records are stored in auth_header table. But deleted records is
not kept anywhere else. As I can see, this would require to keep deleted
authority records in an another table like deletedauth_header.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Jonathan Druart  changed:

   What|Removed |Added

 CC||th...@lib.auth.gr

--- Comment #27 from Jonathan Druart  
---
*** Bug 17693 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #26 from Jonathan Druart  
---
1. Doesn't it make sense to have this for authority records as well?

2. Why is --date mandatory?

3. POD does not tell that --deleted_only and --include_deleted is only
available for bibs

4. --id_list_file does not work with --deleted_only

5. Items are not exported, I guess that's expected but maybe we should have it
noted somewhere?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #25 from Frank Hansen  ---
The test failed because I ran the test on an empty database.
I will now sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #24 from Frank Hansen  ---
(In reply to David Gustafsson from comment #23)
> Should now be rebased against master.

The patch itself applies and works fine for me. However, the test doesn't pass:

t/db_dependent/Exporter/Record.t .. 1/6
#   Failed test 'Deleted record has the correct leader value'
#   at t/db_dependent/Exporter/Record.t line 186.
#  got: '00134dam a22000617a 4500'
# expected: '00136dam a22000617a 4500'
# Looks like you failed 1 test of 4.

#   Failed test 'export xml'
#   at t/db_dependent/Exporter/Record.t line 187.

#   Failed test 'Deleted record has the correct leader value'
#   at t/db_dependent/Exporter/Record.t line 218.
#  got: '00134dam a22000617a 4500'
# expected: '00136dam a22000617a 4500'
# Looks like you failed 1 test of 4.

#   Failed test 'export iso2709'
#   at t/db_dependent/Exporter/Record.t line 219.
t/db_dependent/Exporter/Record.t .. 5/6 # Looks like you failed 2 tests of 6.
t/db_dependent/Exporter/Record.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

Test Summary Report
---
t/db_dependent/Exporter/Record.t (Wstat: 512 Tests: 6 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 2
Files=1, Tests=6,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.94 cusr  0.28
csys =  3.24 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #23 from David Gustafsson  ---
Should now be rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #90220|0   |1
is obsolete||

--- Comment #22 from David Gustafsson  ---
Created attachment 93621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93621=edit
Bug 20551: Rename "marcflavour" field to "schema"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #90184|0   |1
is obsolete||

--- Comment #20 from David Gustafsson  ---
Created attachment 93619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93619=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #90190|0   |1
is obsolete||

--- Comment #21 from David Gustafsson  ---
Created attachment 93620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93620=edit
Bug 20551: Fix option name in pod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Eric Bégin  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||eric.be...@inlibro.com

--- Comment #19 from Eric Bégin  ---
Test during hackfest 2019

error: sha1 information is lacking or useless (Koha/Exporter/Record.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 20551: Rename "marcflavour" field to "schema"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #18 from David Gustafsson  ---
Created attachment 90220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90220=edit
Bug 20551: Rename "marcflavour" field to "schema"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #17 from David Gustafsson  ---
Created attachment 90190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90190=edit
Bug 20551: Fix option name in pod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Blocks||23009


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23009
[Bug 23009] Add -deleted_marc_conditions argument to export_records script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #16 from David Gustafsson  ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #82918|0   |1
is obsolete||

--- Comment #15 from David Gustafsson  ---
Created attachment 90184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90184=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
Same for me, marking "Patch doesn't apply". Frnak, you can set that status too
if you run into this the next time!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #13 from Frank Hansen  ---
Patch didn't apply for me. I got:

CONFLICT (content): Merge conflict in misc/export_records.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 20551: Add option for including deleted records in
export_records.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #82914|0   |1
is obsolete||

--- Comment #12 from David Gustafsson  ---
Created attachment 82918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82918=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #11 from David Gustafsson  ---
Forgot to fix the perl critic issue, will do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #10 from David Gustafsson  ---
Found the culprit (next in map that accidentally got there in rebase, where
should just return empty list), now tests should pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #82843|0   |1
is obsolete||

--- Comment #9 from David Gustafsson  ---
Created attachment 82914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82914=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Owen Leonard  ---
The functionality of this works as described in the test plan. However, the QA
tools raise this warning:

 FAIL   Koha/Exporter/Record.pm
   FAIL   critic
# Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s).

And t/db_dependent/Exporter/Record.t returns this error:

t/db_dependent/Exporter/Record.t .. 1/6 # No tests run!

#   Failed test 'No tests run for subtest "export xml"'
#   at t/db_dependent/Exporter/Record.t line 187.
# No tests run!

#   Failed test 'No tests run for subtest "export iso2709"'
#   at t/db_dependent/Exporter/Record.t line 219.
# Looks like you failed 2 tests of 6.
t/db_dependent/Exporter/Record.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/6 subtests

Test Summary Report
---
t/db_dependent/Exporter/Record.t (Wstat: 512 Tests: 6 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 2
Files=1, Tests=6,  3 wallclock secs ( 0.02 usr  0.01 sys +  1.41 cusr  0.69
csys =  2.13 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #7 from David Gustafsson  ---
Rebase against master (untested, will test later and verify that still works).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75113|0   |1
is obsolete||

--- Comment #6 from David Gustafsson  ---
Created attachment 82843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82843=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #5 from David Gustafsson  ---
Rebased against Koha master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #73923|0   |1
is obsolete||

--- Comment #4 from David Gustafsson  ---
Created attachment 75113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75113=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #3 from David Gustafsson  ---
As some might need it, also added an '--deleted_only' option, to export only
the deleted biblios.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

  Attachment #73916|0   |1
is obsolete||

--- Comment #2 from David Gustafsson  ---
Created attachment 73923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73923=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=
  --deleted_only --format=xml`
and verify that only the deleted biblio was included
in the export.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #1 from David Gustafsson  ---
Created attachment 73916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73916=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d".

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=
  --include_deleted --format=xml`

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/