[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED --- Comment #13 from Fridolin SOMERS --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Bug 20773 depends on bug 20724, which changed state. Bug 20724 Summary: ReservesNeedReturns syspref breaks "Holds awaiting pickup" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Chris Cormack changed: What|Removed |Added Attachment #77780|0 |1 is obsolete|| --- Comment #9 from Chris Cormack --- Created attachment 78038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78038&action=edit Bug 20773: (followup) Remove MySQLism Signed-off-by: Victor Grousset Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Chris Cormack changed: What|Removed |Added Attachment #9|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 78036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78036&action=edit Bug 20773: (bug 20724 follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. == Test plan == 1. git checkout c585f1149770ec401f188e061211501897cec0bf~1 This the commit before bug 20724's patches. We need that to be able to generate "corrupted data" 2. Set ReservesNeedReturns to "Automatically" 3. Place a hold on a specific item 4. The hold should have an *empty* expiration date record page → Hold → "Expiration" column 5. Apply this patch 6. Run updatedatabase.pl 7. Refresh the page 8. The hold should have an expiration date (not empty) 9. Celebrate! 🎉🎊🥳 Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Assignee is missing - Marcel or Martin? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #76939|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 77780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77780&action=edit Bug 20773: (followup) Remove MySQLism Signed-off-by: Victor Grousset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #8|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 9 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9&action=edit Bug 20773: (bug 20724 follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. == Test plan == 1. git checkout c585f1149770ec401f188e061211501897cec0bf~1 This the commit before bug 20724's patches. We need that to be able to generate "corrupted data" 2. Set ReservesNeedReturns to "Automatically" 3. Place a hold on a specific item 4. The hold should have an *empty* expiration date record page → Hold → "Expiration" column 5. Apply this patch 6. Run updatedatabase.pl 7. Refresh the page 8. The hold should have an expiration date (not empty) 9. Celebrate! 🎉🎊🥳 Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #75368|0 |1 is obsolete|| --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 8 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8&action=edit Bug 20773: (bug 20724 follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. Signed-off-by: Marcel de Rooy Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Jonathan Druart changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 --- Comment #3 from Martin Renvoize --- Created attachment 76939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76939&action=edit Bug 20773: (followup) Remove MySQLism -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion --- Comment #2 from Jonathan Druart --- This change contains MySQLism (FQA) And maybe it would be better to display a warning and provide a script to fix the data (In Discussion). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 --- Comment #1 from Jonathan Druart --- Created attachment 75368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75368&action=edit Bug 20773: (bug 20724 follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
