[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Nick Clemens changed: What|Removed |Added Blocks||31492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 [Bug 31492] Patron image upload fails on first attempt with CSRF failure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com --- Comment #39 from Martin Renvoize --- Nice enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #38 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #84477|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 84481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84481&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #84480|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 84484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84484&action=edit Bug 20809: (QA follow-up) Fix missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #84478|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 84482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84482&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #84479|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 84483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84483&action=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #31 from Owen Leonard --- Created attachment 84478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84478&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #33 from Owen Leonard --- Created attachment 84480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84480&action=edit Bug 20809: (QA follow-up) Fix missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #32 from Owen Leonard --- Created attachment 84479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84479&action=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Attachment #83844|0 |1 is obsolete|| Attachment #83845|0 |1 is obsolete|| Attachment #83846|0 |1 is obsolete|| Attachment #83847|0 |1 is obsolete|| --- Comment #30 from Owen Leonard --- Created attachment 84477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84477&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #83712|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #83713|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #83711|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #29 from Katrin Fischer --- Added the missing filters in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #26 from Katrin Fischer --- Created attachment 83845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83845&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #28 from Katrin Fischer --- Created attachment 83847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83847&action=edit Bug 20809: (QA follow-up) Fix missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #27 from Katrin Fischer --- Created attachment 83846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83846&action=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #25 from Katrin Fischer --- Created attachment 83844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83844&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #24 from Katrin Fischer --- There are some complaints from the QA tool: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc FAIL filters missing_filter at line 148 () FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL filters missing_filter at line 272 ( To update the image for [% patron.title %] [% patron.firstname | html %] [% patron.surname | html %], select a new image file and click 'Upload.' Click the 'Delete' button to remove the current image.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #22 from Claire Gravely --- Created attachment 83712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83712&action=edit [SIGNED-OFF] Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Claire Gravely changed: What|Removed |Added Attachment #82333|0 |1 is obsolete|| Attachment #82334|0 |1 is obsolete|| Attachment #82335|0 |1 is obsolete|| --- Comment #21 from Claire Gravely --- Created attachment 83711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83711&action=edit [SIGNED-OFF] Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #23 from Claire Gravely --- Created attachment 83713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83713&action=edit [SIGNED-OFF] Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Attachment #78409|0 |1 is obsolete|| Attachment #78595|0 |1 is obsolete|| Attachment #78711|0 |1 is obsolete|| --- Comment #18 from Owen Leonard --- Created attachment 82333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82333&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #19 from Owen Leonard --- Created attachment 82334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82334&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #20 from Owen Leonard --- Created attachment 82335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82335&action=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #17 from Caroline Cyr La Rose --- (In reply to Owen Leonard from comment #16) > (In reply to Caroline Cyr La Rose from comment #15) > > Is it normal that if we add the image from a page other than patron details > > (e.g. purchase suggestions) it goes back to patron details and does not stay > > on the page we were on? > > It's not ideal, but it is to be expected with my patch. I didn't modify that > behavior. If folks feel that it doesn't work this way I can try to fix it. We can report another bug for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #16 from Owen Leonard --- (In reply to Caroline Cyr La Rose from comment #15) > Is it normal that if we add the image from a page other than patron details > (e.g. purchase suggestions) it goes back to patron details and does not stay > on the page we were on? It's not ideal, but it is to be expected with my patch. I didn't modify that behavior. If folks feel that it doesn't work this way I can try to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #15 from Caroline Cyr La Rose --- Is it normal that if we add the image from a page other than patron details (e.g. purchase suggestions) it goes back to patron details and does not stay on the page we were on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 lucasgass changed: What|Removed |Added Attachment #78670|0 |1 is obsolete|| --- Comment #14 from lucasgass --- Created attachment 78711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78711&action=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #13 from Owen Leonard --- Created attachment 78670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78670&action=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Cab Vinton changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Cab Vinton --- Tested in Biblibre Sandbox 14. All works as described, except pressing the Add button has no effect on the patron page showing the Modification log. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Attachment #78410|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 78595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78595&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #10 from Cab Vinton --- Tested in Biblibre Sandbox 14. Did not see a confirmation dialog when deleting a patron image from several pages. Otherwise patch works as described. Another suggestion -- Uploading a patron image when an image already exists currently has no effect. Consider changing this to offer the option of replacing the existing image. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #9 from Owen Leonard --- Created attachment 78410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78410&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Attachment #77789|0 |1 is obsolete|| Attachment #77790|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 78409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78409&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Attachment #77465|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 77789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77789&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #7 from Owen Leonard --- Created attachment 77790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77790&action=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Bug 20809 depends on bug 20779, which changed state. Bug 20779 Summary: Style refresh for patron detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Attachment #77462|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 77465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77465&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Dilan Johnpullé changed: What|Removed |Added Attachment #75963|0 |1 is obsolete|| --- Comment #4 from Dilan Johnpullé --- Created attachment 77462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77462&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #3 from Owen Leonard --- Created attachment 75963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75963&action=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #2 from Owen Leonard --- Created attachment 75637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75637&action=edit Screenshot of the modal window with 20779 as a dependency Adding Bug 20779 as a dependency makes it easier to show a more refined form in the modal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Depends on||20779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 [Bug 20779] Style refresh for patron detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #1 from Owen Leonard --- Created attachment 75515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75515&action=edit Screenshot of the modal window I'm not crazy about the duplication of the heading. Maybe it's better to have a blank (or nonexistent?) modal header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/