[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28575

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Manual merge||https://gitlab.com/koha-com
request||munity/koha-manual/-/merge_
   ||requests/417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Component|Architecture, internals,|System Administration
   |and plumbing|
 CC||caroline.cyr-la-rose@inlibr
   ||o.com, gmcha...@gmail.com

--- Comment #22 from Caroline Cyr La Rose  ---
I changed the component from "Architecture, internals and plumbing" to "System
administration" so that it appears under Administration in the release notes. I
hope this is ok. If not, feel free to change it back :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #21 from Lucas Gass  ---
enhancement will not be backported to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||25663


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663
[Bug 25663] Koha::RefundLostItemFeeRules should be merged into
Koha::CirculationRules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #20 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #19 from Kyle M Hall  ---
Created attachment 107177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107177=edit
Bug 20815: Add unit tests for changes to AddIssue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #17 from Jonathan Druart  
---
Created attachment 107165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107165=edit
Bug 20815: Tests refactoring

Some code were duplicated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #18 from Jonathan Druart  
---
Hi Kyle,
In my understanding the tests don't cover the changes in AddIssue, can you
provide some please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #106575|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 106607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106607=edit
Bug 20815: Do not use compare float with precision

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105141|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 106606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106606=edit
Bug 20815: Add ability to choose if lost fee is refunded based on length of
time item has been lost

This adds the ability to not refund lost item fees on return if the item
has been lost for more than a given number of days.

Test Plan:
1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of
days
2) Find a lost item that has been lost longer than that
NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded
3) Return the item
4) Note no refund on the lost item fee was processed, the fee remains unchanged
5) prove t/db_dependent/Circulation.t

Signed-off-by: Deb Stephenson 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #16 from Katrin Fischer  ---
Created attachment 106608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106608=edit
Bug 20815: (QA follow-up) Add message to database update / rephrase pref

- Make pref use "checked in" instead of "returned".
- Add message to database update

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #13 from Kyle M Hall  ---
Created attachment 106575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106575=edit
Bug 20815: Do not use compare float with precision

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #12 from Katrin Fischer  ---

Well, or check at least :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Katrin Fischer  ---
Please fix!

 FAIL   t/db_dependent/Circulation.t
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 3998)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4001)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4073)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4076)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4148)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4151)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4223)
forbidden pattern: Do not use compare float with precision (bug
24408). Ignore this if you know what you are doing. (line 4226)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #99038|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 105141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105141=edit
Bug 20815: Add ability to choose if lost fee is refunded based on length of
time item has been lost

This adds the ability to not refund lost item fees on return if the item
has been lost for more than a given number of days.

Test Plan:
1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of
days
2) Find a lost item that has been lost longer than that
NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded
3) Return the item
4) Note no refund on the lost item fee was processed, the fee remains unchanged
5) prove t/db_dependent/Circulation.t

Signed-off-by: Deb Stephenson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #98929|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 99038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99038=edit
Bug 20815: Add ability to choose if lost fee is refunded based on length of
time item has been lost

This adds the ability to not refund lost item fees on return if the item
has been lost for more than a given number of days.

Test Plan:
1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of
days
2) Find a lost item that has been lost longer than that
NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded
3) Return the item
4) Note no refund on the lost item fee was processed, the fee remains unchanged
5) prove t/db_dependent/Circulation.t

Signed-off-by: Deb Stephenson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #98772|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 98929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98929=edit
Bug 20815: Add ability to choose if lost fee is refunded based on length of
time item has been lost

This adds the ability to not refund lost item fees on return if the item
has been lost for more than a given number of days.

Test Plan:
1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of
days
2) Find a lost item that has been lost longer than that
NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded
3) Return the item
4) Note no refund on the lost item fee was processed, the fee remains unchanged
5) prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #6 from Kyle M Hall  ---
Created attachment 98772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98772=edit
Bug 20815: Add ability to choose if lost fee is refunded based on length of
time item has been lost

This adds the ability to not refund lost item fees on return if the item
has been lost for more than a given number of days.

Test Plan:
1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of
days
2) Find a lost item that has been lost longer than that
NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded
3) Return the item
4) Note no refund on the lost item fee was processed, the fee remains unchanged
5) prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Joy Nelson  changed:

   What|Removed |Added

   Assignee|kohadevi...@devinim.com.tr  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #5 from Joy Nelson  ---
Hi Brian,
We understand the urgency for your library.  This bug is currently assigned and
in development.  When the feature is ready, tested and passed QA it will be
pushed into a release of Koha.  

Thanks!
joy

(In reply to Brian from comment #4)
> FY18 means Fiscal year 2018
> 
> Hi this bug is attached to our development New System Pref, “Don’t forgive
> lost after(set date), modify checkin routine to check the value of the
> itemlost_on field.
> 
> My superiors want this bug pushed, thank you

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #4 from Brian  ---
FY18 means Fiscal year 2018

Hi this bug is attached to our development New System Pref, “Don’t forgive lost
after(set date), modify checkin routine to check the value of the itemlost_on
field.

My superiors want this bug pushed, thank you

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com
   Assignee|k...@bywatersolutions.com   |kohadevi...@devinim.com.tr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Brian  changed:

   What|Removed |Added

 CC||bkl...@dubuque.lib.ia.us

--- Comment #3 from Brian  ---
Any updates on bug 20815?

Carnegie team

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

--- Comment #2 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #1)
> Hi Kyle, can you explain what FY18 means?

I have no idea, maybe JesseM does ; )

I have updated the title to actually describe the requires.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815

Kyle M Hall  changed:

   What|Removed |Added

Summary|Development FY18 New System |Add ability to choose if
   |Preference  |lost fee is refunded based
   ||on length of time item has
   ||been lost

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/