[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Blocks||26583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 [Bug 26583] Unnecessary code in AddIssue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Jonathan Druart changed: What|Removed |Added Blocks||24259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Blocks||23382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 [Bug 23382] Hourly rental fees are not charged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Text to go in the|This new feature adds the |Sponsored by: release notes|ability to define a per day |Huntsville-Madison County |(or per hour) rental fee|Public Library |for rental items. The new |(http://hmcpl.org/) |fee may be used as an | |alternative to the fixed|This |price rental fee or in |new feature adds the |conjunction with it.|ability to define a per day ||(or per hour) rental fee ||for rental items. The new ||fee may be used as an ||alternative to the fixed ||price rental fee or in ||conjunction with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Text to go in the||This new feature adds the release notes||ability to define a per day ||(or per hour) rental fee ||for rental items. The new ||fee may be used as an ||alternative to the fixed ||price rental fee or in ||conjunction with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00 released in|| Resolution|--- |FIXED Status|Pushed to Master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #234 from Nick Clemens --- (In reply to Dobrica Pavlinusic from comment #232) > Created attachment 87703 [details] [review] > Bug 20912: (QA follow-up) Fix for missed signature failure Awesome work all! follow-up pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #233 from Dobrica Pavlinusic --- Thanks for patch, I signed-off on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Dobrica Pavlinusic changed: What|Removed |Added Attachment #87413|0 |1 is obsolete|| --- Comment #232 from Dobrica Pavlinusic --- Created attachment 87703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87703=edit Bug 20912: (QA follow-up) Fix for missed signature failure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Kyle M Hall changed: What|Removed |Added Attachment #87363|0 |1 is obsolete|| --- Comment #231 from Kyle M Hall --- Created attachment 87413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87413=edit Bug 20912: (QA follow-up) Fix for missed signature failure We missed a change in calling parameters passed to CalcDateDue in AddRenewal during the initial QAing. This patch corrects the call and adds a test to catch regressions. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #230 from Martin Renvoize --- Created attachment 87363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87363=edit Bug 20912: (QA follow-up) Fix for missed signature failure We missed a change in calling parameters passed to CalcDateDue in AddRenewal during the initial QAing. This patch corrects the call and adds a test to catch regressions. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #229 from Martin Renvoize --- Dobrica, long time no see.. nice to have you back. Very annoying this wasn't caught by a test.. I'll open it in a new bug as I think it'll only add to the confusion adding followups here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Dobrica Pavlinusic changed: What|Removed |Added CC||dpav...@rot13.org Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #228 from Dobrica Pavlinusic --- I'm afraid that this patch broke AddRenewal which now calculates wrong duedate because of: -$datedue = CalcDateDue($datedue, $itemtype, _GetCircControlBranch($item_unblessed, $patron_unblessed), $patron_unblessed, 'is a renewal'); +$datedue = CalcDateDue($datedue, $itemtype, $circ_library, $patron_unblessed, 'is a renewal'); This will pass $circ_library object instead of branch name so $duedate will be calculated wrongly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #227 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Bug 20912 depends on bug 21721, which changed state. Bug 21721 Summary: Update C4::Circulation::AddRenewal to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #226 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86301|0 |1 is obsolete|| --- Comment #223 from Martin Renvoize --- Created attachment 86325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86325=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #225 from Martin Renvoize --- Created attachment 86327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86327=edit Bug 20912: (QA follow-up) Add on_editing to $Price filter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86302|0 |1 is obsolete|| --- Comment #224 from Martin Renvoize --- Created attachment 86326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86326=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86300|0 |1 is obsolete|| --- Comment #222 from Martin Renvoize --- Created attachment 86324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86324=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86299|0 |1 is obsolete|| --- Comment #221 from Martin Renvoize --- Created attachment 86323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86323=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86298|0 |1 is obsolete|| --- Comment #220 from Martin Renvoize --- Created attachment 86322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86322=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86297|0 |1 is obsolete|| --- Comment #219 from Martin Renvoize --- Created attachment 86321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86321=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86293|0 |1 is obsolete|| --- Comment #215 from Martin Renvoize --- Created attachment 86317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86317=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86295|0 |1 is obsolete|| --- Comment #217 from Martin Renvoize --- Created attachment 86319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86319=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86294|0 |1 is obsolete|| --- Comment #216 from Martin Renvoize --- Created attachment 86318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86318=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86296|0 |1 is obsolete|| --- Comment #218 from Martin Renvoize --- Created attachment 86320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86320=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86291|0 |1 is obsolete|| --- Comment #213 from Martin Renvoize --- Created attachment 86315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86315=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86292|0 |1 is obsolete|| --- Comment #214 from Martin Renvoize --- Created attachment 86316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86316=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86290|0 |1 is obsolete|| --- Comment #212 from Martin Renvoize --- Created attachment 86314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86314=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86289|0 |1 is obsolete|| --- Comment #211 from Martin Renvoize --- Created attachment 86313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86313=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86282|0 |1 is obsolete|| --- Comment #204 from Martin Renvoize --- Created attachment 86306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86306=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86283|0 |1 is obsolete|| --- Comment #205 from Martin Renvoize --- Created attachment 86307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86307=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86288|0 |1 is obsolete|| --- Comment #210 from Martin Renvoize --- Created attachment 86312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86312=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86285|0 |1 is obsolete|| --- Comment #207 from Martin Renvoize --- Created attachment 86309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86309=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86287|0 |1 is obsolete|| --- Comment #209 from Martin Renvoize --- Created attachment 86311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86311=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86286|0 |1 is obsolete|| --- Comment #208 from Martin Renvoize --- Created attachment 86310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86310=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86284|0 |1 is obsolete|| --- Comment #206 from Martin Renvoize --- Created attachment 86308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86308=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86264|0 |1 is obsolete|| --- Comment #203 from Martin Renvoize --- Created attachment 86302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86302=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86263|0 |1 is obsolete|| --- Comment #202 from Martin Renvoize --- Created attachment 86301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86301=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86262|0 |1 is obsolete|| --- Comment #201 from Martin Renvoize --- Created attachment 86300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86300=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86261|0 |1 is obsolete|| --- Comment #200 from Martin Renvoize --- Created attachment 86299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86299=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86250|0 |1 is obsolete|| --- Comment #189 from Martin Renvoize --- Created attachment 86288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86288=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86244|0 |1 is obsolete|| --- Comment #183 from Martin Renvoize --- Created attachment 86282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86282=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86260|0 |1 is obsolete|| --- Comment #199 from Martin Renvoize --- Created attachment 86298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86298=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86256|0 |1 is obsolete|| --- Comment #195 from Martin Renvoize --- Created attachment 86294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86294=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86253|0 |1 is obsolete|| --- Comment #192 from Martin Renvoize --- Created attachment 86291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86291=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86259|0 |1 is obsolete|| --- Comment #198 from Martin Renvoize --- Created attachment 86297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86297=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86257|0 |1 is obsolete|| --- Comment #196 from Martin Renvoize --- Created attachment 86295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86295=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86251|0 |1 is obsolete|| --- Comment #190 from Martin Renvoize --- Created attachment 86289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86289=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86255|0 |1 is obsolete|| --- Comment #194 from Martin Renvoize --- Created attachment 86293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86293=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86252|0 |1 is obsolete|| --- Comment #191 from Martin Renvoize --- Created attachment 86290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86290=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86258|0 |1 is obsolete|| --- Comment #197 from Martin Renvoize --- Created attachment 86296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86296=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86254|0 |1 is obsolete|| --- Comment #193 from Martin Renvoize --- Created attachment 86292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86292=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86247|0 |1 is obsolete|| --- Comment #186 from Martin Renvoize --- Created attachment 86285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86285=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86249|0 |1 is obsolete|| --- Comment #188 from Martin Renvoize --- Created attachment 86287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86287=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86246|0 |1 is obsolete|| --- Comment #185 from Martin Renvoize --- Created attachment 86284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86284=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86248|0 |1 is obsolete|| --- Comment #187 from Martin Renvoize --- Created attachment 86286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86286=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86245|0 |1 is obsolete|| --- Comment #184 from Martin Renvoize --- Created attachment 86283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86283=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #182 from Martin Renvoize --- Fresh rebase, should all be working again now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86157|0 |1 is obsolete|| --- Comment #177 from Martin Renvoize --- Created attachment 86260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86260=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #181 from Martin Renvoize --- Created attachment 86264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86264=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86160|0 |1 is obsolete|| --- Comment #180 from Martin Renvoize --- Created attachment 86263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86263=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86156|0 |1 is obsolete|| --- Comment #176 from Martin Renvoize --- Created attachment 86259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86259=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86158|0 |1 is obsolete|| --- Comment #178 from Martin Renvoize --- Created attachment 86261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86261=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86159|0 |1 is obsolete|| --- Comment #179 from Martin Renvoize --- Created attachment 86262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86262=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86152|0 |1 is obsolete|| --- Comment #172 from Martin Renvoize --- Created attachment 86255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86255=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86155|0 |1 is obsolete|| --- Comment #175 from Martin Renvoize --- Created attachment 86258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86258=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86153|0 |1 is obsolete|| --- Comment #173 from Martin Renvoize --- Created attachment 86256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86256=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86154|0 |1 is obsolete|| --- Comment #174 from Martin Renvoize --- Created attachment 86257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86257=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86151|0 |1 is obsolete|| --- Comment #171 from Martin Renvoize --- Created attachment 86254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86254=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86149|0 |1 is obsolete|| --- Comment #170 from Martin Renvoize --- Created attachment 86253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86253=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86148|0 |1 is obsolete|| --- Comment #169 from Martin Renvoize --- Created attachment 86252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86252=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86146|0 |1 is obsolete|| --- Comment #167 from Martin Renvoize --- Created attachment 86250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86250=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86147|0 |1 is obsolete|| --- Comment #168 from Martin Renvoize --- Created attachment 86251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86251=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86145|0 |1 is obsolete|| --- Comment #166 from Martin Renvoize --- Created attachment 86249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86249=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86140|0 |1 is obsolete|| --- Comment #161 from Martin Renvoize --- Created attachment 86244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86244=edit Bug 20912: Update database Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86144|0 |1 is obsolete|| --- Comment #165 from Martin Renvoize --- Created attachment 86248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86248=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86143|0 |1 is obsolete|| --- Comment #164 from Martin Renvoize --- Created attachment 86247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86247=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86141|0 |1 is obsolete|| --- Comment #162 from Martin Renvoize --- Created attachment 86245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86245=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #86142|0 |1 is obsolete|| --- Comment #163 from Martin Renvoize --- Created attachment 86246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86246=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85550|0 |1 is obsolete|| --- Comment #148 from Martin Renvoize --- Created attachment 86147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86147=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85554|0 |1 is obsolete|| --- Comment #152 from Martin Renvoize --- Created attachment 86152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86152=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85557|0 |1 is obsolete|| --- Comment #155 from Martin Renvoize --- Created attachment 86155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86155=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85560|0 |1 is obsolete|| --- Comment #158 from Martin Renvoize --- Created attachment 86158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86158=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85551|0 |1 is obsolete|| --- Comment #149 from Martin Renvoize --- Created attachment 86148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86148=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85631|0 |1 is obsolete|| --- Comment #160 from Martin Renvoize --- Created attachment 86160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86160=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85561|0 |1 is obsolete|| --- Comment #159 from Martin Renvoize --- Created attachment 86159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86159=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85559|0 |1 is obsolete|| --- Comment #157 from Martin Renvoize --- Created attachment 86157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86157=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85553|0 |1 is obsolete|| --- Comment #151 from Martin Renvoize --- Created attachment 86151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86151=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #8|0 |1 is obsolete|| --- Comment #153 from Martin Renvoize --- Created attachment 86153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86153=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85558|0 |1 is obsolete|| --- Comment #156 from Martin Renvoize --- Created attachment 86156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86156=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Attachment #85552|0 |1 is obsolete|| --- Comment #150 from Martin Renvoize --- Created attachment 86149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86149=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/