[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Nick Clemens changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #11 from Nick Clemens --- *** Bug 3311 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m Status|Pushed to Stable|RESOLVED --- Comment #10 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Jonathan Druart changed: What|Removed |Added Attachment #80686|0 |1 is obsolete|| Attachment #80687|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 80740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80740&action=edit Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 --- Comment #7 from Jonathan Druart --- Created attachment 80741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80741&action=edit Bug 21005: Address QA tool failures on tabs Only whitespace changes. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 M. Tompsett changed: What|Removed |Added Attachment #77644|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 80686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80686&action=edit Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 --- Comment #5 from M. Tompsett --- Created attachment 80687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80687&action=edit Bug 21005: Address QA tool failures on tabs Only whitespace changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Dilan Johnpullé changed: What|Removed |Added CC||di...@calyx.net.au Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Dilan Johnpullé --- Error results when applying patch: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 21005 Bug 21005 - Missing row/column defaults cause unexpected results in report wizards 77644 - Bug 21005: Missing row/column defaults cause unexpected results in report wizards Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21005: Missing row/column defaults cause unexpected results in report wizards Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt Failed to merge in the changes. Patch failed at 0001 Bug 21005: Missing row/column defaults cause unexpected results in report wizards The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21005-Missing-rowcolumn-defaults-cause-unexpec-XprggD.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 --- Comment #2 from David Cook --- Created attachment 77644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77644&action=edit Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 David Cook changed: What|Removed |Added Summary|Report wizards fatal errors |Missing row/column defaults |if no radio buttons |cause unexpected results in |selected|report wizards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
