[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22703 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED --- Comment #20 from Fridolin SOMERS --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #18 from Martin Renvoize --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize --- Works well for me and I can't see any regressions.. passes the qa scripts too. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize changed: What|Removed |Added Attachment #77414|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 77520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77520=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Martin Renvoize changed: What|Removed |Added Attachment #77413|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 77519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77519=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #13 from Katrin Fischer --- With both patches it works for me as well. I have the 404 for before applying the patch and correct redirects after. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Attachment #76863|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 77414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77414=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Attachment #76601|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 77413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77413=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #10 from Katrin Fischer --- *** Bug 21088 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Mathieu Pelletier changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Mathieu Pelletier --- This does work for me using the second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard --- This isn't working for me. I'm still getting a 404 error after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21088 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #7 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Important note: We certainly need to add an index on this column to boost
> > this query.
>
> Do you mean items.uri and deleteditems.uri?
only items.uri, but with the last patch it's not needed.
(In reply to Marcel de Rooy from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Important note: We certainly need to add an index on this column to boost
> > this query.
>
> Koha::Items->search( { uri => $uri } )->count
>
> You need to add biblionumber to limit the results. No need to scan the whole
> table.
Oops, yes you are right. It's itemnumber actually.
Maybe we should add more tests here, items.uri check should only be if
itemnumber is passed. But I would prefer to not complexity it now as it's
improvement and not bug fixing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #6 from Jonathan Druart --- Created attachment 76863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76863=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||m.de.r...@rijksmuseum.nl
--- Comment #5 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #3)
> Important note: We certainly need to add an index on this column to boost
> this query.
Koha::Items->search( { uri => $uri } )->count
You need to add biblionumber to limit the results. No need to scan the whole
table.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > Important note: We certainly need to add an index on this column to boost > this query. Do you mean items.uri and deleteditems.uri? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #3 from Jonathan Druart --- Important note: We certainly need to add an index on this column to boost this query. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Attachment #76569|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76601=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #1 from Jonathan Druart --- Created attachment 76569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76569=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||19847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19847 [Bug 19847] tracklinks.pl accepts any url from a parameter for proxying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
