[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2019-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Jonathan Druart  changed:

   What|Removed |Added

 CC||aniltiwar...@hotmail.com

--- Comment #26 from Jonathan Druart  
---
*** Bug 20493 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from Fridolin SOMERS  ---
Depends on Bug 19935 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #24 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #23 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #22 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #19)
> Upgrading severity as it impacts the last stable version.

Yes, this is definitely needed in 18.05.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Josef Moravec  changed:

   What|Removed |Added

  Attachment #81001|0   |1
is obsolete||
  Attachment #81002|0   |1
is obsolete||

--- Comment #20 from Josef Moravec  ---
Created attachment 81050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81050=edit
Bug 21486: Fix 'AU' for SIP

Signed-off-by: Colin Campbell 
Signed-off-by: Alex Buckley 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #21 from Josef Moravec  ---
Created attachment 81051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81051=edit
Bug 21486: Only fetch the items' barcodes

and avoid unecessary processing

Signed-off-by: Colin Campbell 

Tested and found correct AU data is returned, and passes QA test tool

Signed-off-by: Alex Buckley 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |critical

--- Comment #19 from Jonathan Druart  
---
Upgrading severity as it impacts the last stable version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #18 from Colin Campbell  ---
Bonus - fixes a failure to process renew requests I've just spotted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #17 from Alex Buckley  ---
Created attachment 81002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81002=edit
Bug 21486: Only fetch the items' barcodes

and avoid unecessary processing

Signed-off-by: Colin Campbell 

Tested and found correct AU data is returned, and passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #16 from Alex Buckley  ---
Created attachment 81001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81001=edit
Bug 21486: Fix 'AU' for SIP

Signed-off-by: Colin Campbell 
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80976|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #15 from Alex Buckley  ---
(In response to Colin Campbell in comment 14):

Yes I can confirm Jonathan's patches do what I had envisaged and can replace my
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80729|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

  Attachment #80251|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #14 from Colin Campbell  ---
I've signed off Jonathan's two patches they restore the previous behaviour.
Alex can you confirm this does all you envisioned and can go with it in place
of your original patch?

We should endeavour to get this into 18.11 or their is potential for working
setups to be broken

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Colin Campbell  changed:

   What|Removed |Added

  Attachment #80730|0   |1
is obsolete||

--- Comment #13 from Colin Campbell  ---
Created attachment 80976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80976=edit
patch restricting to barcodes

Tested patch and works as advertised - signed off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #12 from Jonathan Druart  
---
Created attachment 80730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80730=edit
Bug 21486: Only fetch the items' barcodes

and avoid unecessary processing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #80655|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 80729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80729=edit
Bug 21486: Fix 'AU' for SIP

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #10 from Colin Campbell  ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Colin Campbell from comment #8)
> > (In reply to Jonathan Druart from comment #7)
> > > (In reply to Jonathan Druart from comment #5)
> > > > The problem here is that I have no idea which info is needed
> > > > in $ilspatron{items}.
> > > 
> > > Colin, do you know the answer?
> > 
> > Yes (infact we collided) items is an array of barcodes of items issued to
> > this patron
> 
> So we only need the barcodes, for other (if exist) calls as well?
> If so I can provide a better patch.

Yes the logic in the client machines is to get a list of relevant barcodes for
the queries and it can then issue item information queries of those.
The exception (theres always one) is fine items as item_id does not give you
relevant info (thats not specific to Koha, it a fairly useless option in most
LMSs) Koha has some specific code there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #9 from Jonathan Druart  
---
(In reply to Colin Campbell from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > (In reply to Jonathan Druart from comment #5)
> > > The problem here is that I have no idea which info is needed
> > > in $ilspatron{items}.
> > 
> > Colin, do you know the answer?
> 
> Yes (infact we collided) items is an array of barcodes of items issued to
> this patron

So we only need the barcodes, for other (if exist) calls as well?
If so I can provide a better patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #8 from Colin Campbell  ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Jonathan Druart from comment #5)
> > The problem here is that I have no idea which info is needed
> > in $ilspatron{items}.
> 
> Colin, do you know the answer?

Yes (infact we collided) items is an array of barcodes of items issued to this
patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #7 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #5)
> The problem here is that I have no idea which info is needed
> in $ilspatron{items}.

Colin, do you know the answer?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Colin Campbell  changed:

   What|Removed |Added

  Attachment #80522|0   |1
is obsolete||

--- Comment #6 from Colin Campbell  ---
Created attachment 80655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80655=edit
Signed off patch

Signed off Jonathan's patch as it works for me in testing, Alex can you
confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> Created attachment 80522 [details] [review]
> Bug 21486: Fix 'AU' for SIP

We should not re-add code we removed :)
One possible fix would be to call unblessed_all_relateds, but we should be more
specific. The problem here is that I have no idea which info is needed in
$ilspatron{items}.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #4 from Jonathan Druart  
---
Created attachment 80522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80522=edit
Bug 21486: Fix 'AU' for SIP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #3 from Colin Campbell  ---
Surely you dont need to fetch the info from borrowers - its being called from
the ILS::Patron object we should have that info already

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #2 from Alex Buckley  ---
Actually I want to make a few more changes to this solution for master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

--- Comment #1 from Alex Buckley  ---
Created attachment 80251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80251=edit
Bug 21486: Re-added get_pending_issues function to C4/SIP/ILS/Patron.pm

This allows the list of a borrower's checked out items to be returned by
SIP.

Test plan:
1. Make sure SIP is working with the commands:
sudo koha-enable-sip 
sudo koha-start-sip 

2. Check SIP is working with the command:
telnet localhost 6001

3. Choose a patron with items checked out to them and set their username
and password in the SIPconfig.xml file

4. From inside the Koha-shell from the Koha home directory run the command:
misc/sip_cli_emulator.pl -a localhost -p 6001 -su  -sp
 -l 
--patron  -s "  Y   " -m patron_information

This command is PATRON_INFORMATION, it should return information about
the patron.

The Y in the 3rd position of the quotes means return the list of the
borrowers charged items (items issued to the borrower).

5. Notice the "AU" field is empty:

e.g. READ: 64  00120181008
161428000100010002AOCPL|AA8765432|AEMika
SMith|BLY|CC5|AU|PCB|PIY|AFGreetings from Koha. |

i.e. There should be a barcode after the AU field as the borrower has a
item issued to them

6. Apply patch

7. Restart memcached and plack with the commands:
sudo service memcached restart
sudo koha-plack --restart 

8. Stop SIP:
sudo koha-stop-sip 

9. Then enable and start SIP again:
sudo koha-enable-sip 
sudo koha-start-sip 

10. Repeat step 4 and notice the AU field does have a item barcode
value:

e.g. READ: 64  00120181008
161859000100010002AOCPL|AA8765432|AEMika
SMith|BLY|CC5|AUTEST7474747474|PCB|PIY|AFGreetings from Koha. |

In this case the item barcode value for the AU field is: TEST7474747474

Sponsored-By: Brimbank Library, Australia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request

2018-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486

Josef Moravec  changed:

   What|Removed |Added

 Depends on||19935
 CC||blac...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935
[Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/