[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Causation bug 20978 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 [Bug 21715] Ease translation of account and account offset type descriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Kyle M Hall changed: What|Removed |Added Attachment #81048|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 81057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81057=edit Bug 21584: Wrong offset type for Lost Item Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account This patch performs a trivial fix for this. Signed-off-by: Tomas Cohen Arazi Patch matches what was outlined in test plan, also passes qa test tool Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #4 from Alex Buckley --- Created attachment 81048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81048=edit Bug 21584: Wrong offset type for Lost Item Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account This patch performs a trivial fix for this. Signed-off-by: Tomas Cohen Arazi Patch matches what was outlined in test plan, also passes qa test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #80676|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 --- Comment #3 from Tomás Cohen Arazi --- The original bug is in: koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc it is not easy to 'reproduce', as the code that should generate credit return offsets is not working properly (bug 13098). This is my attempt: - View the following file: installer/data/mysql/account_offset_types.sql $ less installer/data/mysql/account_offset_types.sql - Notice there's 'Lost Item' in line 4 - View koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc $ less koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc - Notice it maps the values from the account_offset_types.sql file into english descriptions. => FAIL: There's no mapping for 'Lost Item', but there's a mapping for 'Lost Item Return', which doesn't really exist in account_offset_types.sql - Apply the patch => SUCCESS: The value <-> description mapping in account_offset_type.inc makes sense now. It respects the values that would be stored on the DB if the feature worked correctly. => BONUS: Koha/Account.pm gets fixed to generate the right value too. Notice there's a hash with mappings for some keywords into both account_offset_types and account types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com --- Comment #2 from Pierre-Marc Thibault --- Can we have a test plan to validate that both changes are effective? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi changed: What|Removed |Added Blocks||13098 Keywords||rel_18_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 [Bug 13098] Item lost multiple times by the same patron will create only be charged once -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20978, 2696 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine payments should show what was paid for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
