[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #11 from Martin Renvoize --- Always great to see test coverage increased :) Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Martin Renvoize changed: What|Removed |Added Attachment #85312|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 85313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85313&action=edit Bug 21692: (QA follow-up) Enhance test for new Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Martin Renvoize changed: What|Removed |Added Attachment #85221|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 85311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85311&action=edit Bug 21692: created a test for Koha::Account->new Test plan: 1) Run test for /Koha/Account.t and confirm that all tests were successful Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 --- Comment #8 from Martin Renvoize --- Created attachment 85312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85312&action=edit Bug 21692: (QA follow-up) Enhance test for new Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 --- Comment #6 from Martin Renvoize --- I'll add the extra's here but leave some attribution... don't want to put off a new dev :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #5 from Martin Renvoize --- This is a bit too minimal for what I was thinking.. we should test the failure case.. in the Koha::Account case the 'new' routine requires the patron_id to be passed and croaks on failure (really we should probably switch this to a Koha::Error object, but that's another story).. So, for tests I would hope to see a mini subtest which tests for two cases for now.. using Test::Warn to catch the croak in the no patron_id passed case and a positive outcome if patron_id is passed.. in reality 'new' should also fail if patron_id is incorrect, but again, that's a future piece. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Katrin Fischer changed: What|Removed |Added Attachment #84154|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 85221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85221&action=edit Bug 21692: created a test for Koha::Account->new Test plan: 1) Run test for /Koha/Account.t and confirm that all tests were successful Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 David Nind changed: What|Removed |Added Attachment #84121|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 84154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84154&action=edit Bug 21692: created a test for Koha::Account->new Test plan: 1) Run test for /Koha/Account.t and confirm that all tests were successful Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Jasmine Amohia changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jasmineamohia.student@wegc. ||school.nz CC||jasmineamohia.student@wegc. ||school.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 --- Comment #2 from Jasmine Amohia --- Created attachment 84121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84121&action=edit Bug 21692: created a test for Koha::Account->new Test plan: 1) Run test for /Koha/Account.t and confirm that all tests were successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Jasmine Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #1 from Aleisha Amohia --- These tests will go in t/db_dependent/Koha/Account.t This page may help: https://wiki.koha-community.org/wiki/Unit_Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21692] Koha::Account->new has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
