[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Bug 21706 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Bug 21706 depends on bug 21526, which changed state. Bug 21526 Summary: TT variables used to build a link should be uri filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 What|Removed |Added Status|BLOCKED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Devinim changed: What|Removed |Added Blocks|21878 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 [Bug 21878] Opac pagination problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Devinim changed: What|Removed |Added Blocks||21878 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 [Bug 21878] Opac pagination problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Bug 21706 depends on bug 21526, which changed state. Bug 21526 Summary: TT variables used to build a link should be uri filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com --- Comment #27 from Martin Renvoize --- Dependencies not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Bug 21706 depends on bug 21526, which changed state. Bug 21526 Summary: TT variables used to build a link should be uri filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #26 from Tomás Cohen Arazi --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #25 from Tomás Cohen Arazi --- Debased against 21526 to ease integration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82007|0 |1 is obsolete|| --- Comment #24 from Tomás Cohen Arazi --- Created attachment 82248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82248=edit Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82004|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 82245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82245=edit Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82005|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 82246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82246=edit Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Attachment #82006|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 82247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82247=edit Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81768|0 |1 is obsolete|| --- Comment #20 from Josef Moravec --- Created attachment 82007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82007=edit Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81765|0 |1 is obsolete|| --- Comment #17 from Josef Moravec --- Created attachment 82004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82004=edit Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81767|0 |1 is obsolete|| --- Comment #19 from Josef Moravec --- Created attachment 82006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82006=edit Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81766|0 |1 is obsolete|| --- Comment #18 from Josef Moravec --- Created attachment 82005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82005=edit Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > Note that html_entities is not needed => Could be "html", that's what I meant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #15 from Jonathan Druart --- Note that html_entities is not needed at first glance, but already used in a similar place (marc frameworks). Also the href attribute are not prefixed by /cgi-bin/koha as we usually do but not important. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #13 from Jonathan Druart --- Created attachment 81767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81767=edit Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #14 from Jonathan Druart --- Created attachment 81768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81768=edit Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #12 from Jonathan Druart --- Created attachment 81766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81766=edit Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Jonathan Druart changed: What|Removed |Added Attachment #81500|0 |1 is obsolete|| Attachment #81501|0 |1 is obsolete|| Attachment #81506|0 |1 is obsolete|| Attachment #81729|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 81765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81765=edit Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #8) > Hi Tomas, I retested, try this: > > 000 authority TOPIC_TERM > > It works for fields with more than one subfield or outside of 000 - some of > that. Ok, I reproduced it in clean master. This was due to the TT filters too. It doesn't show on the bibliographic framworks edit only because they use a (bad) trick to use '_' instead of '@' when editing the subfield. I'm filing a separate bug for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 81729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81729=edit Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- Hi Tomas, I retested, try this: 000 authority TOPIC_TERM It works for fields with more than one subfield or outside of 000 - some of that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > See bug 21526 comment 19. There are plenty to fix. I got rid of the URL build step in the controller, it is now clear text, and the param's are URI-filtered as they should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #4) > I can't add a new subfield with these patches. When clicking on "New" > nothing happens. > > I notice there is also a little error with the tabs on top, there is a gab > between them and the form below. It works for me, Katrina. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- See bug 21526 comment 19. There are plenty to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- I can't add a new subfield with these patches. When clicking on "New" nothing happens. I notice there is also a little error with the tabs on top, there is a gab between them and the form below. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 81506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81506=edit Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21704 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 81501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81501=edit Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 81500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81500=edit Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit | |y.org | Assignee|oleon...@myacpl.org |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Katrin Fischer changed: What|Removed |Added Depends on||13618 Keywords||rel_18_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
