[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #12 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #7) > > Like that? Also I am wondering if we should not remove some classes, I do > > not know what is the purpose of .buttonDot > > This makes no actual difference. I still see a button that does not respond > to clicks. To me it's an improvement, the link is removed if no popup will be opened. So there is an icon but nothing to tell you it's clickable (pointer will be different). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Attachment #81832|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 89379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89379=edit Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #10 from Marcel de Rooy --- The buttondot class indeed seems to be unneeded ballast. Note that we do need the buttonDot_ id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709
--- Comment #9 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #7)
> Like that? Also I am wondering if we should not remove some classes, I do
> not know what is the purpose of .buttonDot
This makes no actual difference. I still see a button that does not respond to
clicks. But this is the actual design: if you do not explicitly assign a click
event, it should not respond to click. (The only problem is that we have been
used to some buttons that translated click to focus events.)
I agree with paxed that we should see the difference right away: have a visual
distinction between a real popup and just a focus action (there may be a report
already for that). Only removing the button is not the solution, since we still
want to alert on the focus action.
It should not be that hard to define a separate class and add some css
associated to it to achieve our goal.
On the other hand, when we really want click to translate to focus, add three
lines in the popup script. For instance for 003 in marc21_orgcode.pl:
function Click$params->{id}(event) {
\$('#'+event.data.id).focus();
}
And now it responds to click and triggers focus.. (I still think though that it
should not be the default.)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #8 from Marcel de Rooy --- This seems to be invalid HTML :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #7 from Jonathan Druart --- Like that? Also I am wondering if we should not remove some classes, I do not know what is the purpose of .buttonDot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #6 from Jonathan Druart --- Created attachment 81832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81832=edit Bug 21709: Replace 'no popup' plugin links with a span -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #5 from paxed --- But in these cases, the icon is clickable, it just does nothing. If it did the same as clicking on the field (autofilling the data), then it would be OK. If the icon wasn't clickable, it would be OK. (Although I'd still want a visual indication without needing to move the mouse over it) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #4 from Katrin Fischer --- So they icon can indicate extra functionality that is linked to the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I think they work when clicking in the field, not all have a pop-up. Similar to the one behind dateacessioned or autobarode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #2 from paxed --- (In reply to Marcel de Rooy from comment #1) > Please add more details how to reproduce. Install master with defaults, go to Cataloging > New record > Default framework, try to click on the 003 or 005 tag editor icon. Contrast that with the tag editor icons of 000, 007, or 008. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #1 from Marcel de Rooy --- Please add more details how to reproduce. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
