[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #118 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #117 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Bug 21756 depends on bug 21721, which changed state. Bug 21721 Summary: Update C4::Circulation::AddRenewal to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #113 from Kyle M Hall --- Created attachment 86449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86449&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #110 from Kyle M Hall --- Created attachment 86446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86446&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #116 from Kyle M Hall --- Created attachment 86452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86452&action=edit Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #114 from Kyle M Hall --- Created attachment 86450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86450&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #112 from Kyle M Hall --- Created attachment 86448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86448&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #106 from Kyle M Hall --- Created attachment 86442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86442&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #111 from Kyle M Hall --- Created attachment 86447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86447&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #115 from Kyle M Hall --- Created attachment 86451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86451&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #108 from Kyle M Hall --- Created attachment 86444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86444&action=edit Bug 21756: Add deprecation warning to manualinvoice https://bugs.koha-community.org/show_bug.cgi?id=21756 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #109 from Kyle M Hall --- Created attachment 86445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86445&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #107 from Kyle M Hall --- Created attachment 86443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86443&action=edit Bug 21756: Replace manualinvoice with add_debit in tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Kyle M Hall changed: What|Removed |Added Attachment #86265|0 |1 is obsolete|| Attachment #86266|0 |1 is obsolete|| Attachment #86267|0 |1 is obsolete|| Attachment #86268|0 |1 is obsolete|| Attachment #86269|0 |1 is obsolete|| Attachment #86270|0 |1 is obsolete|| Attachment #86271|0 |1 is obsolete|| Attachment #86272|0 |1 is obsolete|| Attachment #86273|0 |1 is obsolete|| Attachment #86274|0 |1 is obsolete|| Attachment #86275|0 |1 is obsolete|| Attachment #86276|0 |1 is obsolete|| --- Comment #105 from Kyle M Hall --- Created attachment 86441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86441&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens changed: What|Removed |Added QA Contact|josef.mora...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #104 from Nick Clemens --- Setting to SO for final QA pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #103 from Martin Renvoize --- Ooh, I thought Tomas was doing a final QA as both Josef and I worked on it and in effect signed off each others work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #102 from Nick Clemens --- Looks like we lost the sign off lines on the latest patches. I also only see Josef, did these skip SO and go straight to QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85665|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #101 from Martin Renvoize --- Freshly rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85657|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 86268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86268&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85658|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 86269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86269&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #100 from Martin Renvoize --- Created attachment 86276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86276&action=edit Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85664|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 86275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86275&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85663|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 86274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86274&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85659|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 86270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86270&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85662|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 86273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86273&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85661|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 86272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86272&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85655|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 86266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86266&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85660|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 86271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86271&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85656|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 86267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86267&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85654|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 86265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86265&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Blocks|22393 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #88 from Josef Moravec --- Created attachment 85665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85665&action=edit Bug 21756: (QA follow-up) Add missing offset_types to installer file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #81 from Josef Moravec --- Created attachment 85658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85658&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #82 from Josef Moravec --- Created attachment 85659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85659&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #79 from Josef Moravec --- Created attachment 85656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85656&action=edit Bug 21756: Replace manualinvoice with add_debit in tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #87 from Josef Moravec --- Created attachment 85664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85664&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #85 from Josef Moravec --- Created attachment 85662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85662&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #86 from Josef Moravec --- Created attachment 85663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85663&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added Attachment #85638|0 |1 is obsolete|| Attachment #85639|0 |1 is obsolete|| Attachment #85640|0 |1 is obsolete|| Attachment #85641|0 |1 is obsolete|| Attachment #85642|0 |1 is obsolete|| Attachment #85643|0 |1 is obsolete|| Attachment #85644|0 |1 is obsolete|| Attachment #85645|0 |1 is obsolete|| Attachment #85646|0 |1 is obsolete|| Attachment #85647|0 |1 is obsolete|| Attachment #85648|0 |1 is obsolete|| --- Comment #77 from Josef Moravec --- Created attachment 85654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85654&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #80 from Josef Moravec --- Created attachment 85657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85657&action=edit Bug 21756: Add deprecation warning to manualinvoice https://bugs.koha-community.org/show_bug.cgi?id=21756 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #84 from Josef Moravec --- Created attachment 85661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85661&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #78 from Josef Moravec --- Created attachment 85655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85655&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #83 from Josef Moravec --- Created attachment 85660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85660&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85514|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #76 from Martin Renvoize --- Dopey mistake corrected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85515|0 |1 is obsolete|| --- Comment #75 from Martin Renvoize --- Created attachment 85648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85648&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85507|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize --- Created attachment 85640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85640&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85508|0 |1 is obsolete|| --- Comment #68 from Martin Renvoize --- Created attachment 85641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85641&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85511|0 |1 is obsolete|| --- Comment #71 from Martin Renvoize --- Created attachment 85644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85644&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85506|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 85639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85639&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85510|0 |1 is obsolete|| --- Comment #70 from Martin Renvoize --- Created attachment 85643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85643&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85505|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 85638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85638&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85512|0 |1 is obsolete|| --- Comment #72 from Martin Renvoize --- Created attachment 85645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85645&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #74 from Martin Renvoize --- Created attachment 85647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85647&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85509|0 |1 is obsolete|| --- Comment #69 from Martin Renvoize --- Created attachment 85642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85642&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85513|0 |1 is obsolete|| --- Comment #73 from Martin Renvoize --- Created attachment 85646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85646&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #64 from Josef Moravec --- Sorry, still not perfect... t/db_dependent/Koha/Patrons.t .. 12/33 DBD::mysql::st execute failed: Data too long for column 'type' at row 1 [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=5.00, 1='408', 2='Account Management Fee'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # No tests run! # Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"' # at t/db_dependent/Koha/Patrons.t line 473. DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'type' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 155 # Looks like your test exited with 255 just after 14. 'type' is of type VARCHAR (16), so 'Account Management Fee' is too long here also one type here: FAIL t/db_dependent/Accounts.t FAIL spelling recieved ==> received -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Blocks||22393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85430|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 85513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85513&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #63 from Martin Renvoize --- Created attachment 85515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85515&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85425|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 85509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85509&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85422|0 |1 is obsolete|| --- Comment #55 from Martin Renvoize --- Created attachment 85507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85507&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85428|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 85511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85511&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85421|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize --- Created attachment 85506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85506&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #62 from Martin Renvoize --- Created attachment 85514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85514&action=edit Bug 21756: (QA follow-up) Add `Account Management Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85427|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 85510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85510&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85429|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 85512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85512&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85424|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 85508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85508&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85420|0 |1 is obsolete|| --- Comment #53 from Martin Renvoize --- Created attachment 85505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85505&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85426|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85423|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Summary|Remove |Deprecate |C4::Accounts::manualinvoice |C4::Accounts::manualinvoice |(use|(use |Koha::Account->add_debit|Koha::Account->add_debit |instead)|instead) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
