[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Jonathan Druart changed: What|Removed |Added Text to go in the|Option added to |Option added to release notes|advance_notice.pl and |advance_notice.pl and |overdue_notice.pl for |overdue_notice.pl for |sending notices from owning |sending notices from owning |or issuing branch. |or issuing library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Text to go in the||Option added to release notes||advance_notice.pl and ||overdue_notice.pl for ||sending notices from owning ||or issuing branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #35 from Jonathan Druart --- Please fill the release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #34 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #33 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #32 from Nick Clemens --- Created attachment 114071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114071&action=edit Bug 21886: (QA follow-up) Fix indentation, prevent warns, fix parameter, simplify SQL The SQL code was duplicated, I combine them here frombranch needs to take input switch owning to frombranch in second script initialize hash as empty list, not a reference add a newline after printed output if not mailing notices Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #31 from Nick Clemens --- Created attachment 114070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114070&action=edit Bug 21886: (QA follow-up) Update parameters As discussed, this patch updates the --owning parameter to more clearly represent it's function. --owning boolean => --frombranch=item-homebranch|item-issuebranch Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #30 from Nick Clemens --- Created attachment 114069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114069&action=edit Bug 21886: (QA follow-up) Fix QA script errors This patch fixes a perlcritic issue and also replaces tabs with four spaces where appropriate. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Nick Clemens changed: What|Removed |Added Attachment #111872|0 |1 is obsolete|| Attachment #111873|0 |1 is obsolete|| Attachment #112990|0 |1 is obsolete|| --- Comment #29 from Nick Clemens --- Created attachment 114068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114068&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add --library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "--library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library Signed-off-by: Björn Nylén Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #28 from Katrin Fischer --- (In reply to Martin Renvoize from comment #26) > (In reply to Katrin Fischer from comment #25) > > got 2 votes for checkout and library now :) Maybe missed more discussion, > > why not using comment#22 suggestions? > > Why not using comment#20 ;). > > I didn't get a reply to why that wasn't a good idea.. I feel my followup > makes the syntax considerably clearer personally. having two boolean > options that are mutually excluding and don't clearly say what they actually > do in the name is far less clear to me than having one parameter that's > clearly named with two clear options available. Happy about the structural change - was only struggling with "issue" vs. "checkout", but can "live" with it here :) Setting back to SO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Timothy Alexis Vass --- Can we reach a decision on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #26 from Martin Renvoize --- (In reply to Katrin Fischer from comment #25) > got 2 votes for checkout and library now :) Maybe missed more discussion, > why not using comment#22 suggestions? Why not using comment#20 ;). I didn't get a reply to why that wasn't a good idea.. I feel my followup makes the syntax considerably clearer personally. having two boolean options that are mutually excluding and don't clearly say what they actually do in the name is far less clear to me than having one parameter that's clearly named with two clear options available. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #25 from Katrin Fischer --- got 2 votes for checkout and library now :) Maybe missed more discussion, why not using comment#22 suggestions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #24 from Martin Renvoize --- Be great to get a final independant QA on my followup.. setting signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #23 from Martin Renvoize --- Created attachment 112990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112990&action=edit Bug 21886: (QA follow-up) Update parameters As discussed, this patch updates the --owning parameter to more clearly represent it's function. --owning boolean => --frombranch=item-homebranch|item-issuebranch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #22 from Nick Clemens --- (In reply to Katrin Fischer from comment #21) > I just wanted to say that I think filter is wrong here. > > I think replacing owning is a good point. But I'd suggest different > parameter names if we want to stick with terminology: > > - checkout_library > - item_home_library > > homebranch is a bit misleading as it could be the patron's or the item's. +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #21 from Katrin Fischer --- I just wanted to say that I think filter is wrong here. I think replacing owning is a good point. But I'd suggest different parameter names if we want to stick with terminology: - checkout_library - item_home_library homebranch is a bit misleading as it could be the patron's or the item's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #20 from Martin Renvoize --- (In reply to Martin Renvoize from comment #19) > Good question.. > > WE could use --use-homebranch as the current implementation is a boolean.. > the '-use-' would make that a little clearer.. > > OR > > Perhaps we should change it to something more descriptive entirely.. > '--branchfilter=issuebranch|homebranch' to make it clear that we're applying > a filter on the lookup and it can take either 'issuebranch' or 'homebranch'. That final one should more likely be `--frombranch=issuebranch|homebranch` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #19 from Martin Renvoize --- Good question.. WE could use --use-homebranch as the current implementation is a boolean.. the '-use-' would make that a little clearer.. OR Perhaps we should change it to something more descriptive entirely.. '--branchfilter=issuebranch|homebranch' to make it clear that we're applying a filter on the lookup and it can take either 'issuebranch' or 'homebranch'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||n...@bywatersolutions.com --- Comment #18 from Jonathan Druart --- I am not sure about the term "owning", we usually use "homebranch". Maybe we should stick with this terminology as it is widely used in Koha. Katrin, Nick, what do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #17 from Martin Renvoize --- This does the trick and now passes the QA scripts. I would have liked to have seen the query in GetUpcomingDueIssues adapted for the --library case as opposed to pulling back all the results only to then filter them in perl.. but this would have also required unit tests. One for a followup bug I think. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #16 from Martin Renvoize --- Created attachment 111873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111873&action=edit Bug 21886: (QA follow-up) Fix QA script errors This patch fixes a perlcritic issue and also replaces tabs with four spaces where appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Martin Renvoize changed: What|Removed |Added Attachment #111828|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 111872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111872&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add --library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "--library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library Signed-off-by: Björn Nylén Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #14 from Timothy Alexis Vass --- I corrected the --man where it the option was presented as -owning instead of --owning in the same commit as Sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Attachment #111711|0 |1 is obsolete|| --- Comment #13 from Timothy Alexis Vass --- Created attachment 111828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111828&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add -library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "-library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 David Gustafsson changed: What|Removed |Added CC||glask...@gmail.com Status|Failed QA |Needs Signoff --- Comment #12 from David Gustafsson --- I am not the author of this patch but have created a new patch rebased on latest Koha master with the code that is currently running in production. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 David Gustafsson changed: What|Removed |Added Attachment #111679|0 |1 is obsolete|| --- Comment #11 from David Gustafsson --- Created attachment 111711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111711&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add -library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "-library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #10 from Timothy Alexis Vass --- This patch also fixes the SQL statements in Circulation.pm Stefan has kindly informed that Gothenburg University Library has this working in production, which is great. We anticipate a proper patch from the proper source. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Attachment #111582|0 |1 is obsolete|| --- Comment #9 from Timothy Alexis Vass --- Created attachment 111679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111679&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add -library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "-library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #8 from Timothy Alexis Vass --- This patch fixes the SQL statement in overdue_notice.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Attachment #111581|0 |1 is obsolete|| --- Comment #7 from Timothy Alexis Vass --- Created attachment 111582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111582&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add -library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "-library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added CC||timothy_alexis.v...@ub.lu.s ||e --- Comment #6 from Timothy Alexis Vass --- Attached a new patch correcting the merge conflict and: --owning instead of -owning in the --man content. -library instead of --library in the test description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Timothy Alexis Vass changed: What|Removed |Added Attachment #86513|0 |1 is obsolete|| --- Comment #5 from Timothy Alexis Vass --- Created attachment 111581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111581&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add -library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "-library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Stefan Berndtsson changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #4 from Stefan Berndtsson --- There is a bug in this one where only one of two SQL queries in overdue_notices.pl are changed to handle the owning library parameter. I will try to push a fix soon, but in the meantime I've set this back to In Discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=3461 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Björn Nylén changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bjorn.ny...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Björn Nylén changed: What|Removed |Added Attachment #82668|0 |1 is obsolete|| --- Comment #3 from Björn Nylén --- Created attachment 86513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86513&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add --library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds a "--library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library Signed-off-by: Björn Nylén -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |stefan.berndts...@ub.gu.se |ity.org | CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Stefan, please don't forget to assign the bug to yourself when providing a patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Stefan Berndtsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #1 from Stefan Berndtsson --- Created attachment 82668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82668&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add --library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds a "--library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
