[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #16 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Depends on||22043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #14 from Martin Renvoize --- Patches rescued and QA run done.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Attachment #83739|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Attachment #87001|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 87004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87004=edit Bug 22076: Fix the same situation for lost items Signed-off-by: Geeta Halley Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Attachment #87000|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 87003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87003=edit Bug 22076: SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Attachment #87002|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 87005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87005=edit Bug 22076: Add missing whitespace on if statments Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Attachment #83738|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize changed: What|Removed |Added Attachment #83737|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #8 from Martin Renvoize --- Created attachment 87000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87000=edit Bug 22076: SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley Rescued-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #10 from Martin Renvoize --- Created attachment 87002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87002=edit Bug 22076: Add missing whitespace on if statments Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #9 from Martin Renvoize --- Created attachment 87001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87001=edit Bug 22076: Fix the same situation for lost items Signed-off-by: Geeta Halley Rescued-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy --- * Commit title does not start with 'Bug X: ' - 8ab6da3438 * Commit title does not start with 'Bug X: ' - f1d99e01d1 * Commit title does not start with 'Bug X: ' - e79dbc7dbc Please adjust yourself now. This is required for a longer time already ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #6 from Kyle M Hall --- Created attachment 83739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83739=edit Bug 22076 - Add missing whitespace on if statments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Kyle M Hall changed: What|Removed |Added Attachment #83709|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 83737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83737=edit Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #5 from Kyle M Hall --- Created attachment 83738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83738=edit Bug 22076 - Fix the same situation for lost items Signed-off-by: Geeta Halley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens changed: What|Removed |Added Attachment #83694|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 83709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83709=edit Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Kyle M Hall changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #2 from Kyle M Hall --- *** Bug 21745 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #1 from Kyle M Hall --- Created attachment 83694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83694=edit Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
