[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Katrin Fischer changed: What|Removed |Added Text to go in the|Adds the ability to define |Adds the ability to define release notes|groups of libraries for use |groups of libraries for use |in holds policy. Sponsored |in holds policy. |by VOKAL. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Jonathan Druart changed: What|Removed |Added Blocks||25421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25421 [Bug 25421] Inconsistent return value in Koha::Libraries->pickup_locations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #302 from Jonathan Druart --- The only D10 failures we have are coming from here: 12:56:37 koha_1 | # Failed test 'ReservesControlBranch: ItemHomeLibrary, biblio1, patron1 should return 6 but returns 7' 12:56:37 koha_1 | # at t/db_dependent/Koha/Biblio.t line 418. 12:56:37 koha_1 | 12:56:37 koha_1 | # Failed test 'ReservesControlBranch: PatronLibrary, biblio1, patron1 should return 6 but returns 7' 12:56:37 koha_1 | # at t/db_dependent/Koha/Biblio.t line 418. 12:56:37 koha_1 | # Looks like you planned 29 tests but ran 31. 12:56:37 koha_1 | # Looks like you failed 2 tests of 31 run. 12:56:37 koha_1 | 12:56:37 koha_1 | # Failed test 'pickup_locations' 12:56:37 koha_1 | # at t/db_dependent/Koha/Biblio.t line 435. 12:56:46 koha_1 | # Looks like you failed 1 test of 12. 12:56:46 koha_1 | [10:56:45] t/db_dependent/Koha/Biblio.t That would be great to see them fixed for 20.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 koha-US bug tracker changed: What|Removed |Added CC|bugzi...@koha-us.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Blocks||24657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #301 from Agustín Moyano ---
(In reply to Agustín Moyano from comment #300)
> (In reply to Jonathan Druart from comment #299)
> > A different failure from jenkins (D9 run 1139):
> >
> > https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull
> >
> >
> > koha_1 |
> > koha_1 | # Failed test 'Patron can place hold if no circ_rules
> > where defined'
> > koha_1 | # at t/db_dependent/Holds.t line 1095.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'OK'
> > koha_1 |
> > koha_1 | # Failed test 'Patron cannot place hold because pickup
> > location is not part of hold group'
> > koha_1 | # at t/db_dependent/Holds.t line 1122.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1 |
> > koha_1 | # Failed test 'Patron can place hold if
> > default_branch_circ_rules is set to "any" for library 2'
> > koha_1 | # at t/db_dependent/Holds.t line 1142.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'OK'
> > koha_1 |
> > koha_1 | # Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for library 2'
> > koha_1 | # at t/db_dependent/Holds.t line 1162.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1 |
> > koha_1 | # Failed test 'Patron can place hold if
> > hold_fulfillment_policy is set to "any" for itemtype 2'
> > koha_1 | # at t/db_dependent/Holds.t line 1182.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'OK'
> > koha_1 |
> > koha_1 | # Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for itemtype 2'
> > koha_1 | # at t/db_dependent/Holds.t line 1202.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1 |
> > koha_1 | # Failed test 'Patron can place hold if
> > hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
> > koha_1 | # at t/db_dependent/Holds.t line 1222.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'OK'
> > koha_1 |
> > koha_1 | # Failed test 'Patron cannot place hold if
> > hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
> > koha_1 | # at t/db_dependent/Holds.t line 1242.
> > koha_1 | # Structures begin differing at:
> > koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> > koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> > koha_1 | # Looks like you failed 8 tests of 9.
> > koha_1 |
> > koha_1 | # Failed test 'CanItemBeReserved /
> > pickup_not_in_hold_group'
> > koha_1 | # at t/db_dependent/Holds.t line 1249.
> > koha_1 | # Looks like you failed 1 test of 61.
> > koha_1 | [15:06:03] t/db_dependent/Holds.t
>
> Hi Jonathan,
>
> I think I spotted this failure.. should I make a new bug to fix this tests?
>
> The random failure on Item.t I'm at a loss. Supposedly I delete every
> circulation_rule, every item, every issue and every patron, but it seems not
> everything gets deleted.. or that's what I guess.
>
> Do you have any tip of what could be wrong?
Never mind, I think I nailed it!.. I'll submit patches in following bug!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #300 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #299)
> A different failure from jenkins (D9 run 1139):
>
> https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull
>
>
> koha_1 |
> koha_1 | # Failed test 'Patron can place hold if no circ_rules
> where defined'
> koha_1 | # at t/db_dependent/Holds.t line 1095.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'OK'
> koha_1 |
> koha_1 | # Failed test 'Patron cannot place hold because pickup
> location is not part of hold group'
> koha_1 | # at t/db_dependent/Holds.t line 1122.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1 |
> koha_1 | # Failed test 'Patron can place hold if
> default_branch_circ_rules is set to "any" for library 2'
> koha_1 | # at t/db_dependent/Holds.t line 1142.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'OK'
> koha_1 |
> koha_1 | # Failed test 'Patron cannot place hold if
> hold_fulfillment_policy is set to "hold group" for library 2'
> koha_1 | # at t/db_dependent/Holds.t line 1162.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1 |
> koha_1 | # Failed test 'Patron can place hold if
> hold_fulfillment_policy is set to "any" for itemtype 2'
> koha_1 | # at t/db_dependent/Holds.t line 1182.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'OK'
> koha_1 |
> koha_1 | # Failed test 'Patron cannot place hold if
> hold_fulfillment_policy is set to "hold group" for itemtype 2'
> koha_1 | # at t/db_dependent/Holds.t line 1202.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1 |
> koha_1 | # Failed test 'Patron can place hold if
> hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
> koha_1 | # at t/db_dependent/Holds.t line 1222.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'OK'
> koha_1 |
> koha_1 | # Failed test 'Patron cannot place hold if
> hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
> koha_1 | # at t/db_dependent/Holds.t line 1242.
> koha_1 | # Structures begin differing at:
> koha_1 | # $got->{status} = 'libraryNotPickupLocation'
> koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
> koha_1 | # Looks like you failed 8 tests of 9.
> koha_1 |
> koha_1 | # Failed test 'CanItemBeReserved / pickup_not_in_hold_group'
> koha_1 | # at t/db_dependent/Holds.t line 1249.
> koha_1 | # Looks like you failed 1 test of 61.
> koha_1 | [15:06:03] t/db_dependent/Holds.t
Hi Jonathan,
I think I spotted this failure.. should I make a new bug to fix this tests?
The random failure on Item.t I'm at a loss. Supposedly I delete every
circulation_rule, every item, every issue and every patron, but it seems not
everything gets deleted.. or that's what I guess.
Do you have any tip of what could be wrong?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #299 from Jonathan Druart
---
A different failure from jenkins (D9 run 1139):
https://jenkins.koha-community.org/job/Koha_Master_D9/1139/consoleFull
koha_1 |
koha_1 | # Failed test 'Patron can place hold if no circ_rules
where defined'
koha_1 | # at t/db_dependent/Holds.t line 1095.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'OK'
koha_1 |
koha_1 | # Failed test 'Patron cannot place hold because pickup
location is not part of hold group'
koha_1 | # at t/db_dependent/Holds.t line 1122.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
koha_1 |
koha_1 | # Failed test 'Patron can place hold if
default_branch_circ_rules is set to "any" for library 2'
koha_1 | # at t/db_dependent/Holds.t line 1142.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'OK'
koha_1 |
koha_1 | # Failed test 'Patron cannot place hold if
hold_fulfillment_policy is set to "hold group" for library 2'
koha_1 | # at t/db_dependent/Holds.t line 1162.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
koha_1 |
koha_1 | # Failed test 'Patron can place hold if
hold_fulfillment_policy is set to "any" for itemtype 2'
koha_1 | # at t/db_dependent/Holds.t line 1182.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'OK'
koha_1 |
koha_1 | # Failed test 'Patron cannot place hold if
hold_fulfillment_policy is set to "hold group" for itemtype 2'
koha_1 | # at t/db_dependent/Holds.t line 1202.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
koha_1 |
koha_1 | # Failed test 'Patron can place hold if
hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
koha_1 | # at t/db_dependent/Holds.t line 1222.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'OK'
koha_1 |
koha_1 | # Failed test 'Patron cannot place hold if
hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
koha_1 | # at t/db_dependent/Holds.t line 1242.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{status} = 'libraryNotPickupLocation'
koha_1 | # $expected->{status} = 'pickupNotInHoldGroup'
koha_1 | # Looks like you failed 8 tests of 9.
koha_1 |
koha_1 | # Failed test 'CanItemBeReserved / pickup_not_in_hold_group'
koha_1 | # at t/db_dependent/Holds.t line 1249.
koha_1 | # Looks like you failed 1 test of 61.
koha_1 | [15:06:03] t/db_dependent/Holds.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #298 from Jonathan Druart --- They seem to fail quite consistently on U18: https://jenkins.koha-community.org/job/Koha_Master_U18/606/consoleFull https://jenkins.koha-community.org/job/Koha_Master_U18/607/consoleFull -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #297 from Jonathan Druart --- It's t/db_dependent/Koha/Item.t, but it's failing randomly. Failing on jenkins on D9: https://jenkins.koha-community.org/job/Koha_Master_D9/1061/consoleFull And more recently: https://jenkins.koha-community.org/job/Koha_Master_D9/1132/consoleFull You certainly need to launch them several times to see them fail (I cannot test right now). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #296 from Agustín Moyano --- (In reply to Agustín Moyano from comment #295) > (In reply to Jonathan Druart from comment #294) > > (In reply to Jonathan Druart from comment #290) > > > Another one (Koha_Master_D9 run 1061): > > > > > > koha_1 | # Failed test 'item1, patron1, holdallowed: > > > homebranch, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item1, patron1, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item1, patron1, holdallowed: > > > holdgroup, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item1, patron4, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item3, patron1, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item3, patron4, holdallowed: any, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | > > > koha_1 | # Failed test 'item3, patron4, holdallowed: > > > holdgroup, > > > hold_fulfillment_policy: any should return 3 but returns 4' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > > koha_1 | # Looks like you planned 114 tests but ran 121. > > > koha_1 | # Looks like you failed 7 tests of 121 run. > > > koha_1 | > > > koha_1 | # Failed test 'pickup_locations' > > > koha_1 | # at t/db_dependent/Koha/Item.t line 332. > > > koha_1 | # Looks like you failed 1 test of 4. > > > koha_1 | [12:19:06] t/db_dependent/Koha/Item.t > > > .. > > > > These ones are still failing. > > Agustín, could you take a look at them? > > ASAP Hi Jonathan, I cannot reproduce failure kohadev-koha@cffdb0ae6429:/kohadevbox/koha$ cat /etc/issue Debian GNU/Linux 9 \n \l kohadev-koha@cffdb0ae6429:/kohadevbox/koha$ prove t/db_dependent/Holds.t t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t t/db_dependent/Holds.t ... ok t/db_dependent/Koha/Biblios.t ok t/db_dependent/Koha/Items.t .. ok t/db_dependent/Koha/Libraries.t .. ok t/db_dependent/LibraryGroups.t ... ok All tests successful. Files=5, Tests=106, 30 wallclock secs ( 0.08 usr 0.02 sys + 23.13 cusr 3.29 csys = 26.52 CPU) Result: PASS I'm testing in koha-testing-docker with Debian 9.. how are those tests run? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #295 from Agustín Moyano --- (In reply to Jonathan Druart from comment #294) > (In reply to Jonathan Druart from comment #290) > > Another one (Koha_Master_D9 run 1061): > > > > koha_1 | # Failed test 'item1, patron1, holdallowed: homebranch, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item1, patron1, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item1, patron1, holdallowed: holdgroup, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item1, patron4, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item3, patron1, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item3, patron4, holdallowed: any, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | > > koha_1 | # Failed test 'item3, patron4, holdallowed: holdgroup, > > hold_fulfillment_policy: any should return 3 but returns 4' > > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > > koha_1 | # Looks like you planned 114 tests but ran 121. > > koha_1 | # Looks like you failed 7 tests of 121 run. > > koha_1 | > > koha_1 | # Failed test 'pickup_locations' > > koha_1 | # at t/db_dependent/Koha/Item.t line 332. > > koha_1 | # Looks like you failed 1 test of 4. > > koha_1 | [12:19:06] t/db_dependent/Koha/Item.t > > .. > > These ones are still failing. > Agustín, could you take a look at them? ASAP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #294 from Jonathan Druart --- (In reply to Jonathan Druart from comment #290) > Another one (Koha_Master_D9 run 1061): > > koha_1 | # Failed test 'item1, patron1, holdallowed: homebranch, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item1, patron1, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item1, patron1, holdallowed: holdgroup, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item1, patron4, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item3, patron1, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item3, patron4, holdallowed: any, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | > koha_1 | # Failed test 'item3, patron4, holdallowed: holdgroup, > hold_fulfillment_policy: any should return 3 but returns 4' > koha_1 | # at t/db_dependent/Koha/Item.t line 308. > koha_1 | # Looks like you planned 114 tests but ran 121. > koha_1 | # Looks like you failed 7 tests of 121 run. > koha_1 | > koha_1 | # Failed test 'pickup_locations' > koha_1 | # at t/db_dependent/Koha/Item.t line 332. > koha_1 | # Looks like you failed 1 test of 4. > koha_1 | [12:19:06] t/db_dependent/Koha/Item.t > .. These ones are still failing. Agustín, could you take a look at them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #293 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #292) > We still have failing tests related to these patches: > > t/db_dependent/Koha/Libraries.t .. 1/9 # Looks like you planned > 11 tests but ran 2. > > # Failed test 'Given BranchTransferLimitsType = itemtype and > item-level_itypes = ON' > # at t/db_dependent/Koha/Libraries.t line 258. > # Looks like you planned 4 tests but ran 2. > # Looks like you failed 1 test of 2 run. > > # Failed test 'UseBranchTransferLimits = ON' > # at t/db_dependent/Koha/Libraries.t line 422. > # Looks like you failed 1 test of 2. > t/db_dependent/Koha/Libraries.t .. 6/9 > # Failed test 'pickup_locations' > # at t/db_dependent/Koha/Libraries.t line 423. > Can't call method "branchcode" on unblessed reference at > t/db_dependent/Koha/Libraries.t line 195. I'll be working on it this morning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #292 from Jonathan Druart --- We still have failing tests related to these patches: t/db_dependent/Koha/Libraries.t .. 1/9 # Looks like you planned 11 tests but ran 2. # Failed test 'Given BranchTransferLimitsType = itemtype and item-level_itypes = ON' # at t/db_dependent/Koha/Libraries.t line 258. # Looks like you planned 4 tests but ran 2. # Looks like you failed 1 test of 2 run. # Failed test 'UseBranchTransferLimits = ON' # at t/db_dependent/Koha/Libraries.t line 422. # Looks like you failed 1 test of 2. t/db_dependent/Koha/Libraries.t .. 6/9 # Failed test 'pickup_locations' # at t/db_dependent/Koha/Libraries.t line 423. Can't call method "branchcode" on unblessed reference at t/db_dependent/Koha/Libraries.t line 195. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Joy Nelson changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||j...@bywatersolutions.com --- Comment #291 from Joy Nelson --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #290 from Jonathan Druart --- Another one (Koha_Master_D9 run 1061): koha_1 | # Failed test 'item1, patron1, holdallowed: homebranch, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | koha_1 | # Failed test 'item1, patron1, holdallowed: any, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | koha_1 | # Failed test 'item1, patron1, holdallowed: holdgroup, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | koha_1 | # Failed test 'item1, patron4, holdallowed: any, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | koha_1 | # Failed test 'item3, patron1, holdallowed: any, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | koha_1 | # Failed test 'item3, patron4, holdallowed: any, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | koha_1 | # Failed test 'item3, patron4, holdallowed: holdgroup, hold_fulfillment_policy: any should return 3 but returns 4' koha_1 | # at t/db_dependent/Koha/Item.t line 308. koha_1 | # Looks like you planned 114 tests but ran 121. koha_1 | # Looks like you failed 7 tests of 121 run. koha_1 | koha_1 | # Failed test 'pickup_locations' koha_1 | # at t/db_dependent/Koha/Item.t line 332. koha_1 | # Looks like you failed 1 test of 4. koha_1 | [12:19:06] t/db_dependent/Koha/Item.t .. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #289 from Jonathan Druart --- There is a (random?) failure on Master_D9 run 1053: koha_1 | # Failed test 'ReservesControlBranch: ItemHomeLibrary, biblio1, patron1 should return 6 but returns 7' koha_1 | # at t/db_dependent/Koha/Biblio.t line 419. koha_1 | koha_1 | # Failed test 'ReservesControlBranch: PatronLibrary, biblio1, patron1 should return 6 but returns 7' koha_1 | # at t/db_dependent/Koha/Biblio.t line 419. koha_1 | # Looks like you planned 29 tests but ran 31. koha_1 | # Looks like you failed 2 tests of 31 run. koha_1 | koha_1 | # Failed test 'pickup_locations' koha_1 | # at t/db_dependent/Koha/Biblio.t line 436. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Caroline Cyr La Rose changed: What|Removed |Added Keywords|Manual, | |release-notes-needed| CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Text to go in the||Adds the ability to define release notes||groups of libraries for use ||in holds policy. Sponsored ||by VOKAL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #288 from Jonathan Druart --- # Failed test 'No tests run for subtest "pickup_locations() tests"' # at t/db_dependent/Template/Plugin/Branches.t line 151. Can't call method "unblessed" on unblessed reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 93. # Looks like your test exited with 255 just after 3. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Katrin Fischer changed: What|Removed |Added Blocks||24350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 [Bug 24350] Can't place holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added CC||gmcha...@gmail.com Component|Architecture, internals,|Hold requests |and plumbing| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #287 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added Text to go in the|SPONSORED BY: Vermont | release notes|Organization of Koha| |Automated Libraries | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #286 from Tomás Cohen Arazi --- Created attachment 96558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96558&action=edit Bug 22284: (QA follow-up) Make pickup locations be Koha::Library objects This patch makes the following methods return array references of Koha::Library objects instead or unblessed objects; - Koha::Item->pickup_locations - Koha::Biblio->pickup_locations - Koha::Libraries->pickup_locations Bonus: - The template plugin is adjusted to unbless things to keep behavior - Tests are moved to the right .t file. - Tests for the new behavior are added. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #285 from Tomás Cohen Arazi --- Created attachment 96557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96557&action=edit Bug 22284: (follow-up) Anotate boolean values in Koha::Schema::Result::LibraryGroup Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #284 from Tomás Cohen Arazi --- Created attachment 96556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96556&action=edit Bug 22284: Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #283 from Tomás Cohen Arazi --- Created attachment 96555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96555&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations * Bug 22284: (follow-up) Fix tests * Bug 22284: (follow-up) Fix typo in request.tt * Bug 22284: (follow-up) Filter pickup on specific item click * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #282 from Tomás Cohen Arazi --- Created attachment 96554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96554&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #281 from Tomás Cohen Arazi --- Created attachment 96553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96553&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures * Bug 22284: (follow-up) fix test count after merge * Bug 22284: (follow-up) fixes after 15496 * Bug 22284: (follow-up) fixes after 18936 * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #280 from Tomás Cohen Arazi --- Created attachment 96552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96552&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #275 from Tomás Cohen Arazi --- Created attachment 96547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96547&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #278 from Tomás Cohen Arazi --- Created attachment 96550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96550&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #276 from Tomás Cohen Arazi ---
Created attachment 96548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96548&action=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Josef Moravec
Signed-off-by: Liz Rea
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #277 from Tomás Cohen Arazi --- Created attachment 96549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96549&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #279 from Tomás Cohen Arazi --- Created attachment 96551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96551&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #273 from Tomás Cohen Arazi --- Created attachment 96545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96545&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #274 from Tomás Cohen Arazi --- Created attachment 96546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96546&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #272 from Tomás Cohen Arazi --- Created attachment 96544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96544&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96447|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96444|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96445|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96442|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96446|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96443|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96440|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96441|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96439|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96437|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96438|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96448|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96450|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96449|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #259 from Agustín Moyano --- Created attachment 96438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96438&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #270 from Agustín Moyano --- Created attachment 96449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96449&action=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #271 from Agustín Moyano --- Created attachment 96450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96450&action=edit Bug 22284: (follow-up) Anotate boolean values in Koha::Schema::Result::LibraryGroup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #267 from Agustín Moyano --- Created attachment 96446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96446&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #268 from Agustín Moyano --- Created attachment 96447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96447&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #265 from Agustín Moyano --- Created attachment 96444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96444&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #269 from Agustín Moyano --- Created attachment 96448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96448&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #262 from Agustín Moyano ---
Created attachment 96441
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96441&action=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Josef Moravec
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #266 from Agustín Moyano --- Created attachment 96445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96445&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #264 from Agustín Moyano --- Created attachment 96443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96443&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #260 from Agustín Moyano --- Created attachment 96439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96439&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #263 from Agustín Moyano --- Created attachment 96442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96442&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #261 from Agustín Moyano --- Created attachment 96440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96440&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #94483|0 |1 is obsolete|| Attachment #94484|0 |1 is obsolete|| Attachment #94485|0 |1 is obsolete|| Attachment #94486|0 |1 is obsolete|| Attachment #94487|0 |1 is obsolete|| Attachment #94488|0 |1 is obsolete|| Attachment #94489|0 |1 is obsolete|| Attachment #94490|0 |1 is obsolete|| Attachment #94491|0 |1 is obsolete|| Attachment #94492|0 |1 is obsolete|| Attachment #94493|0 |1 is obsolete|| Attachment #94494|0 |1 is obsolete|| Attachment #94495|0 |1 is obsolete|| --- Comment #258 from Agustín Moyano --- Created attachment 96437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96437&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #257 from Agustín Moyano --- (In reply to Katrin Fischer from comment #243) > Patch doesn't apply, can you please rebase? > > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 22284: New ft_local_hold_group column, and 'holgroup' enum > option > Applying: Bug 22284: Add new checkbox in Library Groups > Applying: Bug 22284: New hold group options in smart-rules > Applying: Bug 22284: Control hold groups in C4::Reserves > Applying: Bug 22284: New methods in Koha::Library::Groups and Koha::Library > Using index info to reconstruct a base tree... > M Koha/Library.pm > M t/db_dependent/Koha/Libraries.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Koha/Libraries.t > CONFLICT (content): Merge conflict in t/db_dependent/Koha/Libraries.t > Auto-merging Koha/Library.pm > CONFLICT (content): Merge conflict in Koha/Library.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 22284: New methods in Koha::Library::Groups and > Koha::Library > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in > /tmp/Bug-22284-New-methods-in-KohaLibraryGroups-and-Koh-yTz2MT.patch Patches rebased! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #256 from Agustín Moyano --- Created attachment 94495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94495&action=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #253 from Agustín Moyano --- Created attachment 94492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94492&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #252 from Agustín Moyano --- Created attachment 94491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94491&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #250 from Agustín Moyano --- Created attachment 94489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94489&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #255 from Agustín Moyano --- Created attachment 94494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94494&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #254 from Agustín Moyano --- Created attachment 94493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94493&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #245 from Agustín Moyano --- Created attachment 94484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94484&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #251 from Agustín Moyano --- Created attachment 94490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94490&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #249 from Agustín Moyano --- Created attachment 94488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94488&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #248 from Agustín Moyano ---
Created attachment 94487
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94487&action=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Josef Moravec
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #247 from Agustín Moyano --- Created attachment 94486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94486&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #246 from Agustín Moyano --- Created attachment 94485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94485&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #92849|0 |1 is obsolete|| Attachment #92850|0 |1 is obsolete|| Attachment #92851|0 |1 is obsolete|| Attachment #92852|0 |1 is obsolete|| Attachment #92853|0 |1 is obsolete|| Attachment #92854|0 |1 is obsolete|| Attachment #92855|0 |1 is obsolete|| Attachment #92856|0 |1 is obsolete|| Attachment #92857|0 |1 is obsolete|| Attachment #92858|0 |1 is obsolete|| Attachment #92859|0 |1 is obsolete|| Attachment #92860|0 |1 is obsolete|| Attachment #92861|0 |1 is obsolete|| --- Comment #244 from Agustín Moyano --- Created attachment 94483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94483&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #243 from Katrin Fischer --- Patch doesn't apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option Applying: Bug 22284: Add new checkbox in Library Groups Applying: Bug 22284: New hold group options in smart-rules Applying: Bug 22284: Control hold groups in C4::Reserves Applying: Bug 22284: New methods in Koha::Library::Groups and Koha::Library Using index info to reconstruct a base tree... M Koha/Library.pm M t/db_dependent/Koha/Libraries.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Libraries.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Libraries.t Auto-merging Koha/Library.pm CONFLICT (content): Merge conflict in Koha/Library.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 22284: New methods in Koha::Library::Groups and Koha::Library The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22284-New-methods-in-KohaLibraryGroups-and-Koh-yTz2MT.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #241 from Liz Rea --- Created attachment 92860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92860&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92759|0 |1 is obsolete|| --- Comment #237 from Liz Rea --- Created attachment 92856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92856&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92764|0 |1 is obsolete|| --- Comment #242 from Liz Rea --- Created attachment 92861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92861&action=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92762|0 |1 is obsolete|| --- Comment #240 from Liz Rea --- Created attachment 92859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92859&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92761|0 |1 is obsolete|| Attachment #92763|0 |1 is obsolete|| --- Comment #239 from Liz Rea --- Created attachment 92858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92858&action=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92760|0 |1 is obsolete|| --- Comment #238 from Liz Rea --- Created attachment 92857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92857&action=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
Liz Rea changed:
What|Removed |Added
Attachment #92756|0 |1
is obsolete||
--- Comment #234 from Liz Rea ---
Created attachment 92853
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92853&action=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Josef Moravec
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92758|0 |1 is obsolete|| --- Comment #236 from Liz Rea --- Created attachment 92855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92855&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92757|0 |1 is obsolete|| --- Comment #235 from Liz Rea --- Created attachment 92854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92854&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea changed: What|Removed |Added Attachment #92755|0 |1 is obsolete|| --- Comment #233 from Liz Rea --- Created attachment 92852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92852&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
