[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343
--- Comment #212 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #211)
> (In reply to Tomás Cohen Arazi from comment #210)
> > (In reply to Jonathan Druart from comment #188)
> > > Created attachment 111088 [details] [review] [review] [review]
> > > Bug 22343: Correctly handle password on editing
> >
> > My idea was to entirely not pass the password to the template, and only
> > write it on change.
>
> Ho right. So maybe we should pass a "password_set" boolean instead?
Well, it will be the same. We pass it to the template but we don't display it
actually ("" is displayed).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #211 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #210) > (In reply to Jonathan Druart from comment #188) > > Created attachment 111088 [details] [review] [review] > > Bug 22343: Correctly handle password on editing > > My idea was to entirely not pass the password to the template, and only > write it on change. Ho right. So maybe we should pass a "password_set" boolean instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #210 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #188) > Created attachment 111088 [details] [review] > Bug 22343: Correctly handle password on editing My idea was to entirely not pass the password to the template, and only write it on change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #209 from Jonathan Druart --- Last patches pushed to master! ab2760e7e4 Bug 22343: Remove traces of libmail-sendmail-perl a3a2c4cfff Bug 22343: (follow-up) Remove traces of Mail::Sendmail - update POD 704a053791 Bug 22343: (follow-up) Remove traces of Mail::Sendmail 04f2ecb56c Bug 22343: (follow-up) Make sure no invalid address is used in tests c54da79431 Bug 22343: Add exec flag on .t files b9a63feb73 Bug 22343: Compiled CSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #208 from Jonathan Druart --- Created attachment 111216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111216=edit Bug 22343: Remove traces of libmail-sendmail-perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #207 from Jonathan Druart --- Created attachment 111215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111215=edit Bug 22343: (follow-up) Remove traces of Mail::Sendmail - update POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What|Removed |Added Attachment #66|0 |1 is obsolete|| --- Comment #206 from Jonathan Druart --- Created attachment 111213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111213=edit Bug 22343: Add exec flag on .t files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #205 from Tomás Cohen Arazi --- Created attachment 76 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76=edit Bug 22343: (follow-up) Remove traces of Mail::Sendmail Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #204 from Tomás Cohen Arazi --- Created attachment 75 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75=edit Bug 22343: (follow-up) Make sure no invalid address is used in tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #203 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #200) > t/db_dependent/Passwordrecovery.t is failing, please fix ASAP I have a fix for the tests. But I will take some more time to check we are not hiding a broader problem by fixing them. There is a behaviour change if things fail because branchemail and branchreplyto are not set. I will file a separate bug for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #201 from Jonathan Druart --- Created attachment 65 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65=edit Bug 22343: Compiled CSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #202 from Jonathan Druart --- Created attachment 66 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66=edit Bug 22343: Add exec flag on .t files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What|Removed |Added Keywords|dependency |additional_work_needed --- Comment #200 from Jonathan Druart --- t/db_dependent/Passwordrecovery.t is failing, please fix ASAP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #199 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #198 from Jonathan Druart --- Created attachment 54 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54=edit Bug 22343: Fix runreport encoding issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #197 from Jonathan Druart --- There is an encoding issue with runreport.pl, can you double check please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #196 from Jonathan Druart --- (In reply to Jonathan Druart from comment #191) > Created attachment 111089 [details] [review] > Bug 22343: Display the correct default values on the admin page > > The "Default configuration" section at the top of the SMTP servers admin page > contains the hardcoded values in Koha::SMTP::Servers->default_setting. > > It should be the values from the config (and default to hardcoded values > unless defined) Moved to bug 26290. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What|Removed |Added Attachment #111089|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #195 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #190) > (In reply to Jonathan Druart from comment #189) > > The "Default configuration" section at the top of the SMTP servers admin > > page contains the hardcoded values in Koha::SMTP::Servers->default_setting. > > > > Should not it be the values from the config (and default to hardcoded values > > unless defined)? > > That is done on the follow-up bug. Yes, the question (and my follow-up) is for bug 26290. I am reviewing them together. (In reply to Tomás Cohen Arazi from comment #194) > (In reply to Jonathan Druart from comment #193) > > 232 Actions > > > > Where is this data-class-name coming from? How it is useful? > > https://datatables.net/manual/options#HTML-5-data-attributes Yes but how is it useful? Is it just a matter of having a class on the "Actions" column or is there a CSS or any related code using it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #194 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #193) > 232 Actions > > Where is this data-class-name coming from? How it is useful? https://datatables.net/manual/options#HTML-5-data-attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #193 from Jonathan Druart --- 232 Actions Where is this data-class-name coming from? How it is useful? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #192 from Jonathan Druart --- Created attachment 111090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111090=edit Bug 22343: Add the 'required' class when needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #191 from Jonathan Druart --- Created attachment 111089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111089=edit Bug 22343: Display the correct default values on the admin page The "Default configuration" section at the top of the SMTP servers admin page contains the hardcoded values in Koha::SMTP::Servers->default_setting. It should be the values from the config (and default to hardcoded values unless defined) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #190 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #189) > The "Default configuration" section at the top of the SMTP servers admin > page contains the hardcoded values in Koha::SMTP::Servers->default_setting. > > Should not it be the values from the config (and default to hardcoded values > unless defined)? That is done on the follow-up bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #189 from Jonathan Druart --- The "Default configuration" section at the top of the SMTP servers admin page contains the hardcoded values in Koha::SMTP::Servers->default_setting. Should not it be the values from the config (and default to hardcoded values unless defined)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #188 from Jonathan Druart --- Created attachment 111088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111088=edit Bug 22343: Correctly handle password on editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #187 from Jonathan Druart --- Created attachment 111087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111087=edit Bug 22343: Add warning to the about page if KohaAdminEmailAddress is invalid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 [Bug 26595] Add SMTP server column to libraries table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #186 from Tomás Cohen Arazi --- Created attachment 111048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111048=edit Bug 22343: (QA follow-up) Wrap email creation inside the try/catch block At a later development stage, exceptions where added for bad addresses. This wasn't addressed in the controllers. This patch makes the basket and list sending controller scripts move email creation inside the try/catch block to handle those situations. It also UTF-8 encodes the attached marc. On broadly testing this I found that if the TT templates that are used to build the email contains non-latin characters, those get double-encoded. So this patch also removes an explicit encoding that is done, which colides with Email::MIME implicit encoding. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #185 from Jonathan Druart --- Found another one: Replace KohaAdminEmailAddress with r...@example.org Send a basket (use '❤' in biblio title and "comment" of the email) Wide character in subroutine entry at /usr/share/perl5/Email/MIME/Encodings.pm line 55 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #184 from Jonathan Druart --- Found a 500: Apply patches, updatedatabase, nothing else. Send a basket (OPAC): Invalid 'from' parameter: root@localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #183 from Martin Renvoize --- Seems I forgot to set PQA on this.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #182 from Martin Renvoize --- Created attachment 109788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109788=edit Bug 22343: (follow-up) Add a hint to the debug form option This patch appends a small note to the debug form field in the edit/add smtp server form to hint that debug mode results in additional output in the logs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #181 from Martin Renvoize --- Created attachment 109787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109787=edit Bug 22343: (follow-up) Highlight debug mode enabled This patch adds a debug class to a row if debug mode is enabled for the smtp server and adds css rules to highlight the row by setting the test to bold, red and italic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #180 from Tomás Cohen Arazi --- Hi! (In reply to Martin Renvoize from comment #179) > This code looks great and I'm happy to SO as is (with the couple of very > minor followups I've added). Thanks for the extensive review! > I have a few points/questions/suggestions > > * You introduce a 'debug' mode you can set at the smtp server level.. I like > this, but at present I can't see any references to it anywhere.. it would be > nice to see it used to enable/disable additional logging in at least one > place with this patchset to give it a purpose and example of use. The debug flag is actually passed to Email::Sender::Transport::SMTP, and enables verbose logging to STDERR, so I expect logs to show in warnings. I tried it with process_message_queue.pl and it will print the whole SMTP authentication handshake and transaction steps including return codes. It is really helpful for debugging authentication issues. I'd say we should add a 'hint' on the edit page. > * With the above debug mode, I'd like to see that state somehow highlighted > in the smtp-servers page table if it's enabled (so it's obvious to an admin > when it's turned on) (bold/italic row perhaps, similar to the 'default' > hinting in cash registers) Will try to add a follow-up for this. > * Final note about the debug mode.. it would be awesome as a later followup > to expose a 'Send test mail' action into the smpt servers table to allow the > immediate send of a test mail from that server with defaults set for > from/replyo etc. I love the idea. Would add it to the edit page as it would be handy to have there for tweaking things in-place if something fails. Definitely a separate bug report. > * It would be nice to see a list of attached branches as one fo the columns > in the smtp servers table. > * Should deletes be blocked/warned about if the smtp server is being > utilised by any libraries? > * The 'delete' was slow for me, which meant I could easily double submit the > modal form (we should prevent the double submit) > > * It would be nice to add the smtp server name as an optional column to > display in the libraries table. I'll file a new report for this as it requires some (incremental) tweaking to the libraries route. > * Another enhancement for the future would be to support library groups Good idea! > Generally, I really like this and it's a huge improvement. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #179 from Martin Renvoize --- This code looks great and I'm happy to SO as is (with the couple of very minor followups I've added). I have a few points/questions/suggestions * You introduce a 'debug' mode you can set at the smtp server level.. I like this, but at present I can't see any references to it anywhere.. it would be nice to see it used to enable/disable additional logging in at least one place with this patchset to give it a purpose and example of use. * With the above debug mode, I'd like to see that state somehow highlighted in the smtp-servers page table if it's enabled (so it's obvious to an admin when it's turned on) (bold/italic row perhaps, similar to the 'default' hinting in cash registers) * Final note about the debug mode.. it would be awesome as a later followup to expose a 'Send test mail' action into the smpt servers table to allow the immediate send of a test mail from that server with defaults set for from/replyo etc. * It would be nice to see a list of attached branches as one fo the columns in the smtp servers table. * Should deletes be blocked/warned about if the smtp server is being utilised by any libraries? * The 'delete' was slow for me, which meant I could easily double submit the modal form (we should prevent the double submit) * It would be nice to add the smtp server name as an optional column to display in the libraries table. * Another enhancement for the future would be to support library groups Generally, I really like this and it's a huge improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #177 from Martin Renvoize --- Created attachment 109739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109739=edit Bug 22343: (QA follow-up) Ensure FK names don't conflict Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #178 from Martin Renvoize --- Created attachment 109740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109740=edit Bug 22343: (QA follow-up) Fix some comments Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109616|0 |1 is obsolete|| --- Comment #176 from Martin Renvoize --- Created attachment 109738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109738=edit Bug 22343: Allow choosing an SMTP server in branches.pl The missing piece on this patchset is choosing the desired SMTP server for each library. This patch adds the option on editing the library. The default one is picked for existing libraries, and you can pick the one you want. To test: 1. Apply the patchset 2. Run: $ updatedatabase => SUCCESS: Things go smooth 3. Notice the new permission for managing SMTP servers 4. Notice the entry in the admin page 5. Add/have a few SMTP servers defined. 6. Edit a library => SUCCESS: The 'Default' SMTP server is picked 7. Choose any server and save => SUCCESS: Saving doesn't explode 8. Edit the server => SUCCESS: Your selection is kept (this can also be checked on the DB, the library_smtp_server table) 9. Try (7) with many different options => SUCCESS: It works 10. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109613|0 |1 is obsolete|| --- Comment #173 from Martin Renvoize --- Created attachment 109735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109735=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Also the syntax for Koha::Email has changed and this patch adapts it. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109612|0 |1 is obsolete|| --- Comment #172 from Martin Renvoize --- Created attachment 109734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109734=edit Bug 22343: Adapt Koha::Illrequest This patch makes Koha::Illrequest use the new syntax for Koha::Email and sending the email. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109611|0 |1 is obsolete|| --- Comment #171 from Martin Renvoize --- Created attachment 109733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109733=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109615|0 |1 is obsolete|| --- Comment #175 from Martin Renvoize --- Created attachment 109737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109737=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109614|0 |1 is obsolete|| --- Comment #174 from Martin Renvoize --- Created attachment 109736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109736=edit Bug 22343: Adapt runreport.pl This script gets adapted to use the new Koha::Email syntax and SMTP transport. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109606|0 |1 is obsolete|| --- Comment #166 from Martin Renvoize --- Created attachment 109728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109728=edit Bug 22343: Add Koha::Library->smtp_server Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109610|0 |1 is obsolete|| --- Comment #170 from Martin Renvoize --- Created attachment 109732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109732=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109608|0 |1 is obsolete|| --- Comment #168 from Martin Renvoize --- Created attachment 109730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109730=edit Bug 22343: API routes for SMTP servers CRUD This patch introduces API routes for handling SMTP servers. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109605|0 |1 is obsolete|| --- Comment #165 from Martin Renvoize --- Created attachment 109727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109727=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109607|0 |1 is obsolete|| --- Comment #167 from Martin Renvoize --- Created attachment 109729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109729=edit Bug 22343: Update cpanfile Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109609|0 |1 is obsolete|| --- Comment #169 from Martin Renvoize --- Created attachment 109731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109731=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109603|0 |1 is obsolete|| --- Comment #163 from Martin Renvoize --- Created attachment 109725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109725=edit Bug 22343: Add new tables schema file Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109602|0 |1 is obsolete|| --- Comment #162 from Martin Renvoize --- Created attachment 109724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109724=edit Bug 22343: Add parameters => manage_smtp_servers subpermission This patch introduces a new subpermission for managing SMTP servers, for granularity. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109601|0 |1 is obsolete|| --- Comment #161 from Martin Renvoize --- Created attachment 109723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109723=edit Bug 22343: Add a new table to store SMTP servers configs This patch adds a new table to store SMTP servers configs. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Martin Renvoize changed: What|Removed |Added Attachment #109604|0 |1 is obsolete|| --- Comment #164 from Martin Renvoize --- Created attachment 109726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109726=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #160 from Kyle M Hall --- Created attachment 109616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109616=edit Bug 22343: Allow choosing an SMTP server in branches.pl The missing piece on this patchset is choosing the desired SMTP server for each library. This patch adds the option on editing the library. The default one is picked for existing libraries, and you can pick the one you want. To test: 1. Apply the patchset 2. Run: $ updatedatabase => SUCCESS: Things go smooth 3. Notice the new permission for managing SMTP servers 4. Notice the entry in the admin page 5. Add/have a few SMTP servers defined. 6. Edit a library => SUCCESS: The 'Default' SMTP server is picked 7. Choose any server and save => SUCCESS: Saving doesn't explode 8. Edit the server => SUCCESS: Your selection is kept (this can also be checked on the DB, the library_smtp_server table) 9. Try (7) with many different options => SUCCESS: It works 10. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #159 from Kyle M Hall --- Created attachment 109615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109615=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #158 from Kyle M Hall --- Created attachment 109614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109614=edit Bug 22343: Adapt runreport.pl This script gets adapted to use the new Koha::Email syntax and SMTP transport. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #157 from Kyle M Hall --- Created attachment 109613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109613=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Also the syntax for Koha::Email has changed and this patch adapts it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #156 from Kyle M Hall --- Created attachment 109612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109612=edit Bug 22343: Adapt Koha::Illrequest This patch makes Koha::Illrequest use the new syntax for Koha::Email and sending the email. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #155 from Kyle M Hall --- Created attachment 109611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109611=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #153 from Kyle M Hall --- Created attachment 109609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109609=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #152 from Kyle M Hall --- Created attachment 109608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109608=edit Bug 22343: API routes for SMTP servers CRUD This patch introduces API routes for handling SMTP servers. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #151 from Kyle M Hall --- Created attachment 109607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109607=edit Bug 22343: Update cpanfile Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #150 from Kyle M Hall --- Created attachment 109606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109606=edit Bug 22343: Add Koha::Library->smtp_server Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #154 from Kyle M Hall --- Created attachment 109610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109610=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #147 from Kyle M Hall --- Created attachment 109603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109603=edit Bug 22343: Add new tables schema file Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #148 from Kyle M Hall --- Created attachment 109604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109604=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #149 from Kyle M Hall --- Created attachment 109605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109605=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #146 from Kyle M Hall --- Created attachment 109602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109602=edit Bug 22343: Add parameters => manage_smtp_servers subpermission This patch introduces a new subpermission for managing SMTP servers, for granularity. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Kyle M Hall changed: What|Removed |Added Attachment #109155|0 |1 is obsolete|| Attachment #109156|0 |1 is obsolete|| Attachment #109157|0 |1 is obsolete|| Attachment #109158|0 |1 is obsolete|| Attachment #109159|0 |1 is obsolete|| Attachment #109160|0 |1 is obsolete|| Attachment #109161|0 |1 is obsolete|| Attachment #109162|0 |1 is obsolete|| Attachment #109163|0 |1 is obsolete|| Attachment #109164|0 |1 is obsolete|| Attachment #109165|0 |1 is obsolete|| Attachment #109166|0 |1 is obsolete|| Attachment #109167|0 |1 is obsolete|| Attachment #109168|0 |1 is obsolete|| Attachment #109169|0 |1 is obsolete|| Attachment #109170|0 |1 is obsolete|| --- Comment #145 from Kyle M Hall --- Created attachment 109601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109601=edit Bug 22343: Add a new table to store SMTP servers configs This patch adds a new table to store SMTP servers configs. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #144 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #122) > TODO (separate bugs): > - Ability to set a default other than the hardcoded one, in koha-conf.xml Submitted to bug 26290. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #143 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #126) > Why using warnings_exist instead of warning_is in the tests? That's a left over from a previous iteration. Fixed! And thanks for pointing it out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #142 from Tomás Cohen Arazi --- Created attachment 109170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109170=edit Bug 22343: Allow choosing an SMTP server in branches.pl The missing piece on this patchset is choosing the desired SMTP server for each library. This patch adds the option on editing the library. The default one is picked for existing libraries, and you can pick the one you want. To test: 1. Apply the patchset 2. Run: $ updatedatabase => SUCCESS: Things go smooth 3. Notice the new permission for managing SMTP servers 4. Notice the entry in the admin page 5. Add/have a few SMTP servers defined. 6. Edit a library => SUCCESS: The 'Default' SMTP server is picked 7. Choose any server and save => SUCCESS: Saving doesn't explode 8. Edit the server => SUCCESS: Your selection is kept (this can also be checked on the DB, the library_smtp_server table) 9. Try (7) with many different options => SUCCESS: It works 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #141 from Tomás Cohen Arazi --- Created attachment 109169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109169=edit Bug 22343: Prevent passing password to the UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #137 from Tomás Cohen Arazi --- Created attachment 109165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109165=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #140 from Tomás Cohen Arazi --- Created attachment 109168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109168=edit Bug 22343: Adapt runreport.pl This script gets adapted to use the new Koha::Email syntax and SMTP transport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #138 from Tomás Cohen Arazi --- Created attachment 109166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109166=edit Bug 22343: Adapt Koha::Illrequest This patch makes Koha::Illrequest use the new syntax for Koha::Email and sending the email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #139 from Tomás Cohen Arazi --- Created attachment 109167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109167=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Also the syntax for Koha::Email has changed and this patch adapts it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #136 from Tomás Cohen Arazi --- Created attachment 109164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109164=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #135 from Tomás Cohen Arazi --- Created attachment 109163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109163=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #132 from Tomás Cohen Arazi --- Created attachment 109160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109160=edit Bug 22343: Add Koha::Library->smtp_server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #134 from Tomás Cohen Arazi --- Created attachment 109162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109162=edit Bug 22343: API routes for SMTP servers CRUD This patch introduces API routes for handling SMTP servers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #131 from Tomás Cohen Arazi --- Created attachment 109159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109159=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #133 from Tomás Cohen Arazi --- Created attachment 109161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109161=edit Bug 22343: Update cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #129 from Tomás Cohen Arazi --- Created attachment 109157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109157=edit Bug 22343: Add new tables schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #128 from Tomás Cohen Arazi --- Created attachment 109156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109156=edit Bug 22343: Add parameters => manage_smtp_servers subpermission This patch introduces a new subpermission for managing SMTP servers, for granularity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #130 from Tomás Cohen Arazi --- Created attachment 109158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109158=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #127 from Tomás Cohen Arazi --- Created attachment 109155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109155=edit Bug 22343: Add a new table to store SMTP servers configs This patch adds a new table to store SMTP servers configs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109016|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109017|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109015|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109018|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109013|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #109010|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
