[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Philip Orr changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/855 --- Comment #79 from Philip Orr --- Documented and now in the manual. Seeing as the test plan only relates to the stock rotation automation tool and the report is only shown when stock rotation automation tool is in use, I think the text to go in the release notes is misleading: "...lists all items that are set to transfer but not yet in transit" Well, it wouldn't list all items - only those in a stock rotation rota that are requested from your library. Correct me if I'm wrong or out of line here. Might be personal preference, but I also feel the report name itself is a little misleading as I would expect it to list all transfers, e.g. holds requested to be sent to a different library as well. Maybe something like "Stock rotation requests to send" would be better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Philip Orr changed: What|Removed |Added CC||[email protected] Documentation||Philip Orr contact|| Status|CLOSED |Needs documenting Resolution|FIXED |--- --- Comment #78 from Philip Orr --- Assigning myself to documenting this as I was recently confused by it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Fridolin Somers changed: What|Removed |Added Blocks||35389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35389 [Bug 35389] Hide 'Transfers to send' on circulation home page when stock rotation is disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #77 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #76) > I found this report after breaking my head about how to add transfers > without a date sent ;) Added two reports to lower possible confusion. Bug 35388 and bug 35389. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35389 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35388 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #76 from Marcel de Rooy --- I found this report after breaking my head about how to add transfers without a date sent ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Marcel de Rooy changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #75 from Katrin Fischer --- (In reply to mathieu saby from comment #74) > Hi > > I don't find a description of this feature in Koha Manual. Is it described > somewhere? It still has the keyword Manual, so it might not have been documented yet. The team removes it once that has been done. The page is relate to the stock rotation tool that is described. I think before the page was added you got an email to alert you about items that needed progressing, but now the report can be used as well. Martin might be able to explain more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 mathieu saby changed: What|Removed |Added CC||[email protected] --- Comment #74 from mathieu saby --- Hi I don't find a description of this feature in Koha Manual. Is it described somewhere? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks|25753 |22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m --- Comment #73 from Fridolin Somers --- New feature not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks|22160 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #72 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #71 from Katrin Fischer --- I think we should use this report to advertise on the hard work that has gone into cleaning up the transfers code that has led up to here :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117848|0 |1 is obsolete|| --- Comment #70 from Katrin Fischer --- Created attachment 117881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117881&action=edit Bug 22569: (QA follow-up) Use itemtype description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117847|0 |1 is obsolete|| --- Comment #69 from Katrin Fischer --- Created attachment 117880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117880&action=edit Bug 22569: (QA follow-up) Make 'reason' translatable Add a transfer_reasons include file for easy translation of the transer reason codes. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117613|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 117879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117879&action=edit Bug 22569: Add Unit Tests Test plan: 1/ Run the updated unit tests Signed-off-by: Kathleen Milne Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117612|0 |1 is obsolete|| --- Comment #67 from Katrin Fischer --- Created attachment 117878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117878&action=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer but not marked as sent. Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appear in the new 'Transfers to send' page. 4) Confirm that items marked with 'StockRotationAdvance' provide the option to mark the item as 'In demand' (Which will cancel the transfer and mark the item as in demand such that it will wait at the current branch for an additional stage period before being automatically picke for transfer again) 5) Setup a rotating collection 6) Trigger a collection transfer for the above collection 7) Check that the expected items appear in the new 'Transfers to send' page'. Signed-off-by: Kathleen Milne Bug 22569: (QA follow-up) Rename script to snake_case As requested, we simply rename the script, and references to it, to use snake_case to make it clearer. Bug 22569: (QA follow-up) Rename branchesloop to libraries Bug 22569: (QA follow-up) Fix indentation in template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117843|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 117848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117848&action=edit Bug 22569: (QA follow-up) Use itemtype description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117842|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 117847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117847&action=edit Bug 22569: (QA follow-up) Make 'reason' translatable Add a transfer_reasons include file for easy translation of the transer reason codes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #64 from Katrin Fischer --- I think you fell of IRC, so asking here: I am happy with the translations patch now, but can you explain how Hold lost can come to be? If I mark an item lost... how can it be in transfer? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117841|0 |1 is obsolete|| --- Comment #63 from Martin Renvoize --- Created attachment 117843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117843&action=edit Bug 22569: (QA follow-up) Use itemtype description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117840|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 117842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117842&action=edit Bug 22569: (QA follow-up) Make 'reason' translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #61 from Martin Renvoize --- Created attachment 117841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117841&action=edit Bug 22569: (QA follow-up) Use itemtype description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #60 from Martin Renvoize --- Created attachment 117840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117840&action=edit Bug 22569: (QA follow-up) Make 'reason' translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer --- 2) Please also show the item type description instead of the code to keep consistent with our other displays: +[% IF ( transfer.item.effective_itemtype ) %] ([% transfer.item.effective_itemtype | html %])[% END %] Otherwise this appears to work very well and I feel it's close to PQA. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #58 from Katrin Fischer --- 1) I notice that the reason in the table appears to be taken directly from the database. "AdvanceStockRotation" is not easy to understand untranslated. Can you please deal with this in the template? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||'Transfers to send' report ||to the circulation module. || ||This is a parallel for the ||'Transfers to receive' ||report and lists all items ||that are set to transfer ||but not yet in transit ||(along with their transfer ||reason and whether they're ||available to be picked from ||the shelves or currently ||checked out). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Keywords||Manual Text to go in the|This enhancement adds a | release notes|'Transfers to send' report | |to the circulation module. | || |This is a parallel for the | |'Transfers to receive' | |report and lists all items | |that are set to transfer| |but not yet in transit | |(along with their transfer | |reason and whether they're | |available to be picked from | |the shelves or currently| |checked out). | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||'Transfers to send' report ||to the circulation module. || ||This is a parallel for the ||'Transfers to receive' ||report and lists all items ||that are set to transfer ||but not yet in transit ||(along with their transfer ||reason and whether they're ||available to be picked from ||the shelves or currently ||checked out). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #57 from Jonathan Druart --- Created attachment 117613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117613&action=edit Bug 22569: Add Unit Tests Test plan: 1/ Run the updated unit tests Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Jonathan Druart changed: What|Removed |Added Attachment #116572|0 |1 is obsolete|| Attachment #116573|0 |1 is obsolete|| --- Comment #56 from Jonathan Druart --- Created attachment 117612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117612&action=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer but not marked as sent. Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appear in the new 'Transfers to send' page. 4) Confirm that items marked with 'StockRotationAdvance' provide the option to mark the item as 'In demand' (Which will cancel the transfer and mark the item as in demand such that it will wait at the current branch for an additional stage period before being automatically picke for transfer again) 5) Setup a rotating collection 6) Trigger a collection transfer for the above collection 7) Check that the expected items appear in the new 'Transfers to send' page'. Signed-off-by: Kathleen Milne Bug 22569: (QA follow-up) Rename script to snake_case As requested, we simply rename the script, and references to it, to use snake_case to make it clearer. Bug 22569: (QA follow-up) Rename branchesloop to libraries Bug 22569: (QA follow-up) Fix indentation in template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #55 from Martin Renvoize --- Thanks for clarifying.. couldn't see the wood for the trees.. Followups pushed to branch to deal with both issues :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
--- Comment #54 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #53)
> (In reply to Jonathan Druart from comment #46)
> > 7. There are some indentation inconsistencies in circ/transferstosend.tt
>
> Not sure I'm seeing the same thing you are.. need a bit of clarification
69
70 [% END %]
71 [% END %]
72
73
74 [% END %]
75 [% END %]
76
77 [% ELSE %]
78 No transfers to send
79 [% END %]
> > 8. (not blocker) transferCollection.tt
> > +[%- SWITCH message.type -%]
> > +[%- CASE 'failure' %]
> > ...
> > +[%- CASE 'enqueu' -%]
> >
> > The usual pattern is
> > push @message,
> > {
> > type => 'error', # or message
> > code => 'enqueu(ed?)',
> > %more_variables
> > }
>
> Struggling to find an example.. happy to change but struggling to understand
> the minute
% git grep 'push @messages'
will return a lot of examples :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
--- Comment #53 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #46)
> 5. in circ/transferstosend.pl
> +show_date=> output_pref(
>
> +{ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }
> +)
>
> I'd pass {today => dt_from_string}, it should be enough.
Done in followup on branch
> 6. in circ/transferstosend.tt
> [% FOREACH branchesloo IN branchesloop %]
>
> should be
> [% FOREACH library IN libraries %]
Done in followup on branch
> 7. There are some indentation inconsistencies in circ/transferstosend.tt
Not sure I'm seeing the same thing you are.. need a bit of clarification
> 8. (not blocker) transferCollection.tt
> +[%- SWITCH message.type -%]
> +[%- CASE 'failure' %]
> ...
> +[%- CASE 'enqueu' -%]
>
> The usual pattern is
> push @message,
> {
> type => 'error', # or message
> code => 'enqueu(ed?)',
> %more_variables
> }
Struggling to find an example.. happy to change but struggling to understand
the minute
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #52 from Martin Renvoize --- Updated the branch attached to the merge request here: https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #51 from Martin Renvoize --- (In reply to Jonathan Druart from comment #44) > Is this store call needed? > > +$self->stage_id($new_stage->stage_id)->store;# Revert > stage change > > There are also several places in the tests where ->store calls are > unnecessary. Corrected for the 'advance' method in StockRotationItem.. looks like there's a few places in SR this could be done.. mostly these predate this tree but I'm happy to fix them inline as followups to 24446 if you prefer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #50 from Martin Renvoize --- (In reply to Jonathan Druart from comment #45) > Shouldn't we start with a good script/template name? > transferstosend.pl => transfers_to_send.pl More than happy for that change.. I was just being consistent with the existing 'transferstoreceive.pl' naming, but certainly, prefer snake_case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #49 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > 3. Shouldn't Koha::Exceptions::Item::Transfer::Found be actually > Koha::Exceptions::Item::Transfer::AlreadyInTransfer, to be more explicit? > > 4. Same, should we make Koha::Exceptions::Item::Transfer::Limit more > explicit? > Its description is "Transfer not allowed" but it seems that we can make it > more exact. I've come up with the followup alternatives.. but I'm struggling for the 'Limit' case. ::Found -> ::InQueue ::Transit -> ::InTransit ::Out -> ::OnLoan ::Limit -> ? # This is when the branch transfer limits would ordinarily prevent transfer.. ::BreaksLimits, ::NotAllowed, ::Dissallowed ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
--- Comment #48 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #46)
> 2.
> -my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber
> );
> +my $transfer = $item->get_transfer;
>
> This GetTransfers is pretty bad, it could return several transfers, but
> callers are not ready for that:
> opac/opac-detail.pl: my ( $transfertwhen, $transfertfrom, $transfertto )
> = GetTransfers($itm->{itemnumber});
>
>
> So that's definitely a good move to have a get_transfer method that will
> return only 1, the current one.
> However, cannot we enforce this constraint at DB level (DB unique key) and
> have a ->find call in ->get_transfer to replace the ->first?
Internally '->find' theoretically checks for constraints (Unique, Primary Key,
etc).. if it doesn't find any, it falls back to search and throws an error if
more than one row is found.. So in reality one would need to pass the order_by
and rows attributes to get the correct single row.. So in effect they're the
code results in the same thing...
As for adding a unique constraint at the DB... I can't see what constraint
would work here... We're looking for the first with 'datesent' OR if there
isn't a sent one, then the oldest 'daterequested'..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
--- Comment #47 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #46)
> Adding here some notes about the dependent tree (I've squashed the whole
> tree for pre-review):
>
> 1.
> -$messages->{'WasTransfered'} = 1;
> +$messages->{'WasTransfered'} = $tbr;
>
> but
>
> t/db_dependent/SIP/Transaction.t:is_deeply($result,{ messages => {
> 'NotIssued' => $item->barcode, 'WasTransfered' => 1 } },"Messages show not
> issued and transferred");
>
> So I ran the tests and there is a failure:
>
> # Failed test 'Messages show not issued and transferred'
> # at t/db_dependent/SIP/Transaction.t line 327.
> # Structures begin differing at:
> # $got->{messages}{TransferTrigger} = 'ReturnToHome'
> # $expected->{messages}{TransferTrigger} = Does not exist
> # Looks like you planned 5 tests but ran 2.
Fixed on the gitlab branch: Two follow-ups on bug 24446, the first fixes the
test above by adding the 'TransferTrigger' into the is_deeply comparison. I've
checked in SIP and the message is silently ignored further down the call chain.
Second follow-up fixes a logical issue that was highlighted by the new test
that was introduced since I wrote the code.. nice catch :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
--- Comment #46 from Jonathan Druart
---
Adding here some notes about the dependent tree (I've squashed the whole tree
for pre-review):
1.
-$messages->{'WasTransfered'} = 1;
+$messages->{'WasTransfered'} = $tbr;
but
t/db_dependent/SIP/Transaction.t:is_deeply($result,{ messages => {
'NotIssued' => $item->barcode, 'WasTransfered' => 1 } },"Messages show not
issued and transferred");
So I ran the tests and there is a failure:
# Failed test 'Messages show not issued and transferred'
# at t/db_dependent/SIP/Transaction.t line 327.
# Structures begin differing at:
# $got->{messages}{TransferTrigger} = 'ReturnToHome'
# $expected->{messages}{TransferTrigger} = Does not exist
# Looks like you planned 5 tests but ran 2.
2.
-my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber );
+my $transfer = $item->get_transfer;
This GetTransfers is pretty bad, it could return several transfers, but callers
are not ready for that:
opac/opac-detail.pl: my ( $transfertwhen, $transfertfrom, $transfertto ) =
GetTransfers($itm->{itemnumber});
So that's definitely a good move to have a get_transfer method that will return
only 1, the current one.
However, cannot we enforce this constraint at DB level (DB unique key) and have
a ->find call in ->get_transfer to replace the ->first?
3. Shouldn't Koha::Exceptions::Item::Transfer::Found be actually
Koha::Exceptions::Item::Transfer::AlreadyInTransfer, to be more explicit?
4. Same, should we make Koha::Exceptions::Item::Transfer::Limit more explicit?
Its description is "Transfer not allowed" but it seems that we can make it more
exact.
5. in circ/transferstosend.pl
+show_date=> output_pref(
+{ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }
+)
I'd pass {today => dt_from_string}, it should be enough.
6. in circ/transferstosend.tt
[% FOREACH branchesloo IN branchesloop %]
should be
[% FOREACH library IN libraries %]
7. There are some indentation inconsistencies in circ/transferstosend.tt
8. (not blocker) transferCollection.tt
+[%- SWITCH message.type -%]
+[%- CASE 'failure' %]
...
+[%- CASE 'enqueu' -%]
The usual pattern is
push @message,
{
type => 'error', # or message
code => 'enqueu(ed?)',
%more_variables
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #45 from Jonathan Druart --- Shouldn't we start with a good script/template name? transferstosend.pl => transfers_to_send.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #44 from Jonathan Druart --- Is this store call needed? +$self->stage_id($new_stage->stage_id)->store;# Revert stage change There are also several places in the tests where ->store calls are unnecessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Patch complexity|Large patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #43 from Martin Renvoize --- Created attachment 116573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116573&action=edit Bug 22569: Add Unit Tests Test plan: 1/ Run the updated unit tests Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #42 from Martin Renvoize --- Created attachment 116572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116572&action=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer but not marked as sent. Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appear in the new 'Transfers to send' page. 4) Confirm that items marked with 'StockRotationAdvance' provide the option to mark the item as 'In demand' (Which will cancel the transfer and mark the item as in demand such that it will wait at the current branch for an additional stage period before being automatically picke for transfer again) 5) Setup a rotating collection 6) Trigger a collection transfer for the above collection 7) Check that the expected items appear in the new 'Transfers to send' page'. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #41 from Katrin Fischer --- BLOCKED by dependent bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Patch complexity|Small patch |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #40 from Martin Renvoize --- I'm looking for feedback for this tree on https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks||25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|25753 |26618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on||25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Deprecate C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|26618 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #39 from Martin Renvoize --- OK.. pretty much the entire tree beneath this has now been tested and either already QA'd or SO'd in isolation, but it's time to QA the whole patchset. I've set all preceeding bugs to BLOCKED to prevent duplication of work and obsoleted all patches so we can instead checkout the 'definitive' branch which contains all the patches. I'm currently working through the creation of a complete test plan to take account of all area's modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110543|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110544|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added URL||https://gitlab.com/mrenvoiz ||e/Koha/-/tree/bug_22569 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Joonas Kylmälä changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Summary|Stock rotation: 'Transfers |Add a 'Transfers to send' |to send' report |report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
