[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #19 from Devinim --- Created attachment 101448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101448&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period We changed the code to satisfy new methods: we used Koha::Suggestions->search()->count instead of scalar search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #18 from Nick Clemens --- Created attachment 100913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100913&action=edit Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1 - Apply this patch 2 - Run updatedatabase.pl 3 - By default the preferences are blank and do not limit. 4 - Set the limits to 3 in 30 days 5 - Go to purchase suggestion page from OPAC as a logged in patron 6 - Place 3 suggestions and confirm you cannot place any more 7 - Alter one of the suggestions to have been made more than 30 days ago UPDATE suggestions SET suggesteddate = '2020-01-01' WHERE suggestionid=3; 8 - Confirm you can place another suggestion 9 - Log out of OPAC 10 - Make sure AnonSyggestions is set to 'Allow' and AnonymousPatron is set 11 - Confirm anonymous suggestions are not limited by the syspref 12 - Confirm that a blank value in either MaxTotalSuggestions or NumberOfSuggestionDays does not limit suggestions Signed-off-by: Kelly McElligott Signed-off-by: Rhonda Kuiper Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Nick Clemens changed: What|Removed |Added Attachment #99046|0 |1 is obsolete|| Attachment #99381|0 |1 is obsolete|| Attachment #100193|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 100912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100912&action=edit Bug 22774: New systempreferences for suggestions added to sysprefs.sql Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Attachment #100192|0 |1 is obsolete|| --- Comment #16 from Devinim --- Created attachment 100193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100193&action=edit Bug 22774: New systempreferences for suggestions Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Attachment #99382|0 |1 is obsolete|| --- Comment #15 from Devinim --- Created attachment 100192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100192&action=edit Bug 22774: New systempreferences for suggestions Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Attachment #99045|0 |1 is obsolete|| --- Comment #14 from Devinim --- Created attachment 99382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99382&action=edit Bug 22774: (follow-up) New systempreferences for suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Attachment #99380|0 |1 is obsolete|| --- Comment #13 from Devinim --- Created attachment 99381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99381&action=edit Bug 22774: New systempreferences for suggestions added to sysprefs.sql New patch added for new installations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #12 from Devinim --- Created attachment 99380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99380&action=edit New systempreferences for suggestions added to sysprefs.sql New patch added for new installations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #11 from Katrin Fischer ---
1) The database update will limit the number of suggestions for existing
installations:
+$dbh->do( q{
+INSERT IGNORE INTO systempreferences
(variable,value,explanation,type) VALUES
+('MaxTotalSuggestions','3','Number of total
suggestions','free'),
+('NumberOfSuggestionDays','30','days','free')
+});
This is against the "rules" as we always aim for having no change of behaviour
on update. We should set them to empty (unlimited)
2) For the same reason I am wondering about the default settings in the YAML
file, I don't think they are needed.
3) This patch set misses the change to sysprefs.sql for setting up new
installations. While we could do the 3 and 30 there, I wonder if we should be a
little less restrictive there as well?
4) Please (re)add descriptions of the changes and test plans to the commit
messages. I've seen quite a lot of them showing here but not being part of the
attached files. Make sure you write them up in your git commit step, not when
using git bz attach, as the latter won't change the files.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit purchase suggestion in a specified time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Limit Purchase Suggestion |Limit purchase suggestion |in a specified Time period |in a specified time period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes changed: What|Removed |Added Attachment #97070|0 |1 is obsolete|| --- Comment #9 from ByWater Sandboxes --- Created attachment 99045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99045&action=edit Bug 22774: New systempreferences for suggestions Signed-off-by: Kelly McElligott Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes changed: What|Removed |Added Attachment #97071|0 |1 is obsolete|| --- Comment #10 from ByWater Sandboxes --- Created attachment 99046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99046&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period Signed-off-by: Kelly McElligott Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com --- Comment #8 from Jonathan Druart --- I do not think it is correct to have the condition check in the controller. I am pretty sure Tomas will disagree with that as we will want the API taking into account those new sysprefs. CCing Tomas to get his opinion on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes changed: What|Removed |Added Attachment #95940|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 97070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97070&action=edit Bug 22774: New systempreferences for suggestions Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes changed: What|Removed |Added Attachment #97061|0 |1 is obsolete|| --- Comment #7 from ByWater Sandboxes --- Created attachment 97071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97071&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Attachment #95941|0 |1 is obsolete|| --- Comment #5 from Devinim --- Created attachment 97061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97061&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period This was resolved. Fail occured because of some changes after we commit the patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Kelly McElligott --- Hi, Upon testing this, I received this error when trying to place a hold on the OPAC side. Could not compile /kohadevbox/koha/opac/opac-suggestions.pl: Global symbol "$suggestions_loop" requires explicit package name (did you forget to declare "my $suggestions_loop"?) at /kohadevbox/koha/opac/opac-suggestions.pl line 144 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #3 from Devinim --- Created attachment 95941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95941&action=edit Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #2 from Devinim --- Created attachment 95940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95940&action=edit Bug 22774: New systempreferences for suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- This would be very helpful for a number of libraries I've talked with about purchase suggestions. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Joy Nelson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |kohadevi...@devinim.com.tr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
