https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Blocks|23046 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Blocks||26398
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Jonathan Druart changed:
What|Removed |Added
Blocks||25010
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Blocks||24532
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Jonathan Druart changed:
What|Removed |Added
Blocks||24542
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Bug 23049 depends on bug 23321, which changed state.
Bug 23321 Summary: Add 'cash registers' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Katrin Fischer changed:
What|Removed |Added
Blocks||24316
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Jonathan Druart changed:
What|Removed |Added
Blocks||24241
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Text to go in the|This patchset moves the |This patchset moves the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Blocks|17702 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
See Also|https://bugs.koha-community |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Blocks|23636 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #225 from Martin Renvoize ---
*** Bug 23636 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Blocks|23354 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Text to go in the||This patchset moves the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #224 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #223 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #221)
> (In reply to Martin Renvoize from comment #220)
> > I managed at least to get this all running under MariaDB 10.2.27 and see the
> > check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #222 from Marcel de Rooy ---
Created attachment 94648
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94648=edit
Bug 23049: [LAST PATCH ONLY] (QA follow-up) Catch '0' case debits
Signed-off-by: Marcel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Medium patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #221
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #219 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #218)
> Hmm,
>
> The exception is intended and is in fact caught and rethrown within
> Koha::Account.pm.. not sure why it results in noise in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #218 from Martin Renvoize ---
Hmm,
The exception is intended and is in fact caught and rethrown within
Koha::Account.pm.. not sure why it results in noise in the test though.. it
should be hidden by the 'throws_ok'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #217 from Marcel de Rooy ---
t/db_dependent/Accounts.t (Wstat: 768 Tests: 33 Failed: 3)
Failed tests: 12-14
t/db_dependent/ILSDI_Services.t .. ok
All tests successful.
t/db_dependent/Koha/Account/Offsets.t .. ok
All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #214 from Marcel de Rooy ---
And I am still a bit worried that we did not complete resolve the amount<0 or
amount=0 cases in the upgrade..
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #212 from Marcel de Rooy ---
Koha/Schema/Result/AccountDebitType.pm | 12 -
Koha/Schema/Result/Accountline.pm | 6 +--
admin/debit_types.pl | 43
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #211 from Marcel de Rooy ---
[OK] t/db_dependent/Koha/Account/Offsets.t | 7 ++-
[OK] t/db_dependent/Members.t | 15 --
t/db_dependent/Accounts.t (Wstat: 65280 Tests: 31 Failed: 10)
Failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #210 from Marcel de Rooy ---
t/db_dependent/api/v1/patrons_accounts.t .. ok
All tests successful.
Hopeful ! Hang on
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #208 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #207)
> (Minor) If you archive a debit type, you should probably be no longer
> allowed to create a manual invoice with that type.
Corrected on the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #206
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #205 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #204)
> Rebased and pushed addition QA followups to the github branch.
>
> I'm unable to replicate your test failures at the moment and have tried
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #203 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #199)
> Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your
> branch.
>
> Thanks for your hard work.
> I have noted comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #201 from Marcel de Rooy ---
I saw that I still had data that conflicted with accounttype IS NOT NULL OR
debit_type_code IS NOT NULL;
But when I removed that data and ran Accounts.t again, it still fails.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #200 from Marcel de Rooy ---
[FAIL] t/db_dependent/Accounts.t
[OK] t/db_dependent/Circulation.t
[OK] t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
[OK] t/db_dependent/Circulation/Returns.t
[OK]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #199 from Marcel de Rooy ---
Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your
branch.
Thanks for your hard work.
I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #198
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
QA Contact|k...@bywatersolutions.com |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #197 from Marcel de Rooy ---
Martin Renvoize changed:
What|Removed |Added
QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
QA Contact|m.de.r...@rijksmuseum.nl|k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94351|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94350|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94352|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94348|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94349|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94347|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94341|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94343|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94346|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94344|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94345|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94342|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94340|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94337|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94339|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94338|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94331|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94336|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94335|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94333|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94334|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94332|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #196 from Martin Renvoize ---
I've pushed a public branch to keep this rebased rather than throw yet more
patches in here: https://github.com/PTFS-Europe/koha/tree/bug_23049_inv
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
URL|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94329|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94326|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94328|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94327|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94325|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94324|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94319|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94321|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94320|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94318|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94323|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94317|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94316|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94315|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94314|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94311|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94310|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94308|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94309|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94307|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Martin Renvoize changed:
What|Removed |Added
Attachment #94152|0 |1
is obsolete|
1 - 100 of 343 matches
Mail list logo