[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102095|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|Small patch |Trivial patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102094|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 138059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138059=edit Bug 23247: Use EmbedItems in opac-MARCdetail.pl This patch uses the EmbedItems processor to add the items to the MARC record. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Bug 23247 depends on bug 25006, which changed state. Bug 25006 Summary: Koha::Item->as_marc_field generates undef subfields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > The order of the columns is not identical, is that expected? > > Without: https://snipboard.io/uT4lNK.jpg > With:https://snipboard.io/iVGqpZ.jpg That's not expected. I didn't notice! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #21 from Jonathan Druart --- The order of the columns is not identical, is that expected? Without: https://snipboard.io/uT4lNK.jpg With:https://snipboard.io/iVGqpZ.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #16) > Tomas, > See my comment13. > I have a book with three items. One is CF. > Without your patch, normal view and marc view show 2 items. Which is ok. > With your patch, normal view shows still 2 items (of course), but marc view > shows no available items. Should be 2. > > Failed QA Phew, it took me a while to be back here. Please re-test with the follow-up. I rebased the first patch against master (IssuingRules vs CirculationRules) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #12) > Does this report obsolete the borcat parameter of GetMarcBiblio btw? > If so, please provide a follow-up to get rid of it? The plan is to get rid of GetMarcBiblio altogether. Gimme some more time to align things :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 102095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102095=edit Bug 23247: (QA follow-up) Restore embedding items in record The original code called GetMarcBiblio with embeditems => 1, and I overlooked it. This patch makes it embed the items. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 102094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102094=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Depends on||25006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25006 [Bug 25006] Koha::Item->as_marc_field generates undef subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Attachment #93528|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |BLOCKED --- Comment #15 from Marcel de Rooy --- Testing again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #16 from Marcel de Rooy --- Tomas, See my comment13. I have a book with three items. One is CF. Without your patch, normal view and marc view show 2 items. Which is ok. With your patch, normal view shows still 2 items (of course), but marc view shows no available items. Should be 2. Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
--- Comment #14 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #12)
> Does this report obsolete the borcat parameter of GetMarcBiblio btw?
> If so, please provide a follow-up to get rid of it?
(In reply to Marcel de Rooy from comment #11)
> From Patron/Category:
>
> =head3 override_hidden_items
>
> if ( $patron->category->override_hidden_items ) {
> ...
> }
>
> Returns a boolean that if patrons of this category are exempt from the
> OPACHiddenItems policies
>
> TODO: Remove on bug 22547
>
> => Looks like we did not on 22547 ;)
That was a typo, it was meant to be bug 22457
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #13 from Marcel de Rooy --- If I have nothing in OPACHiddenItems or just itype: [CF], I do not see my two items on a record with itype BK or BKS. Just: No available items. Without your patch, they come up again. Nice. So there is still something wrong ;) Can you find it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #12 from Marcel de Rooy --- Does this report obsolete the borcat parameter of GetMarcBiblio btw? If so, please provide a follow-up to get rid of it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
--- Comment #11 from Marcel de Rooy ---
From Patron/Category:
=head3 override_hidden_items
if ( $patron->category->override_hidden_items ) {
...
}
Returns a boolean that if patrons of this category are exempt from the
OPACHiddenItems policies
TODO: Remove on bug 22547
=> Looks like we did not on 22547 ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #10 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jesse Maseto changed: What|Removed |Added Attachment #91253|0 |1 is obsolete|| --- Comment #9 from Jesse Maseto --- Created attachment 93528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93528=edit Hi Tomas. Looks good. Signing this patch off. JesseM Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jesse Maseto changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- (In reply to M. Tompsett from comment #6) > I believe I have rebased it correctly to be off bug 22721 as mentioned by > Katrin in comment #4. As such, I'm happy to leave it back at Needs Signoff. Why did not you sign it off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Bug 23247 depends on bug 22721, which changed state. Bug 22721 Summary: Normalize GetMarcFromKohaField calls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #7 from M. Tompsett --- Apologies, I lost the other Depends on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What|Removed |Added Attachment #91158|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on|22696 |22721 --- Comment #6 from M. Tompsett --- I believe I have rebased it correctly to be off bug 22721 as mentioned by Katrin in comment #4. As such, I'm happy to leave it back at Needs Signoff. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696 [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 [Bug 22721] Normalize GetMarcFromKohaField calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #5 from M. Tompsett --- Created attachment 91253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91253=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to M. Tompsett from comment #2) > Comment on attachment 91158 [details] [review] > Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl > > Review of attachment 91158 [details] [review]: > - > > ::: opac/opac-MARCdetail.pl > @@ +305,4 @@ > > push @item_loop, $item if $item; > > } > > my ( $holdingbrtagf, $holdingbrtagsubf ) = > > + ( "items.holdingbranch", $biblio->frameworkcode ); > > If you are refactoring, while I would prefer to keep framework code in, so > as to allow weird and wonderful things in the future (UNIMARC and MARC21 > co-existing), the function has already been neutered. So perhaps a refactor > on this and other uses of this function here would be in order? Hi Marc, resetting status - this is only a clan-up, the parameter frameworkcode for GetMarcFromKohaField does no longer exist. See bug 22721 for some more info. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett --- Setting to Failed QA, while discussion about cleaning up the other function call is had and/or done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #2 from M. Tompsett --- Comment on attachment 91158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158 Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl Review of attachment 91158: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23247=91158) - ::: opac/opac-MARCdetail.pl @@ +305,4 @@ > push @item_loop, $item if $item; > } > my ( $holdingbrtagf, $holdingbrtagsubf ) = > + ( "items.holdingbranch", $biblio->frameworkcode ); If you are refactoring, while I would prefer to keep framework code in, so as to allow weird and wonderful things in the future (UNIMARC and MARC21 co-existing), the function has already been neutered. So perhaps a refactor on this and other uses of this function here would be in order? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 91158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91158=edit Bug 23247: Simplify visibility logic used in opac-MARCdetail.pl This patch uses the OO code, with prefetching and all, to make decisions on visibility. It shouldn't change any behaviour, unless you are counting DB queries, execution time, etc. To test: - Find a known record, go to the OPAC MARC page of it. - Play with several options in OpacHiddenItems, refreshing it - Play with OpacHiddenItemsExceptions as well => SUCCESS: Things work as expected - Apply this patch - Repeate the tests above => SUCCESS: Things work as expected! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Tomás Cohen Arazi changed: What|Removed |Added Summary|Simplify visibility logic |Simplify visibility logic |in opac-detail.pl and |in opac-MARCdetail.pl |opac-MARCdetail.pl | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
