[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25686


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686
[Bug 25686] Title in the catalogue search result doesn't open the full (normal)
record display
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24137

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Corinne Hayet  changed:

   What|Removed |Added

 Blocks||23709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23709
[Bug 23709] Can't add new subfields to bibliographic frameworks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #22 from Katrin Fischer  ---
(In reply to Corinne Hayet from comment #21)
> Sorry but it still does not work. It only works if the subfield is connected
> to an Authorized values list.
> 
> I created a subfield 099$m with a link with COUNTRY authorized values list
> and it's OK
> 
> But, if I try to create a simple subfield 012$z and I've got the following
> error in logs : 
> 
> DBD::mysql::st execute failed: Cannot add or update a child row: a foreign
> key constraint fails (`koha`.`marc_subfield_structure`,
> CONSTRAINT `marc_subfield_structure_ibfk_1` FOREIGN KEY
> (`authorised_value`) REFERENCES `authorised_value_categories`
> (`category_name`) ON DELETE SET NULL ON ) [for Statement "INSERT INTO
> `marc_subfield_structure` ( `authorised_value`, `authtypecode`,
> `defaultvalue`, `frameworkcode`, `hidden`, `isurl`, `kohafield`,
> `liblibrarian`, `libopac`, `link`, `mandatory`, `maxlength`, `repeatable`,
> `seealso`, `tab`, `tagfield`, `tagsubfield`,
> `value_builder`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
> ? )" with ParamValues: 0="", 1="", 2="", 3="", 4="0", 5=0, 6="", 7="test",
> 8="test", 9="", 10=0, 11="", 12=0, 13=undef, 14="0", 15="013", 16="x",
> 17=""] at /usr/local/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
> 
> Best regards,
> Corinne

Hi Corinne, thx for being persistent! As this is already in stable, would you
mind filing a new bug and linking to this one? (Depends on). We will have to
treat it as a new bug and take a look into fixing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #21 from Corinne Hayet  ---
Sorry but it still does not work. It only works if the subfield is connected to
an Authorized values list.

I created a subfield 099$m with a link with COUNTRY authorized values list and
it's OK

But, if I try to create a simple subfield 012$z and I've got the following
error in logs : 

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha`.`marc_subfield_structure`,
CONSTRAINT `marc_subfield_structure_ibfk_1` FOREIGN KEY
(`authorised_value`) REFERENCES `authorised_value_categories`
(`category_name`) ON DELETE SET NULL ON ) [for Statement "INSERT INTO
`marc_subfield_structure` ( `authorised_value`, `authtypecode`, `defaultvalue`,
`frameworkcode`, `hidden`, `isurl`, `kohafield`, `liblibrarian`, `libopac`,
`link`, `mandatory`, `maxlength`, `repeatable`, `seealso`, `tab`, `tagfield`,
`tagsubfield`,
`value_builder`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
)" with ParamValues: 0="", 1="", 2="", 3="", 4="0", 5=0, 6="", 7="test",
8="test", 9="", 10=0, 11="", 12=0, 13=undef, 14="0", 15="013", 16="x",
17=""] at /usr/local/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.

Best regards,
Corinne

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #20 from Lucas Gass  ---
Sorry about this error, I have fixed it with this commit: 

9c1720d7d7b299812bc7faa6a2ae9d23075d2a0d

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #19 from Fridolin SOMERS  ---
Oh indeed.

@Lucas :
I think its a backport error of "Bug 23309: DBRev 18.11.09.002" :
You impact only installer/data/mysql/updatedatabase.pl :
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=105e3c9ce04d2958d9e0749c579f73fece94d641

Compare with master :
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=347dc9589aa75edb1c64c21e5d057373dfd3ed84

And 19.05.x :
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f14d94e565c81f8afa25fea7e1a032f33c93ad82

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Corinne Hayet  changed:

   What|Removed |Added

 CC||corinne.ha...@progilone.fr

--- Comment #18 from Corinne Hayet  ---
Hello everybody,

We apply the last commit on Koha 18.11 including this patch and it doesn't
work.

We've got two errors

 1. A foreign key constraint on authorised_value that fires because the value
"" is passed instead of NULL:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha`.`marc_subfield_structure`, CONSTRAINT
`marc_subfield_structure_ibfk_1` FOREIGN KEY (`authorised_value`) REFERENCES
`authorised_value_categories` (`category_name`) ON DELETE SET NULL ON ) [for
Statement "
update marc_subfield_structure set tagfield=?, tagsubfield=?,
liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?,
seealso=?, authorised_value=?, authtypecode=?, value_builder=?, hidden=?,
isurl=?, frameworkcode=?,  link=?, defaultvalue=?, maxlength=?
where tagfield=? and tagsubfield=? and frameworkcode=?
" with ParamValues: 0="225", 1="a", 2="titre de la collection", 3="", 4=0,
5=0, 6="biblioitems.collectiontitle", 7="0", 8=undef, 9="", 10="",
11="unimarc_field_225a.pl", 12="0", 13=0, 14="FA", 15="", 16="", 17="",
18="225", 19="a", 20="FA"] at
/usr/share/koha/intranet/cgi-bin/admin/marc_subfields_structure.pl line 276.


2. The hidden field is explicitly set to null, so it does not change to its
default value:

DBD::mysql::st execute failed: Column 'hidden' cannot be null [for Statement
"INSERT INTO `marc_subfield_structure` ( `authorised_value`, `authtypecode`,
`defaultvalue`, `frameworkcode`, `hidden`, `isurl`, `kohafield`,
`liblibrarian`, `libopac`, `link`, `mandatory`, `maxlength`, `repeatable`,
`seealso`, `tab`, `tagfield`, `tagsubfield`, `value_builder`) VALUES ( ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="",
2="", 3="FA", 4=undef, 5=0, 6='', 7="test", 8="test", 9="", 10=0, 11="",
12=0, 13=undef, 14="-1", 15="225", 16="z", 17=""] at
/usr/local/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.

Best regards,

Corinne

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

--- Comment #17 from Lucas Gass  ---
backported to 18.11.x for 18.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #16 from Lucas Gass  ---
backported to 18.11.x for 18.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.04
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #15 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #14 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 92190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92190&action=edit
Bug 23309: Use Koha::MarcSubfieldStructures to create to subfields

It will fix the insert of new subfields with SQL strict modes

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'hidden' at row 1 [for Statement "

Test plan:
- Turn the config strict_sql_modes ON
- Add a new subfield to a field

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92054|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92171|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 92189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92189&action=edit
Bug 23309: Update DB

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #10)
> (In reply to Katrin Fischer from comment #9)
> > Why the change to assigned?
> 
> Because it needs a followup I'm writing.

It doesn't need the follow-up. The test plan says nothing about updating the
DBIC schema (and I forgot!).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #10 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #9)
> Why the change to assigned?

Because it needs a followup I'm writing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #9 from Katrin Fischer  ---
Why the change to assigned?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #92055|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 92171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92171&action=edit
Bug 23309: Use Koha::MarcSubfieldStructures to create to subfields

It will fix the insert of new subfields with SQL strict modes

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'hidden' at row 1 [for Statement "

Test plan:
- Turn the config strict_sql_modes ON
- Add a new subfield to a field

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #8 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #6)
> Should we make the same changes to auth_subfield_structure?

The bug doesn't appear to exist for authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #6 from Katrin Fischer  ---
Should we make the same changes to auth_subfield_structure?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #92017|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 92054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92054&action=edit
Bug 23309: Update DB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #5 from Jonathan Druart  
---
Created attachment 92055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92055&action=edit
Bug 23309: Use Koha::MarcSubfieldStructures to create to subfields

It will fix the insert of new subfields with SQL strict modes

DBD::mysql::st execute failed: Incorrect integer value: '' for column
'hidden' at row 1 [for Statement "

Test plan:
- Turn the config strict_sql_modes ON
- Add a new subfield to a field

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #3 from Jonathan Druart  
---
Indeed Nick, good catch!
So maybe we should have this default value at DB value?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #2 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #1)
> Created attachment 92017 [details] [review]
> Bug 23309: Fix insert of new subfields with SQL strict modes
> 
> DBD::mysql::st execute failed: Incorrect integer value: '' for column
> 'hidden' at row 1 [for Statement "
> 
> Test plan:
> - Turn the config strict_sql_modes ON
> - Add a new subfield to a field

Should it be 8 and not 0? All unchecked is '8' if you save with this patch you
get Opac Intranet and Editor checked which is equivalent to 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Blocks||17258
 Depends on|17258   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

--- Comment #1 from Jonathan Druart  
---
Created attachment 92017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92017&action=edit
Bug 23309: Fix insert of new subfields with SQL strict modes

DBD::mysql::st execute failed: Incorrect integer value: '' for column 'hidden'
at row 1 [for Statement "

Test plan:
- Turn the config strict_sql_modes ON
- Add a new subfield to a field

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Chris Slone  changed:

   What|Removed |Added

 CC||cslone@camdencountylibrary.
   ||org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23309] Can't add new subfields to bibliographic frameworks in strict mode

2019-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23309

Katrin Fischer  changed:

   What|Removed |Added

Summary|Can't add new subfields to  |Can't add new subfields to
   |bibliographic frameworks|bibliographic frameworks in
   ||strict mode

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/