[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #12 from Katrin Fischer --- Added a follow-up - can you check Alex? Changes in OPAC are debatable on this bug report, but I think we really need to put back the $raw because of bug 22702. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #11 from Katrin Fischer --- Created attachment 92247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92247=edit Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account This patch makes 2 changes: - bug 22702 allowed adding HTML to the circulation note, so this patch restores that ability. - display OPAC note and messages as multi-line in OPAC To test: - Add a circulation and an OPAC note with line breaks and HTML tags to the patron account - Add a message with line breaks to the patron account - Check line breaks don't show on - OPAC > patron account > my summary page - Staff > patron account > details - Apply patches - Repeat test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added Attachment #92173|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 92246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92246=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22702 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Attachment #92172|0 |1 is obsolete|| --- Comment #9 from Alex Arnaud --- Created attachment 92173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92173=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Attachment #91906|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 92172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92172=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #7 from Katrin Fischer --- Hi Alex, will you have a chance to submit an updated patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #6 from Fridolin SOMERS --- patron.opacnote exists in other places : koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc borrowernotes exists in a lot of other places. BTW html filter should always be used, not $raw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #5 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #4) > Instead of: > > +[% FILTER html_line_break %] > +[% patron.opacnote | > html %] > +[% END %] > > You can just do: > > [% patron.opacnote | html | html_line_break %] > > (I think we first want to espace, then make br so the br are not esacped) Indeed, its much better ;) See existing : [% subscription.notes | html | html_line_break %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23194 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #4 from Katrin Fischer --- Instead of: +[% FILTER html_line_break %] +[% patron.opacnote | html %] +[% END %] You can just do: [% patron.opacnote | html | html_line_break %] (I think we first want to espace, then make br so the br are not esacped) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Attachment #91905|0 |1 is obsolete|| --- Comment #3 from Alex Arnaud --- Created attachment 91906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91906=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Alex, I think there is a nicer way to solve this using TT filters. I've seen them used in quite a few places already. http://www.template-toolkit.org/docs/manual/Filters.html#section_html_line_break -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #1 from Alex Arnaud --- Created attachment 91905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91905=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Summary|Show borrowernotes and |Show borrowernotes and |opacnote's lines feeds |opacnote's lines feeds |(staff and opac)|(staff) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23409] Show borrowernotes and opacnote's lines feeds (staff and opac)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
