https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Fridolin Somers changed:
What|Removed |Added
Blocks||29794
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Nick Clemens changed:
What|Removed |Added
Blocks||28255
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||27819
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||28028
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||28015
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||27808
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||27963
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Nick Clemens changed:
What|Removed |Added
Blocks||27837
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||27509
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||27003
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Aleisha Amohia changed:
What|Removed |Added
Blocks||26750
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26557
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26992
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Blou changed:
What|Removed |Added
CC||philippe.blo...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #168 from Blou ---
Created attachment 113581
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113581=edit
Bug 26948: Regression tests
We already mock the send_or_die method from Email::Stuffer; This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26987
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26675
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26507
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Katrin Fischer changed:
What|Removed |Added
Blocks||26438
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26470
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Martin Renvoize changed:
What|Removed |Added
Blocks||26268
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26082
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||26134
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||25964
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
didier changed:
What|Removed |Added
Blocks||25608
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Blocks||25248
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #166 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #165 from Jonathan Druart
---
Created attachment 103129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103129=edit
Bug 23463: Remove double store call
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #164 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #163)
>
> $item_object-
> >more_subfields_xml(_get_unlinked_subfields_xml($unlinked_item_subfields))-
> >store;
> $item_object->store;
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #163 from Marcel de Rooy ---
$item_object->more_subfields_xml(_get_unlinked_subfields_xml($unlinked_item_subfields))->store;
$item_object->store;
Is this double store call intentional ?
C4/Items ModItemFromMarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #160 from Martin Renvoize ---
Final follow-up pushed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Attachment #101476|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #158 from Jonathan Druart
---
Created attachment 101476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101476=edit
Bug 23463: (follow-up 3) Fix timestamp default value
This is the only situation I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #157 from Tomás Cohen Arazi ---
Congratulations, Jonathan
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #156 from Jonathan Druart
---
Created attachment 101432
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101432=edit
Bug 23463: Fix selenium tests (highlight a bug in date management)
There is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #155 from Jonathan Druart
---
Created attachment 101416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101416=edit
Bug 23463: Fix wrong variable name
Fix for t/db_dependent/Labels/t_Batch.t
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #154 from Martin Renvoize ---
Created attachment 101415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101415=edit
Bug 23463: (RM follow-up) Add try block around Illrequest item creation
The recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #153 from Jonathan Druart
---
Created attachment 101414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101414=edit
Bug 23463: Fix CourseReserves/CourseItems.t
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #152 from Jonathan Druart
---
Created attachment 101413
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101413=edit
Bug 23463: Replace a new occurrence of ModItem
This new script have been pushed just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #151 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #149 from Jonathan Druart
---
Created attachment 101283
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101283=edit
Bug 23463: (follow-up 2) Fix timestamp default value
Removing previous change,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #150 from Jonathan Druart
---
Created attachment 101284
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101284=edit
Bug 23463: Fix items.cn_sort vs cn_sort
Signed-off-by: Nick Clemens
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #148 from Jonathan Druart
---
Created attachment 101282
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101282=edit
Bug 23463: Use new method Koha::Object->set_or_blank
This patch fixes an issue when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #145 from Jonathan Druart
---
Created attachment 101279
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101279=edit
Bug 23463: Fix cn_source for new item
get_dirty_columns only work for existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #147 from Jonathan Druart
---
Created attachment 101281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101281=edit
Bug 23463: Replace new occurrence of AddItem
Signed-off-by: Nick Clemens
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #146 from Jonathan Druart
---
Created attachment 101280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101280=edit
Bug 23463: Fix XSLT.t
From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0
Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #144 from Jonathan Druart
---
Created attachment 101278
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101278=edit
Bug 23463: Fix IsItemIssued.t
It seems that some of those tests could be removed as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #143 from Jonathan Druart
---
Created attachment 101277
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101277=edit
Bug 23463: Fix tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #141 from Jonathan Druart
---
Created attachment 101275
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101275=edit
Bug 23463: (follow-up) Fix timestamp default value
For discussion, this patch revert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #142 from Jonathan Druart
---
Created attachment 101276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101276=edit
Bug 23463: Fix safe_return return value in deletion tools
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #140 from Jonathan Druart
---
Created attachment 101274
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101274=edit
Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t
subtest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #137 from Jonathan Druart
---
Created attachment 101271
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101271=edit
Bug 23463: cn_sort needs to be updated if cn_source changed
Signed-off-by: Tomas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #135 from Jonathan Druart
---
Created attachment 101269
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101269=edit
Bug 23463: build cn_sort only if needed
No need to calculate cn_sort if not dirty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #136 from Jonathan Druart
---
Created attachment 101270
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101270=edit
Bug 23463: Replace recently added occurrences
Few occurrences have been added since
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #139 from Jonathan Druart
---
Created attachment 101273
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101273=edit
Bug 23463: Fix timestamp default value
This sounds wrong as we should let the DBMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #138 from Jonathan Druart
---
Created attachment 101272
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101272=edit
Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete
Wrong replacement in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #134 from Jonathan Druart
---
Created attachment 101268
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101268=edit
Bug 23463: Fix items.cn_source vs cn_source
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #133 from Jonathan Druart
---
Created attachment 101267
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101267=edit
Bug 23463: update permanent_location if location has been updated
This change to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #132 from Jonathan Druart
---
Created attachment 101266
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101266=edit
Bug 23463: Fix AutomaticItemModificationByAge.t
We do not want to log if nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #130 from Jonathan Druart
---
Created attachment 101264
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101264=edit
Bug 23463: Fix failing tests
And adding a FIXME about discard_changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #129 from Jonathan Druart
---
Created attachment 101263
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101263=edit
Bug 23463: Fix CancelReceipt.t
Signed-off-by: Tomas Cohen Arazi
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #131 from Jonathan Druart
---
Created attachment 101265
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101265=edit
Bug 23463: Getting less item-level_itypes warnings (?)
So, we get less warnings. I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #128 from Jonathan Druart
---
Created attachment 101262
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101262=edit
Bug 23463: Remove no longer needed subs related to default values
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #127 from Jonathan Druart
---
Created attachment 101261
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101261=edit
Bug 23463: Remove DelItemCheck and ItemSafeToDelete
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #122 from Jonathan Druart
---
Created attachment 101256
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101256=edit
Bug 23463: _set_derived_columns_for_mod was only used for cn_sort
Same as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #126 from Jonathan Druart
---
Created attachment 101260
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101260=edit
Bug 23463: Remove DelItem
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #124 from Jonathan Druart
---
Created attachment 101258
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101258=edit
Bug 23463: Remove _mod_item_dates
We did not do anything useful here.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #125 from Jonathan Druart
---
Created attachment 101259
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101259=edit
Bug 23463: Remove ModItem
There should not be any calls left
Signed-off-by: Tomas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #123 from Jonathan Druart
---
Created attachment 101257
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101257=edit
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp
moved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #121 from Jonathan Druart
---
Created attachment 101255
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101255=edit
Bug 23463: Move plugin hook
From C4::Items to Koha::Item
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #119 from Jonathan Druart
---
Created attachment 101253
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101253=edit
Bug 23463: Replace ModItem with Koha::Item->store
Starting to replace the ModItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #120 from Jonathan Druart
---
Created attachment 101254
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101254=edit
Bug 23463: remove trivial UpdateHoldingbranch sub
We do not need this subroutine,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #117 from Jonathan Druart
---
Created attachment 101251
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101251=edit
Bug 23463: Replace _set_derived_columns_for_add
Remove the unique call to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #114 from Jonathan Druart
---
Created attachment 101248
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101248=edit
Bug 23463: fix for testbuilder - set default value items.damaged=0
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #115 from Jonathan Druart
---
Created attachment 101249
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101249=edit
Bug 23463: Replace AddItem calls with Koha::Item->store
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #116 from Jonathan Druart
---
Created attachment 101250
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101250=edit
Bug 23463: Remove _set_defaults_for_add
_set_defaults_for_add is no longer needed as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #118 from Jonathan Druart
---
Created attachment 101252
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101252=edit
Bug 23463: AddItem removing
We are done with AddItem, only need to log and index.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #113 from Jonathan Druart
---
Created attachment 101247
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101247=edit
Bug 23463: Remove uneeded SearchItemsByField subroutine
It is no longer used.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Jonathan Druart changed:
What|Removed |Added
Attachment #101151|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #109 from Jonathan Druart
---
Created attachment 101195
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101195=edit
Bug 23463: Use new method Koha::Object->set_or_blank
This patch fixes an issue when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #111 from Jonathan Druart
---
Created attachment 101197
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101197=edit
Bug 23463: Fix items.cn_sort vs cn_sort
Signed-off-by: Signed-off-by: Nick Clemens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #110 from Jonathan Druart
---
Created attachment 101196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101196=edit
Bug 23463: (follow-up 2) Fix timestamp default value
Removing previous change,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #108 from Jonathan Druart
---
Created attachment 101194
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101194=edit
Bug 23463: Replace new occurrence of AddItem
Signed-off-by: Signed-off-by: Nick
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #107 from Jonathan Druart
---
Created attachment 101193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101193=edit
Bug 23463: Fix XSLT.t
From commit bf49eecdd87e2b29760226281ab1afc0a185c7f0
Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #106 from Jonathan Druart
---
Created attachment 101192
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101192=edit
Bug 23463: Fix cn_source for new item
get_dirty_columns only work for existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #105 from Jonathan Druart
---
Created attachment 101191
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101191=edit
Bug 23463: Fix IsItemIssued.t
It seems that some of those tests could be removed as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #104 from Jonathan Druart
---
Created attachment 101190
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101190=edit
Bug 23463: Fix tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #102 from Jonathan Druart
---
Created attachment 101188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101188=edit
Bug 23463: (follow-up) Fix timestamp default value
For discussion, this patch revert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #103 from Jonathan Druart
---
Created attachment 101189
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101189=edit
Bug 23463: Fix safe_return return value in deletion tools
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #101 from Jonathan Druart
---
Created attachment 101186
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101186=edit
Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t
subtest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #100 from Jonathan Druart
---
Created attachment 101185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101185=edit
Bug 23463: Fix timestamp default value
This sounds wrong as we should let the DBMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #98 from Jonathan Druart
---
Created attachment 101183
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101183=edit
Bug 23463: cn_sort needs to be updated if cn_source changed
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #99 from Jonathan Druart
---
Created attachment 101184
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101184=edit
Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete
Wrong replacement in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #96 from Jonathan Druart
---
Created attachment 101181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101181=edit
Bug 23463: build cn_sort only if needed
No need to calculate cn_sort if not dirty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #97 from Jonathan Druart
---
Created attachment 101182
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101182=edit
Bug 23463: Replace recently added occurrences
Few occurrences have been added since
1 - 100 of 258 matches
Mail list logo