[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #17 from Nick Clemens --- Created attachment 100686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100686=edit Bug 23482: [19.11.x] Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #16 from Joy Nelson --- does not apply to 19.11.x branch please rebase if needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart --- I have tried to put this code in an include file but failed. They are all different! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What|Removed |Added Attachment #99374|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 99383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99383=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Attachment #99247|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 99374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99374=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Attachment #99247|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Attachment #99372|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Depends on|24704 |17896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 [Bug 17896] BakerTaylorEnabled is not plack safe in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Bug 23482 depends on bug 24704, which changed state. Bug 24704 Summary: Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Depends on||24704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24704 [Bug 24704] Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Attachment #99247|0 |1 is obsolete|| Attachment #99248|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 99372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99372=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #10 from Jonathan Druart --- This is not enough for me to PQA. The original code is wrong (see bug 17896), you copy it, then modify it. I would prefer to fix the original issue, then reuse it. Here we are going to end up with 2 different versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #9 from Nick Clemens --- Created attachment 99248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99248=edit Bug 23482: Remove conditional from BEGIN block -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Attachment #95661|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 99247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99247=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- The BEGIN block is wrong, see bug 17896. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #6 from Katrin Fischer --- Argh, thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482
--- Comment #5 from Nick Clemens ---
(In reply to Katrin Fischer from comment #4)
> Comment on attachment 95661 [details] [review]
> Bug 23482: Fix BakerTaylor cover images on lists
>
> Review of attachment 95661 [details] [review]:
> -
>
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
> @@ +360,5 @@
> > + > class="no-image">No cover image available
> > +[% END %]
> > +[% END %]
> > +
> > +[% IF (
> > Koha.Preference('BakerTaylorEnabled') &&
> > Koha.Preference('BakerTaylorBookstoreURL') ) %]
>
> Not sure why you start a new IF block here - conditions and variables appear
> to be the same as on the check right before it?
One is:
!Koha.Preference('BakerTaylorBookstoreURL')
The other is:
Koha.Preference('BakerTaylorBookstoreURL')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482
--- Comment #4 from Katrin Fischer ---
Comment on attachment 95661
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95661
Bug 23482: Fix BakerTaylor cover images on lists
Review of attachment 95661:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23482=95661)
-
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ +360,5 @@
> + class="no-image">No cover image available
> +[% END %]
> +[% END %]
> +
> +[% IF (
> Koha.Preference('BakerTaylorEnabled') &&
> Koha.Preference('BakerTaylorBookstoreURL') ) %]
Not sure why you start a new IF block here - conditions and variables appear to
be the same as on the check right before it?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Katrin Fischer changed: What|Removed |Added Summary|BakerTaylor images broken |BakerTaylor images broken |on opac lists |on OPAC lists CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #3 from Kelly McElligott --- I contacted the library that submitted this bug to us and they provided me with their B user name and password, this patch works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 ByWater Sandboxes changed: What|Removed |Added Attachment #92390|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 95661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95661=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 --- Comment #1 from Nick Clemens --- Created attachment 92390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92390=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
