[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds a new
  release notes||'Suggestion details' tab to
   ||the bibliographic record
   ||details view.
   Severity|new feature |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #33 from Joy Nelson  ---
new feature not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_20_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #32 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #22 from Katrin Fischer  ---
Patch no longer applies on top of bug 22784, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23591: Add some useful methods to Koha::Suggestions
Applying: Bug 23591: Display a new "Suggestion detail" tab on the bib detail
page
Applying: Bug 23591: Use same css for suggestion notes
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt).
error: could not build fake ancestor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #100814|0   |1
is obsolete||
 Attachment #100815|0   |1
is obsolete||
 Attachment #100816|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 102799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102799&action=edit
Bug 23591: Use same css for suggestion notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #100812|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 102850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102850&action=edit
Bug 23591: Add some useful methods to Koha::Suggestions

Those are methods initially written for bug 23991. I finally need them
before than expected.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #25 from Jonathan Druart  
---
Created attachment 102801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102801&action=edit
Bug 23591: Hide archived suggestions

However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #31 from Katrin Fischer  ---
Do not push CSS changes indeed - file is not minified! :)

Future enhanements:
- Move the dates into separate columns as we did in other places now, so the
can be sorted nicely.
- Add an option to show the archived suggestions (checkbox or button)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #102801|0   |1
is obsolete||

--- Comment #30 from Katrin Fischer  ---
Created attachment 102854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102854&action=edit
Bug 23591: Hide archived suggestions

However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #24 from Jonathan Druart  
---
Created attachment 102800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102800&action=edit
Bug 23591: [DO NOT PUSH] CSS Changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #100813|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 102851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102851&action=edit
Bug 23591: Display a new "Suggestion detail" tab on the bib detail page

This patch adds a new "Suggestion detail" tab on the bibliographic
detail page. It will help suggestion management.

Test plan:
- Create several suggestions for a given biblio
- Go to the detail page of the bibliographic record and confirm that
there is a new "Suggestion detail" tab with all the suggestions you
created.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #102799|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 102852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102852&action=edit
Bug 23591: Use same css for suggestion notes

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #102800|0   |1
is obsolete||

--- Comment #29 from Katrin Fischer  ---
Created attachment 102853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102853&action=edit
Bug 23591: [DO NOT PUSH] CSS Changes

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #20 from Jonathan Druart  
---
Created attachment 100815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100815&action=edit
Bug 23591: [DO NOT PUSH] CSS Changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #19 from Jonathan Druart  
---
Created attachment 100814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100814&action=edit
Bug 23591: Use same css for suggestion notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #18 from Jonathan Druart  
---
Created attachment 100813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100813&action=edit
Bug 23591: Display a new "Suggestion detail" tab on the bib detail page

This patch adds a new "Suggestion detail" tab on the bibliographic
detail page. It will help suggestion management.

Test plan:
- Create several suggestions for a given biblio
- Go to the detail page of the bibliographic record and confirm that
there is a new "Suggestion detail" tab with all the suggestions you
created.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #21 from Jonathan Druart  
---
Created attachment 100816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100816&action=edit
Bug 23591: Hide archived suggestions

However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #95600|0   |1
is obsolete||
  Attachment #95601|0   |1
is obsolete||
  Attachment #95602|0   |1
is obsolete||
  Attachment #95603|0   |1
is obsolete||
  Attachment #95604|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 100812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100812&action=edit
Bug 23591: Add some useful methods to Koha::Suggestions

Those are methods initially written for bug 23991. I finally need them
before than expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2020-02-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer  ---
Currently blocked by bug in FQA further up the dependency tree.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95521|0   |1
is obsolete||

--- Comment #14 from Séverine Queune  ---
Created attachment 95603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95603&action=edit
Bug 23591: [DO NOT PUSH] CSS Changes

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95520|0   |1
is obsolete||

--- Comment #13 from Séverine Queune  ---
Created attachment 95602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95602&action=edit
Bug 23591: Use same css for suggestion notes

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95579|0   |1
is obsolete||

--- Comment #15 from Séverine Queune  ---
Created attachment 95604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95604&action=edit
Bug 23591: Hide archived suggestions

However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95519|0   |1
is obsolete||

--- Comment #12 from Séverine Queune  ---
Created attachment 95601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95601&action=edit
Bug 23591: Display a new "Suggestion detail" tab on the bib detail page

This patch adds a new "Suggestion detail" tab on the bibliographic
detail page. It will help suggestion management.

Test plan:
- Create several suggestions for a given biblio
- Go to the detail page of the bibliographic record and confirm that
there is a new "Suggestion detail" tab with all the suggestions you
created.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95518|0   |1
is obsolete||

--- Comment #11 from Séverine Queune  ---
Created attachment 95600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95600&action=edit
Bug 23591: Add some useful methods to Koha::Suggestions

Those are methods initially written for bug 23991. I finally need them
before than expected.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #10 from Séverine Queune  ---
No problem for me, just wanted to be sure :)
Let's go for signing !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #9 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #8)
> A detail but I need to ask...
> On the message "There is one archived suggestion.", "one" is written in full
> letters, but when there are more suggestions, numbers are used.
> Do you want to keep these different forms ?

I will let that for someone else. It makes sense to me to have it like that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #8 from Séverine Queune  ---
A detail but I need to ask...
On the message "There is one archived suggestion.", "one" is written in full
letters, but when there are more suggestions, numbers are used.
Do you want to keep these different forms ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #7 from Jonathan Druart  
---
Created attachment 95579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95579&action=edit
Bug 23591: Hide archived suggestions

However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||24068


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068
[Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #6 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #5)
> What about the archived suggestions? Do we want to display or hide them? Or
> maybe a show/hide link on top of the table?

After consulting the users, to not display the archives suggestions by default,
but using a link, seems more useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

URL||https://gitlab.com/joubu/Ko
   ||ha/commits/bug_23591

--- Comment #5 from Jonathan Druart  
---
What about the archived suggestions? Do we want to display or hide them? Or
maybe a show/hide link on top of the table?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #2 from Jonathan Druart  
---
Created attachment 95519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95519&action=edit
Bug 23591: Display a new "Suggestion detail" tab on the bib detail page

This patch adds a new "Suggestion detail" tab on the bibliographic
detail page. It will help suggestion management.

Test plan:
- Create several suggestions for a given biblio
- Go to the detail page of the bibliographic record and confirm that
there is a new "Suggestion detail" tab with all the suggestions you
created.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #4 from Jonathan Druart  
---
Created attachment 95521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95521&action=edit
Bug 23591: [DO NOT PUSH] CSS Changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #3 from Jonathan Druart  
---
Created attachment 95520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95520&action=edit
Bug 23591: Use same css for suggestion notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

--- Comment #1 from Jonathan Druart  
---
Created attachment 95518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95518&action=edit
Bug 23591: Add some useful methods to Koha::Suggestions

Those are methods initially written for bug 23991. I finally need them
before than expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||22784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784
[Bug 22784] Archiving Purchase Suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record

2019-09-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|--- |Seeking developer

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/