[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Myka Kennedy Stephens changed: What|Removed |Added CC||n...@bywatersolution

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Blocks||25874 --- Comment #60 fro

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #59 from Aleisha Amohia --- (In reply to Kyle M Hall from comment #58) > I believe you can safely ignore those errors. If we want to get pedantic, we > should probably fix the ProhibitExplicitReturnUndef warning on a new

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #58 from Kyle M Hall --- (In reply to Aleisha Amohia from comment #57) > Hey Kyle, can you please take a look at Joy's comment above about qa tests > so I can backport to 19.11.x? I believe you can safely ignore those er

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Hannah Olsen changed: What|Removed |Added CC||hol...@duncanville.com -- Y

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00 released in|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 rele

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #51 from Kyle M Hall --- Created attachment 104784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104784&action=edit [19.11.x] Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Ma

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #53 from Kyle M Hall --- Created attachment 104786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104786&action=edit [19.11.x] Bug 23727: (QA follow-up) Fix script tags Signed-off-by: Marcel de Rooy

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #54 from Kyle M Hall --- Created attachment 104787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104787&action=edit [19.11.x] Bug 23727: (QA follow-up) Fix for boolean flags Signed-off-by: Marcel de R

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #52 from Kyle M Hall --- Created attachment 104785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104785&action=edit [19.11.x] Bug 23727: Editing course reserve items is broken Adding an item to course

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #49 from Kyle M Hall --- Created attachment 104782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104782&action=edit [19.11.x] Bug 23727: Add new columns Signed-off-by: Martin Renvoize Signed-off-by:

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #50 from Kyle M Hall --- Created attachment 104783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104783&action=edit [19.11.x] Bug 23727: Update Schema Signed-off-by: Martin Renvoize Signed-off-by: M

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Blocks||25444 Referenced Bugs: h

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Blocks||24772 Referenced Bugs: h

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate,| |RM_pr

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #47 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing li

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #103128|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #103127|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #99332|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #103126|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #99331|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #99333|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are rece

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #40 from Marcel de Rooy --- Generally, we are doing refactoring here and resolving a critical bug. We should not. To resolve a critical, I do not expect 876 insertions(+), 172 deletions. Test Plan: 1) Apply this patch 2)

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #39 fr

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #37 from Jonathan Druart --- Created attachment 103127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103127&action=edit Bug 23727: (QA follow-up) Fix script tags -- You are receiving this mail becau

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #38 from Jonathan Druart --- Created attachment 103128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103128&action=edit Bug 23727: (QA follow-up) Fix for boolean flags -- You are receiving this mail

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Attachment #99334|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are re

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communi

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #35 from Kyle M Hall --- > Kyle, did you track down which patch (bug number) broke the original feature? I did not, considering it's always been broken to some extent ( though not as badly as it is now in master ). I dec

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #34 from Jonathan Druart --- (In reply to Kyle M Hall from comment #7) > (In reply to Jonathan Druart from comment #6) > > Kyle, any ideas about how we could fix this correctly? > > Something bad has happened to CourseR

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Keywords||RM_priority -- You are r

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #31 from Martin Renvoize --- Created attachment 99335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99335&action=edit Bug 23727: (QA follow-up) Fix script tags -- You are receiving this mail because:

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #32 from Martin Renvoize --- Created attachment 99336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99336&action=edit Bug 23727: (QA follow-up) Fix for boolean flags -- You are receiving this mail be

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99330|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99329|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99328|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99327|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99277|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99275|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99273|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99274|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #22 from Martin Renvoize --- Just testing this now.. so far so good -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-b

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #99276|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #20 from Kyle M Hall --- Created attachment 99276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99276&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves an

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #19 from Kyle M Hall --- Created attachment 99275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99275&action=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this ma

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #18 from Kyle M Hall --- Created attachment 99274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99274&action=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #99269|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #15 from Kyle M Hall --- Created attachment 99271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99271&action=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this ma

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #14 from Kyle M Hall --- Created attachment 99270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99270&action=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #16 from Kyle M Hall --- Created attachment 99272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99272&action=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves an

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #98943|0 |1 is obsolete|

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are rec

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #12 from Kyle M Hall --- Follow work at: https://github.com/bywatersolutions/bywater-koha-devel/commits/bug_23727 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug chang

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #11 from Kyle M Hall --- Created attachment 98945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98945&action=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this ma

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #10 from Kyle M Hall --- Created attachment 98944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98944&action=edit Bug 23727: Update Schema -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #9 from Kyle M Hall --- Created attachment 98943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98943&action=edit Bug 23727: Add new columns -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #8 from Kyle M Hall --- I'm wondering if we should have the course items editor *only* update the course items table and *never* the items table. That would also mean disabling the ability to edit course items on active c

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > Kyle, any ideas about how we could fix this correctly? Something bad has happened to CourseReserves::_UpdateCourseItem. This function should check t

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Severity|blocker |critical -- You are rece

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Severity|major |blocker --- Comment #5 fro

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #4 from Katrin Fischer --- Created attachment 95104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95104&action=edit PDF highlighting the problematic behaviour -- You are receiving this mail because:

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #3 from Jonathan Druart --- It changes the values of the item. I am just saying that it seems it always worked that way :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #2 from Katrin Fischer --- I don't agree, the GUI suggests otherwiese: We have an "Edit" button. If you can't change those values, we should not be offering them. -- You are receiving this mail because: You are the assi

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 23727] Editing course reserve items is broken

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Blocks||22630 Referenced Bugs: h