[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Myka Kennedy Stephens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #61 from Myka Kennedy Stephens --- *** Bug 20283 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Blocks||25874 --- Comment #60 from Jonathan Druart --- (In reply to Kyle M Hall from comment #58) > (In reply to Aleisha Amohia from comment #57) > > Hey Kyle, can you please take a look at Joy's comment above about qa tests > > so I can backport to 19.11.x? > > I believe you can safely ignore those errors. If we want to get pedantic, we > should probably fix the ProhibitExplicitReturnUndef warning on a new bug > report, as that same code is in master. I have opened bug 25874. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 [Bug 25874] Explicit return of undef in C4/CourseReserves.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #59 from Aleisha Amohia --- (In reply to Kyle M Hall from comment #58) > I believe you can safely ignore those errors. If we want to get pedantic, we > should probably fix the ProhibitExplicitReturnUndef warning on a new bug > report, as that same code is in master. No worries then, I won't backport it. We probably should fix the warning anyway :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #58 from Kyle M Hall --- (In reply to Aleisha Amohia from comment #57) > Hey Kyle, can you please take a look at Joy's comment above about qa tests > so I can backport to 19.11.x? I believe you can safely ignore those errors. If we want to get pedantic, we should probably fix the ProhibitExplicitReturnUndef warning on a new bug report, as that same code is in master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #57 from Aleisha Amohia --- Hey Kyle, can you please take a look at Joy's comment above about qa tests so I can backport to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Hannah Olsen changed: What|Removed |Added CC||hol...@duncanville.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00 released in|| --- Comment #56 from Joy Nelson --- Correction. Revert the backport of this due to QA failures in backport. Most are pod coverage except for the first error. see below FAIL C4/CourseReserves.pm FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL Koha/Course.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid FAIL Koha/Course/Instructor.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid OK Koha/Course/Instructors.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Course/Item.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Course/Items.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL Koha/Course/Reserve.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #55 from Joy Nelson --- Thanks for the rebase. Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #51 from Kyle M Hall --- Created attachment 104784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104784=edit [19.11.x] Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #53 from Kyle M Hall --- Created attachment 104786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104786=edit [19.11.x] Bug 23727: (QA follow-up) Fix script tags Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #54 from Kyle M Hall --- Created attachment 104787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104787=edit [19.11.x] Bug 23727: (QA follow-up) Fix for boolean flags Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #52 from Kyle M Hall --- Created attachment 104785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104785=edit [19.11.x] Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #49 from Kyle M Hall --- Created attachment 104782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104782=edit [19.11.x] Bug 23727: Add new columns Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #50 from Kyle M Hall --- Created attachment 104783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104783=edit [19.11.x] Bug 23727: Update Schema Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Blocks||25444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 [Bug 25444] Before and course reserve values are not correctly shown -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #48 from Joy Nelson --- Kyle-My rebase failed spectacularly. Can you rebase for 19.11.x? Thanks joy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Blocks||24772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate,| |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #47 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #103128|0 |1 is obsolete|| --- Comment #46 from Marcel de Rooy --- Created attachment 103136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103136=edit Bug 23727: (QA follow-up) Fix for boolean flags Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #103127|0 |1 is obsolete|| --- Comment #45 from Marcel de Rooy --- Created attachment 103135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103135=edit Bug 23727: (QA follow-up) Fix script tags Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #99332|0 |1 is obsolete|| --- Comment #42 from Marcel de Rooy --- Created attachment 103132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103132=edit Bug 23727: Update Schema Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #103126|0 |1 is obsolete|| --- Comment #44 from Marcel de Rooy --- Created attachment 103134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103134=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #99333|0 |1 is obsolete|| --- Comment #43 from Marcel de Rooy --- Created attachment 103133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103133=edit Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Attachment #99331|0 |1 is obsolete|| --- Comment #41 from Marcel de Rooy --- Created attachment 103131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103131=edit Bug 23727: Add new columns Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727
--- Comment #40 from Marcel de Rooy ---
Generally, we are doing refactoring here and resolving a critical bug. We
should not. To resolve a critical, I do not expect 876 insertions(+), 172
deletions.
Test Plan:
1) Apply this patch
2) Add and edit course items, not the new checkboxes for enabling fields
3) Everything should function as before
Rather thin test plan for 800+ lines ?
As mentioned on IRC, would have been nice to get a librarian signoff (who knows
the topic) for a patch set of this size (instead of the RM now).
Glancing through the code:
C4 CourseReserves
+my $course = Koha::Courses->find( $course_id );
$course->{'instructors'} = $sth->fetchall_arrayref( {} );
=> This is a weird way of mixing Koha Objects / DBIx and old school DBI.
"the new storage columns store the original item value"
The name field_storage is not clear to me right away. If you mean original
value, we could think of a better name? No blocker.
itype_enabled = 'no'
`itype_enabled` tinyint(1)
Came across that somewhere. Looks odd.
+UPDATE course_items SET
+itype = IF( itype_enabled = 'no', NULL, itype ),
+ccode = IF( ccode_enabled = 'no', NULL, ccode ),
+holdingbranch = IF( holdingbranch_enabled = 'no', NULL,
holdingbranch ),
+location = IF( location_enabled = 'no', NULL, location )
+WHERE enabled = 'no';
The course_items table has a field enabled (enum yes no).
Does this field need to be there? If an item is enabled, it is in the table,
right? When I remove it from the course, the record is gone.
Interface for add_items. The meaning of the checkbox is not obvious.
Conclusion: I should probably set it to Failed QA, which I wont. Since we are
on a critical here and it seems to work now, I am passing QA. But note that
this area needs more work. Please provide feedback to questions raised.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #39 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #37 from Jonathan Druart --- Created attachment 103127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103127=edit Bug 23727: (QA follow-up) Fix script tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #38 from Jonathan Druart --- Created attachment 103128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103128=edit Bug 23727: (QA follow-up) Fix for boolean flags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Attachment #99334|0 |1 is obsolete|| Attachment #99335|0 |1 is obsolete|| Attachment #99336|0 |1 is obsolete|| --- Comment #36 from Jonathan Druart --- Created attachment 103126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103126=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20107 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24772 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #35 from Kyle M Hall --- > Kyle, did you track down which patch (bug number) broke the original feature? I did not, considering it's always been broken to some extent ( though not as badly as it is now in master ). I decided to push forward with a more 'correct' fix, rather that revert to past behavior which, while somewhat functional, was still broken as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #34 from Jonathan Druart --- (In reply to Kyle M Hall from comment #7) > (In reply to Jonathan Druart from comment #6) > > Kyle, any ideas about how we could fix this correctly? > > Something bad has happened to CourseReserves::_UpdateCourseItem. This > function should check to see if the course is active. If it is inactive, it > should edit the values in the course_items table, if it is active, it should > edit the values in the items table. In master, it *always* edits the items > table, and there is no way to ever update the course_items table no matter > if the course is active or inactive! > > This is appears to be a deeper more problematic issue than the stated one > though. I think the solution for the "Unchanged" issue is to add a > 'use/ignore' column for each of the swappable columns (itype_enabled, > ccode_enabled, etc), along with a checkbox in the editor to enable them. > > This would solves the original issue, that "Unchanged" as a value has been > unreliable and weird. The module was first written without the expectation > that a library would want an item column to be undef while *not* on course > reserve, and have a value while *on* course reserve. Undef was used to > signify the "Leave unchanged" status. It seems that after solving the more > pressing issue above, moving the swap-ability indicator to it's own column > would be the once-and-for-all solution to this problem. Kyle, did you track down which patch (bug number) broke the original feature? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #33 from Martin Renvoize --- Works as expected, Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #31 from Martin Renvoize --- Created attachment 99335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99335=edit Bug 23727: (QA follow-up) Fix script tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #32 from Martin Renvoize --- Created attachment 99336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99336=edit Bug 23727: (QA follow-up) Fix for boolean flags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99330|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 99334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99334=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99329|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 99333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99333=edit Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99328|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 99332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99332=edit Bug 23727: Update Schema Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99327|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 99331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99331=edit Bug 23727: Add new columns Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99277|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 99330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99330=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99275|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 99329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99329=edit Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99273|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 99327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99327=edit Bug 23727: Add new columns Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Attachment #99274|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 99328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99328=edit Bug 23727: Update Schema Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #22 from Martin Renvoize --- Just testing this now.. so far so good -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #99276|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 99277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99277=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #20 from Kyle M Hall --- Created attachment 99276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99276=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #19 from Kyle M Hall --- Created attachment 99275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99275=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #18 from Kyle M Hall --- Created attachment 99274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99274=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #99269|0 |1 is obsolete|| Attachment #99270|0 |1 is obsolete|| Attachment #99271|0 |1 is obsolete|| Attachment #99272|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 99273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99273=edit Bug 23727: Add new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #15 from Kyle M Hall --- Created attachment 99271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99271=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #14 from Kyle M Hall --- Created attachment 99270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99270=edit Bug 23727: Update Schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #16 from Kyle M Hall --- Created attachment 99272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99272=edit Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Attachment #98943|0 |1 is obsolete|| Attachment #98944|0 |1 is obsolete|| Attachment #98945|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 99269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99269=edit Bug 23727: Add new columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #12 from Kyle M Hall --- Follow work at: https://github.com/bywatersolutions/bywater-koha-devel/commits/bug_23727 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #11 from Kyle M Hall --- Created attachment 98945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98945=edit Bug 23727: Add Koha Object(s) related to course reserves -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #10 from Kyle M Hall --- Created attachment 98944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98944=edit Bug 23727: Update Schema -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #9 from Kyle M Hall --- Created attachment 98943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98943=edit Bug 23727: Add new columns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #8 from Kyle M Hall --- I'm wondering if we should have the course items editor *only* update the course items table and *never* the items table. That would also mean disabling the ability to edit course items on active course reserve. This could make the system more understandable, though less flexible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > Kyle, any ideas about how we could fix this correctly? Something bad has happened to CourseReserves::_UpdateCourseItem. This function should check to see if the course is active. If it is inactive, it should edit the values in the course_items table, if it is active, it should edit the values in the items table. In master, it *always* edits the items table, and there is no way to ever update the course_items table no matter if the course is active or inactive! This is appears to be a deeper more problematic issue than the stated one though. I think the solution for the "Unchanged" issue is to add a 'use/ignore' column for each of the swappable columns (itype_enabled, ccode_enabled, etc), along with a checkbox in the editor to enable them. This would solves the original issue, that "Unchanged" as a value has been unreliable and weird. The module was first written without the expectation that a library would want an item column to be undef while *not* on course reserve, and have a value while *on* course reserve. Undef was used to signify the "Leave unchanged" status. It seems that after solving the more pressing issue above, moving the swap-ability indicator to it's own column would be the once-and-for-all solution to this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #6 from Jonathan Druart --- Kyle, any ideas about how we could fix this correctly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Severity|blocker |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Severity|major |blocker --- Comment #5 from Katrin Fischer --- Updating to blocker, as this ends in data loss (original item values can't be restored) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #4 from Katrin Fischer --- Created attachment 95104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95104=edit PDF highlighting the problematic behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #3 from Jonathan Druart --- It changes the values of the item. I am just saying that it seems it always worked that way :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #2 from Katrin Fischer --- I don't agree, the GUI suggests otherwiese: We have an "Edit" button. If you can't change those values, we should not be offering them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- itype, ccode and holdingbranch from the course_items table can only be set on adding a reserve. At first glance I'd say it is the expected behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer changed: What|Removed |Added Blocks||22630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 [Bug 22630] Allow to change homebranch in course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
