https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Martin Renvoize changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Joy Nelson changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Agustín Moyano changed:
What|Removed |Added
Blocks||24432
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #50 from Martin Renvoize ---
Followup pushed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #49 from Tomás Cohen Arazi ---
Created attachment 97391
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97391=edit
Bug 23893: Special care for booleans
This patch acknowledges the fact that in D8 the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Martin Renvoize changed:
What|Removed |Added
Component|Architecture, internals,|REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Text to go in the||This development
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #47 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_target|release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #44 from Kyle M Hall ---
Created attachment 96935
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96935=edit
Bug 23893: (QA follow-up) Explicit date format
This patch makes the input date format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #45 from Kyle M Hall ---
Created attachment 96936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96936=edit
Bug 23893: Remove Overloaded method from Koha::Patron
That way we are dealing with any date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #46 from Kyle M Hall ---
Created attachment 96937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96937=edit
Bug 23893: Catch dt_from_string exceptions
This patch adds exception handling to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #43 from Kyle M Hall ---
Created attachment 96934
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96934=edit
Bug 23893: No special care for booleans
Tests pass without that changes. If we need them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #42 from Kyle M Hall ---
Created attachment 96933
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96933=edit
Bug 23893: Use in /patrons
This patch makes the patrons endpoint use the new methods from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #40 from Kyle M Hall ---
Created attachment 96931
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96931=edit
Bug 23893: Add new_from_api and set_from_api to Koha::Object
This patch introduces the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Kyle M Hall changed:
What|Removed |Added
Attachment #96920|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #39 from Kyle M Hall ---
Created attachment 96930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96930=edit
Bug 23893: Implement Koha::Object->from_api_mapping
This patch implements the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #41 from Kyle M Hall ---
Created attachment 96932
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96932=edit
Bug 23893: Use in /cities
This patch makes the cities controller use the new methods from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #37 from Kyle M Hall ---
Created attachment 96928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96928=edit
Bug 23893: Catch dt_from_string exceptions
This patch adds exception handling to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #36 from Kyle M Hall ---
Created attachment 96927
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96927=edit
Bug 23893: Remove Overloaded method from Koha::Patron
That way we are dealing with any date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #35 from Kyle M Hall ---
Created attachment 96926
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96926=edit
Bug 23893: (QA follow-up) Explicit date format
This patch makes the input date format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #33 from Kyle M Hall ---
Created attachment 96924
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96924=edit
Bug 23893: Use in /patrons
This patch makes the patrons endpoint use the new methods from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #34 from Kyle M Hall ---
Created attachment 96925
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96925=edit
Bug 23893: No special care for booleans
Tests pass without that changes. If we need them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #32 from Kyle M Hall ---
Created attachment 96923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96923=edit
Bug 23893: Use in /cities
This patch makes the cities controller use the new methods from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #30 from Kyle M Hall ---
Created attachment 96921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96921=edit
Bug 23893: Implement Koha::Object->from_api_mapping
This patch implements the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #31 from Kyle M Hall ---
Created attachment 96922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96922=edit
Bug 23893: Add new_from_api and set_from_api to Koha::Object
This patch introduces the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Kyle M Hall changed:
What|Removed |Added
Attachment #96655|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||24321
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||24228
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #28 from Tomás Cohen Arazi ---
Created attachment 9
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9=edit
Bug 23893: Catch dt_from_string exceptions
This patch adds exception handling to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #27 from Tomás Cohen Arazi ---
Created attachment 96665
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96665=edit
Bug 23893: Remove Overloaded method from Koha::Patron
That way we are dealing with any
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96662|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #26 from Jonathan Druart
---
Created attachment 96662
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96662=edit
Bug 23893: Remove Overloaded method from Koha::Patron
That way we are dealing with any
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #25 from Tomás Cohen Arazi ---
Created attachment 96661
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96661=edit
Bug 23893: (QA follow-up) Explicit date format
This patch makes the input date format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #23 from Tomás Cohen Arazi ---
Created attachment 96659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96659=edit
Bug 23893: Use in /patrons
This patch makes the patrons endpoint use the new methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #20 from Tomás Cohen Arazi ---
Created attachment 96656
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96656=edit
Bug 23893: Implement Koha::Object->from_api_mapping
This patch implements the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #24 from Tomás Cohen Arazi ---
Created attachment 96660
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96660=edit
Bug 23893: No special care for booleans
Tests pass without that changes. If we need
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #21 from Tomás Cohen Arazi ---
Created attachment 96657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96657=edit
Bug 23893: Add new_from_api and set_from_api to Koha::Object
This patch introduces the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #22 from Tomás Cohen Arazi ---
Created attachment 96658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96658=edit
Bug 23893: Use in /cities
This patch makes the cities controller use the new methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #19 from Tomás Cohen Arazi ---
Created attachment 96655
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96655=edit
Bug 23893: Unit tests
This patch introduces tests for the implemented methods.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96127|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96126|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96652|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96130|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #96128|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #18 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #17)
> Do we really need the cache mechanism (_from_api_mapping)?
I'm not sure. My way of thinking was if someone needs it, we need to calculate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #17 from Jonathan Druart
---
Do we really need the cache mechanism (_from_api_mapping)?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #16 from Jonathan Druart
---
Created attachment 96652
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96652=edit
Bug 23893: No special care for booleans
Tests pass without that changes. If we need
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #15 from Jonathan Druart
---
Please move attributes_from_api to a better please (not after AUTOLOAD). Before
internals methods seems better (please amend the patch)
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||24225
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Josef Moravec changed:
What|Removed |Added
Attachment #95313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Josef Moravec changed:
What|Removed |Added
Attachment #95311|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Josef Moravec changed:
What|Removed |Added
Attachment #95315|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Josef Moravec changed:
What|Removed |Added
Attachment #95312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Josef Moravec changed:
What|Removed |Added
Attachment #95314|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_05_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #9 from Tomás Cohen Arazi ---
Created attachment 95315
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95315=edit
Bug 23893: Use in /patrons
This patch makes the patrons endpoint use the new methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #8 from Tomás Cohen Arazi ---
Created attachment 95314
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95314=edit
Bug 23893: Use in /cities
This patch makes the cities controller use the new methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #7 from Tomás Cohen Arazi ---
Created attachment 95313
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95313=edit
Bug 23893: Add new_from_api and set_from_api to Koha::Object
This patch introduces the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 95312
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95312=edit
Bug 23893: Implement Koha::Object->from_api_mapping
This patch implements the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #5 from Tomás Cohen Arazi ---
Created attachment 95311
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95311=edit
Bug 23893: Unit tests
This patch introduces tests for the implemented methods.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #95278|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #95277|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #95276|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #4 from Tomás Cohen Arazi ---
I want to hear your opinions, I'm not feeling comfortable with this, looking at
cleaning Koha::REST::V1::Patrons with this makes me wonder if it is falling
short.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 95278
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95278=edit
Bug 23893: Add new_from_api and set_from_api to Koha::Object
This patch introduces the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 95277
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95277=edit
Bug 23893: Implement Koha::Object->from_api_mapping
This patch implements the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 95276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95276=edit
Bug 23893: Unit tests
This patch introduces tests for the implemented methods.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
77 matches
Mail list logo