[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2020-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)|20.05.00|19.11.00 20.05.00
released in||

--- Comment #23 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #22)
> Nice work everyone!
> 
> Pushed to master for 20.05

Should not have been pushed regarding my last 2 comments :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2020-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #22 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2020-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|19.11.00|20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2020-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24677

--- Comment #21 from Jonathan Druart  
---
Follow-up patch moved to bug 24677.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24677
[Bug 24677] wrong year picked in serials
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #20 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #19)
> Created attachment 99118 [details] [review]
> Bug 24002: (follow-up) Incorrect DATE value: '00-00-' in C4/Serials.pm
> 
> Oops, wrong copy/paste here! The column order changes was not expected.

Sorry, it's part of 19.11, I will open a new bug report tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #19 from Jonathan Druart  
---
Created attachment 99118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99118&action=edit
Bug 24002: (follow-up) Incorrect DATE value: '00-00-' in C4/Serials.pm

Oops, wrong copy/paste here! The column order changes was not expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030
[Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT
list"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|24030   |
 Depends on||24030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030
[Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT
list"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||24029


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029
[Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE
value: '01e'"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #18 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #17 from Martin Renvoize  ---
Trivial patches, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #16 from Martin Renvoize  ---
So really we shouldn't have any left around already. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #15 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #14)
> Minor concern is whether we might be missing some DB updates to ensure all
> tables are filled with expected data to start with..

Hum actually it's too late. We cannot longer write such query:

  update opac_news set expirationdate=NULL WHERE expirationdate="-00-00";

As it will fail:
ERROR 1292 (22007): Incorrect date value: '-00-00' for column
'expirationdate' at row 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Needs Signoff   |Signed Off

--- Comment #14 from Martin Renvoize  ---
Ran tests again M8, saw failures.. applied patches and re-ran tests, full Pass.

Looks good, signing off.

Minor concern is whether we might be missing some DB updates to ensure all
tables are filled with expected data to start with..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #95220|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 95227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95227&action=edit
Bug 24002: Incorrect DATE value: '' in C4/Acquisition.pm

DBD::mysql::st execute failed: Incorrect DATE value: '' [for Statement "
SELECT aqbasket.basketno,
aqorders.ordernumber,
DATE(aqbasket.closedate)  AS orderdate,
aqbasket.basketname   AS basketname,
aqbasket.basketgroupidAS basketgroupid,
aqbasketgroups.name   AS basketgroupname,
aqorders.rrp  AS unitpricesupplier,
aqorders.ecostAS unitpricelib,
aqorders.claims_count AS claims_count,
aqorders.claimed_date AS claimed_date,
aqbudgets.budget_name AS budget,
borrowers.branchcode  AS branch,
aqbooksellers.nameAS supplier,
aqbooksellers.id  AS supplierid,
biblio.author, biblio.title,
biblioitems.publishercode AS publisher,
biblioitems.publicationyear,
ADDDATE(aqbasket.closedate, INTERVAL aqbooksellers.deliverytime DAY) AS
estimateddeliverydate,

aqorders.quantity - COALESCE(aqorders.quantityreceived,0)  
  AS quantity,
(aqorders.quantity - COALESCE(aqorders.quantityreceived,0)) *
aqorders.rrp AS subtotal,
DATEDIFF(CAST(now() AS date),closedate) AS latesince

FROM
aqorders LEFT JOIN biblio ON biblio.biblionumber =
aqorders.biblionumber
LEFT JOIN biblioitems ON biblioitems.biblionumber=
biblio.biblionumber
LEFT JOIN aqbudgets   ON aqorders.budget_id  =
aqbudgets.budget_id,
aqbasket LEFT JOIN borrowers  ON aqbasket.authorisedby   =
borrowers.borrowernumber
LEFT JOIN aqbooksellers   ON aqbasket.booksellerid   =
aqbooksellers.id
LEFT JOIN aqbasketgroups  ON aqbasket.basketgroupid  =
aqbasketgroups.id
WHERE aqorders.basketno = aqbasket.basketno
AND ( datereceived = ''
OR datereceived IS NULL
OR aqorders.quantityreceived < aqorders.quantity
)
AND aqbasket.closedate IS NOT NULL
AND aqorders.datecancellationprinted IS NULL
 AND (closedate <= DATE_SUB(CAST(now() AS date),INTERVAL ? DAY))  AND
aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0 AND orderstatus
<> 'cancelled'
ORDER BY latesince, basketno, borrowers.branchcode, supplier" with ParamValues:
0=0] at /kohadevbox/koha/C4/Acquisition.pm line 2248.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #95218|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 95225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95225&action=edit
Bug 24002: Incorrect DATE value: '00-00-' in C4/Serials.pm

t/db_dependent/Biblio.t .. 2/12 DBD::mysql::st execute failed: Incorrect DATE
value: '00-00-' [for Statement "
  SELECTserial.serialid,
serial.serialseq,
serial.planneddate,
serial.publisheddate,
serial.publisheddatetext,
serial.status,
serial.notes as notes,
   
year(IF(serial.publisheddate="00-00-",serial.planneddate,serial.publisheddate))
as year,
biblio.title as bibliotitle,
subscription.branchcode AS branchcode,
subscription.subscriptionid AS subscriptionid
  FROM  serial
  LEFT JOIN subscription ON
  (serial.subscriptionid=subscription.subscriptionid)
  LEFT JOIN aqbooksellers on subscription.aqbooksellerid=aqbooksellers.id
  LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber
  WHERE subscription.biblionumber = ?
  ORDER BY year DESC,
 
IF(serial.publisheddate="00-00-",serial.planneddate,serial.publisheddate)
DESC,
  serial.subscriptionid
  " with ParamValues: 0='446'] at /kohadevbox/koha/C4/Serials.pm line
482.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #95219|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 95226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95226&action=edit
Bug 24002: Incorrect DATE value: '-00-00' in C4/Acquisition.pm

t/db_dependent/Acquisition/close_reopen_basket.t .. DBD::mysql::st execute
failed: Incorrect DATE value: '-00-00' [for Statement "
SELECT COUNT( DISTINCT( biblionumber ) )
FROM   aqorders
WHERE  basketno = ?
AND (datecancellationprinted IS NULL OR
datecancellationprinted='-00-00')
" with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line
3012.
DBD::mysql::st execute failed: Incorrect DATE value: '-00-00' [for
Statement "
SELECT COUNT( DISTINCT( biblionumber ) )
FROM   aqorders
WHERE  basketno = ?
AND (datecancellationprinted IS NULL OR
datecancellationprinted='-00-00')
" with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line
3012.

And anticipating other failures

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #95216|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 95223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95223&action=edit
Bug 24002: Incorrect DATE value: '' in C4/Bookseller.pm

t/db_dependent/Bookseller.t .. 3/86 DBD::mysql::st execute failed: Incorrect
DATE value: '' [for Statement "
SELECT DISTINCT aqbasket.booksellerid, aqbooksellers.name
FROM aqorders LEFT JOIN aqbasket ON aqorders.basketno=aqbasket.basketno
LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id
WHERE
( datereceived = ''
OR datereceived IS NULL
OR aqorders.quantityreceived < aqorders.quantity
)
AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0
AND aqbasket.closedate IS NOT NULL
"] at /kohadevbox/koha/C4/Bookseller.pm line 100.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #95217|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 95224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95224&action=edit
Bug 24002: Incorrect DATE value: '-00-00' in C4/Serials.pm

DBD::mysql::st execute failed: Incorrect DATE value: '-00-00' [for
Statement "SELECT   serialid,serialseq, status, planneddate, publisheddate,
publisheddatetext, notes, routingnotes
   FROM serial
   WHEREsubscriptionid = ?
   AND  status IN ( 2,4,41,42,43,44,5 )
   ORDER BY IF(publisheddate<>'-00-00',publisheddate,planneddate) DESC
  " with ParamValues: 0=8] at /kohadevbox/koha/C4/Serials.pm line 688.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #95215|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 95222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95222&action=edit
Bug 24002: Incorrect DATE value: '00-00-' in NewsChannels.pm

% prove  xt/author/valid-templates.t

DBD::mysql::st execute failed: Incorrect DATE value: '00-00-' [for
Statement "
 SELECT opac_news.*,timestamp AS newdate,
 borrowers.title AS author_title,
 borrowers.firstname AS author_firstname,
 borrowers.surname AS author_surname
 FROM   opac_news
 LEFT JOIN borrowers on borrowers.borrowernumber = opac_news.borrowernumber
 WHERE   (
expirationdate >= CURRENT_DATE()
ORexpirationdate IS NULL
ORexpirationdate = '00-00-'
 )
 AND   DATE(timestamp) < DATE_ADD(CURDATE(), INTERVAL 1 DAY)
 AND   (opac_news.lang = '' OR opac_news.lang = ?)
 AND   (opac_news.branchcode IS NULL OR opac_news.branchcode = ?)
 ORDER BY number
" with ParamValues: 0='OpacNavRight_', 1=''] at
/kohadevbox/koha/C4/NewsChannels.pm line 216.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #7 from Jonathan Druart  
---
Created attachment 95221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95221&action=edit
Bug 24002: One more occurrence of datecancellationprinted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #5 from Jonathan Druart  
---
Created attachment 95219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95219&action=edit
Bug 24002: Incorrect DATE value: '-00-00' in C4/Acquisition.pm

t/db_dependent/Acquisition/close_reopen_basket.t .. DBD::mysql::st execute
failed: Incorrect DATE value: '-00-00' [for Statement "
SELECT COUNT( DISTINCT( biblionumber ) )
FROM   aqorders
WHERE  basketno = ?
AND (datecancellationprinted IS NULL OR
datecancellationprinted='-00-00')
" with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line
3012.
DBD::mysql::st execute failed: Incorrect DATE value: '-00-00' [for
Statement "
SELECT COUNT( DISTINCT( biblionumber ) )
FROM   aqorders
WHERE  basketno = ?
AND (datecancellationprinted IS NULL OR
datecancellationprinted='-00-00')
" with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line
3012.

And anticipating other failures

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #6 from Jonathan Druart  
---
Created attachment 95220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95220&action=edit
Bug 24002: Incorrect DATE value: '' in C4/Acquisition.pm

DBD::mysql::st execute failed: Incorrect DATE value: '' [for Statement "
SELECT aqbasket.basketno,
aqorders.ordernumber,
DATE(aqbasket.closedate)  AS orderdate,
aqbasket.basketname   AS basketname,
aqbasket.basketgroupidAS basketgroupid,
aqbasketgroups.name   AS basketgroupname,
aqorders.rrp  AS unitpricesupplier,
aqorders.ecostAS unitpricelib,
aqorders.claims_count AS claims_count,
aqorders.claimed_date AS claimed_date,
aqbudgets.budget_name AS budget,
borrowers.branchcode  AS branch,
aqbooksellers.nameAS supplier,
aqbooksellers.id  AS supplierid,
biblio.author, biblio.title,
biblioitems.publishercode AS publisher,
biblioitems.publicationyear,
ADDDATE(aqbasket.closedate, INTERVAL aqbooksellers.deliverytime DAY) AS
estimateddeliverydate,

aqorders.quantity - COALESCE(aqorders.quantityreceived,0)  
  AS quantity,
(aqorders.quantity - COALESCE(aqorders.quantityreceived,0)) *
aqorders.rrp AS subtotal,
DATEDIFF(CAST(now() AS date),closedate) AS latesince

FROM
aqorders LEFT JOIN biblio ON biblio.biblionumber =
aqorders.biblionumber
LEFT JOIN biblioitems ON biblioitems.biblionumber=
biblio.biblionumber
LEFT JOIN aqbudgets   ON aqorders.budget_id  =
aqbudgets.budget_id,
aqbasket LEFT JOIN borrowers  ON aqbasket.authorisedby   =
borrowers.borrowernumber
LEFT JOIN aqbooksellers   ON aqbasket.booksellerid   =
aqbooksellers.id
LEFT JOIN aqbasketgroups  ON aqbasket.basketgroupid  =
aqbasketgroups.id
WHERE aqorders.basketno = aqbasket.basketno
AND ( datereceived = ''
OR datereceived IS NULL
OR aqorders.quantityreceived < aqorders.quantity
)
AND aqbasket.closedate IS NOT NULL
AND aqorders.datecancellationprinted IS NULL
 AND (closedate <= DATE_SUB(CAST(now() AS date),INTERVAL ? DAY))  AND
aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0 AND orderstatus
<> 'cancelled'
ORDER BY latesince, basketno, borrowers.branchcode, supplier" with ParamValues:
0=0] at /kohadevbox/koha/C4/Acquisition.pm line 2248.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #4 from Jonathan Druart  
---
Created attachment 95218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95218&action=edit
Bug 24002: Incorrect DATE value: '00-00-' in C4/Serials.pm

t/db_dependent/Biblio.t .. 2/12 DBD::mysql::st execute failed: Incorrect DATE
value: '00-00-' [for Statement "
  SELECTserial.serialid,
serial.serialseq,
serial.planneddate,
serial.publisheddate,
serial.publisheddatetext,
serial.status,
serial.notes as notes,
   
year(IF(serial.publisheddate="00-00-",serial.planneddate,serial.publisheddate))
as year,
biblio.title as bibliotitle,
subscription.branchcode AS branchcode,
subscription.subscriptionid AS subscriptionid
  FROM  serial
  LEFT JOIN subscription ON
  (serial.subscriptionid=subscription.subscriptionid)
  LEFT JOIN aqbooksellers on subscription.aqbooksellerid=aqbooksellers.id
  LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber
  WHERE subscription.biblionumber = ?
  ORDER BY year DESC,
 
IF(serial.publisheddate="00-00-",serial.planneddate,serial.publisheddate)
DESC,
  serial.subscriptionid
  " with ParamValues: 0='446'] at /kohadevbox/koha/C4/Serials.pm line
482.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #2 from Jonathan Druart  
---
Created attachment 95216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95216&action=edit
Bug 24002: Incorrect DATE value: '' in C4/Bookseller.pm

t/db_dependent/Bookseller.t .. 3/86 DBD::mysql::st execute failed: Incorrect
DATE value: '' [for Statement "
SELECT DISTINCT aqbasket.booksellerid, aqbooksellers.name
FROM aqorders LEFT JOIN aqbasket ON aqorders.basketno=aqbasket.basketno
LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id
WHERE
( datereceived = ''
OR datereceived IS NULL
OR aqorders.quantityreceived < aqorders.quantity
)
AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0
AND aqbasket.closedate IS NOT NULL
"] at /kohadevbox/koha/C4/Bookseller.pm line 100.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #3 from Jonathan Druart  
---
Created attachment 95217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95217&action=edit
Bug 24002: Incorrect DATE value: '-00-00' in C4/Serials.pm

DBD::mysql::st execute failed: Incorrect DATE value: '-00-00' [for
Statement "SELECT   serialid,serialseq, status, planneddate, publisheddate,
publisheddatetext, notes, routingnotes
   FROM serial
   WHEREsubscriptionid = ?
   AND  status IN ( 2,4,41,42,43,44,5 )
   ORDER BY IF(publisheddate<>'-00-00',publisheddate,planneddate) DESC
  " with ParamValues: 0=8] at /kohadevbox/koha/C4/Serials.pm line 688.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8

2019-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002

--- Comment #1 from Jonathan Druart  
---
Created attachment 95215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95215&action=edit
Bug 24002: Incorrect DATE value: '00-00-' in NewsChannels.pm

% prove  xt/author/valid-templates.t

DBD::mysql::st execute failed: Incorrect DATE value: '00-00-' [for
Statement "
 SELECT opac_news.*,timestamp AS newdate,
 borrowers.title AS author_title,
 borrowers.firstname AS author_firstname,
 borrowers.surname AS author_surname
 FROM   opac_news
 LEFT JOIN borrowers on borrowers.borrowernumber = opac_news.borrowernumber
 WHERE   (
expirationdate >= CURRENT_DATE()
ORexpirationdate IS NULL
ORexpirationdate = '00-00-'
 )
 AND   DATE(timestamp) < DATE_ADD(CURDATE(), INTERVAL 1 DAY)
 AND   (opac_news.lang = '' OR opac_news.lang = ?)
 AND   (opac_news.branchcode IS NULL OR opac_news.branchcode = ?)
 ORDER BY number
" with ParamValues: 0='OpacNavRight_', 1=''] at
/kohadevbox/koha/C4/NewsChannels.pm line 216.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/