[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #37 from Victor Grousset/tuxayo --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #36 from Tomás Cohen Arazi --- (In reply to Aleisha Amohia from comment #35) > > backported to 19.11.x for 19.11.07 > > (In reply to Tomás Cohen Arazi from comment #34) > > > > - 25237 > > Not this one, as it is still in Needs Signoff. That was some typo, 25327 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in||19.11.07 Status|Pushed to stable|Pushed to oldstable --- Comment #35 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 (In reply to Tomás Cohen Arazi from comment #34) > - 25237 Not this one, as it is still in Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #34 from Tomás Cohen Arazi --- Aleisha, the dependencies, in order are: - 24862 - 25045 - 25237 - 25411 - 24003 They should all apply on 19.11.x and their tests pass. Some (like this one) have their own patch versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Depends on||25411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411 [Bug 25411] Plugin routes cannot have anonymous access -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 106089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106089=edit [19.11.x] Bug 24003: (follow-up) Move interface setting to a more readable place Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 106088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106088=edit [19.11.x] Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 106090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106090=edit [19.11.x] Bug 24003: (follow-up) Add all userenv parameters This patch makes the API set more userenv params than just the borrowernumber. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_* => SUCCESS: All tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 106087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106087=edit [19.11.x] Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #29 from Aleisha Amohia --- doesn't apply cleanly to 19.11.x. please rebase if we want this in 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.01 released in|| --- Comment #28 from Lucas Gass --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #27 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #26 from Martin Renvoize --- This all works well and I can't see any regressions. The followup doesn't seem to do any harm and will future proof us somewhat. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Martin Renvoize changed: What|Removed |Added Attachment #105635|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 105846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105846=edit Bug 24003: (follow-up) Move interface setting to a more readable place Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Martin Renvoize changed: What|Removed |Added Attachment #105634|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 105845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105845=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Martin Renvoize changed: What|Removed |Added Attachment #105666|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 105847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105847=edit Bug 24003: (follow-up) Add all userenv parameters This patch makes the API set more userenv params than just the borrowernumber. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_* => SUCCESS: All tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Martin Renvoize changed: What|Removed |Added Attachment #105633|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 105844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105844=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #21 from Tomás Cohen Arazi --- The bug in stable is that any API interaction (the route /patrons changing data from an external source) ends with action_logs having the responsible for the action not set => bad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 105666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105666=edit Bug 24003: (follow-up) Add all userenv parameters This patch makes the API set more userenv params than just the borrowernumber. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_* => SUCCESS: All tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #19 from Jonathan Druart --- I have no idea which bug in stable we are trying to fix. Where is that describe? We should think "regression proof", if the userenv exists then it should be reliable. Having only the borrowerumber defined seems very wrong to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003
--- Comment #18 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #17)
> Say you are going to implement the DELETE route for items, you will need to
> call Koha::Item->safe_to_delete.
>
> 246 return "not_same_branch"
>
> 247 if defined C4::Context->userenv
>
> 248 and !C4::Context->IsSuperLibrarian()
>
> 249 and C4::Context->preference("IndependentBranches")
> 250 and ( C4::Context->userenv->{branch} ne $self->homebranch );
>
> Don't you want the branch to be defined at this point? Isn't that the
> purpose of this patch?
I'm fixing a current bug on stable branches. If we were to think this in terms
of the project future devs, I would rather stash the full Koha::Patron for the
logged user and get rid of all that cruft we've been porting to Koha::*
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003
--- Comment #17 from Jonathan Druart
---
Say you are going to implement the DELETE route for items, you will need to
call Koha::Item->safe_to_delete.
246 return "not_same_branch"
247 if defined C4::Context->userenv
248 and !C4::Context->IsSuperLibrarian()
249 and C4::Context->preference("IndependentBranches")
250 and ( C4::Context->userenv->{branch} ne $self->homebranch );
Don't you want the branch to be defined at this point? Isn't that the purpose
of this patch?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > Why are you only setting the borrowernumber? On the API, this is only relevant for action_logs and probably filtering in plural classes. If it is going to be used from the UI, then authentication would be cookie-based, which sets all the things anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #15 from Jonathan Druart --- Why are you only setting the borrowernumber? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #14 from Kyle M Hall --- Created attachment 105635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105635=edit Bug 24003: (follow-up) Move interface setting to a more readable place Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #13 from Kyle M Hall --- Created attachment 105634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105634=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Kyle M Hall changed: What|Removed |Added Attachment #105586|0 |1 is obsolete|| Attachment #105587|0 |1 is obsolete|| Attachment #105588|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 105633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105633=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Tomás Cohen Arazi --- I went on and added missing tests in basic auth, and also added a test for an untested feature (C4::Context->interface being set to 'api'). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 105588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105588=edit Bug 24003: (follow-up) Move interface setting to a more readable place Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 105587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105587=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 105586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105586=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105580|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105579|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105581|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95230|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Attachment #95228|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 105581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105581=edit Bug 24003: (follow-up) Basic auth missing tests for stashed user Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 105579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105579=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 105580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105580=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What|Removed |Added Summary|REST API basic auth lacks |REST API should set |C4::Context->userenv|C4::Context->userenv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
