[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Joy Nelson changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||j...@bywatersolutions.com --- Comment #17 from Joy Nelson --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150
--- Comment #15 from Jonathan Druart
---
Created attachment 96897
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96897&action=edit
Bug 24150: Prevent random failure comparing updated_on
Jenkins is currently failing (slow server, datetime comparison, etc.)
koha_1 | # Failed test at t/db_dependent/Koha/Old.t line 48.
koha_1 | # Structures begin differing at:
koha_1 | # $got->{updated_on} = '2020-01-07 14:15:22'
koha_1 | # $expected->{updated_on} = '2020-01-07 14:15:21'
koha_1 | # Looks like you failed 1 test of 1.
koha_1 |
koha_1 | # Failed test 'Koha::Old::Patrons'
koha_1 | # at t/db_dependent/Koha/Old.t line 49.
koha_1 | # Looks like you failed 1 test of 2.
koha_1 | [14:15:22] t/db_dependent/Koha/Old.t
...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #13 from Jonathan Druart --- RMaints: we should not backport this patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Attachment #96867|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 96871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96871&action=edit Bug 24150: Add missing koha_object[s]_class methods and skip for deletedborrowers deletedborrowers does not have a PK, and adding it is out of the scope of this patchset. Indeed we will have to handle possible duplication of borrowernumber values, which does not seem trivial. Having bug 20271 in mind, we will have to deal with this problematic anyway later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #11 from Jonathan Druart --- Tests are failing with: koha_1 | # Failed test 'Testing Koha::Old::Patrons' koha_1 | # at t/db_dependent/TestBuilder.t line 397. koha_1 | # got: '' koha_1 | # expected: 'Koha::Old::Patron' koha_1 | koha_1 | # Failed test 'Module Koha::Old::Patrons should have koha_object[s]_class method if needed' koha_1 | # at t/db_dependent/TestBuilder.t line 399. koha_1 | # got: 'Can't call method "get_from_storage" on an undefined value at t/db_dependent/TestBuilder.t line 398. koha_1 | # ' koha_1 | # expected: '' koha_1 | # Looks like you failed 2 tests of 70. koha_1 | koha_1 | # Failed test 'Test all classes' koha_1 | # at t/db_dependent/TestBuilder.t line 409. koha_1 | # Looks like you planned 5 tests but ran 4. koha_1 | # Looks like you failed 1 test of 4 run. koha_1 | koha_1 | # Failed test 'build_object() tests' koha_1 | # at t/db_dependent/TestBuilder.t line 425. koha_1 | Can't call method "_result" on an undefined value at t/db_dependent/TestBuilder.t line 402. This patch is not enough to fix them, a PK is missing on deletedborrowers, I am going to fix that ASAP, certainly will need to open a new bug report to deal with that. Do not backport! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #10 from Jonathan Druart --- Created attachment 96867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96867&action=edit Bug 24150: Add missing koha_object[s]_class methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Squashed and Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Attachment #96267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #96268|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What|Removed |Added Attachment #96266|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 96428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96428&action=edit Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #5 from Nick Clemens --- Created attachment 96267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96267&action=edit Bug 24150: Add tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #6 from Nick Clemens --- Created attachment 96268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96268&action=edit Bug 24150: fix wrong semicolon Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Nick Clemens changed: What|Removed |Added Attachment #95954|0 |1 is obsolete|| Attachment #95955|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 96266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96266&action=edit Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Blocks||21684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #3 from Jonathan Druart --- Those classes will be used directly from bug 25151. Adding them on a separate bug report in case someone else needs them. There is no useful test plan apart from proving the new tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #1 from Jonathan Druart --- Created attachment 95954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95954&action=edit Bug 24150: Add Koha::Old::*[s] This bug report will add new classes for: * Koha::Old::Patron[s] * Koha::Old::Biblio[s] * Koha::Old::Item[s] * Koha::Old::Biblioitem[s] Sponsored-by: Association KohaLa - https://koha-fr.org/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #2 from Jonathan Druart --- Created attachment 95955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95955&action=edit Bug 24150: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Blocks||24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
