[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #26 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #25 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #24) > Katrin, > I think we should probably open a new report for some of the inconsistencies > between the various acquisitions routes and the use of the ACQ framework. > > It is rather trivial to pass the frameworkcode parameter of > acqui/z3950_search to FillWithDefaults to overrule ACQ. But are we bitten > later on by the preference UseACQFrameworkForBiblioRecords ? The code in > Acquisition is not completely clear as to that preference? Hi Marcel, certainly a new bug. The handling of frameworks (ACQ vs the one selected on import) is not very clear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #24 from Marcel de Rooy --- Katrin, I think we should probably open a new report for some of the inconsistencies between the various acquisitions routes and the use of the ACQ framework. It is rather trivial to pass the frameworkcode parameter of acqui/z3950_search to FillWithDefaults to overrule ACQ. But are we bitten later on by the preference UseACQFrameworkForBiblioRecords ? The code in Acquisition is not completely clear as to that preference? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #23 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #18) > I have another issue tho: We apply the default from the ACQ framework, while > we can specifically choose a framework to import the record in on the > Z39.50/SRU form - this is not caused by this bug, but doesn't make sense to > me. Especially for 942$c it would make a lot of sense to me to set different > default for different frameworks and use them. What do you think, Marcel? Sounds valid, have to check. Getting back to it.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #22 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Katrin Fischer changed: What|Removed |Added Attachment #101439|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 101507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101507&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Bernardo Gonzalez Kriegel Test pass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Katrin Fischer changed: What|Removed |Added Attachment #101438|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 101506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101506&action=edit Bug 24276: Add FillWithDefaultValues call in neworderempty Apply mandatory defaults from the ACQ framework to records from external source in Acquisition. Test plan: [1] Add 'BK' as mandatory default in ACQ framework for 942$c. [2] Add order to basket via external source. [3] Check 942$c on detail page of new record, MARC tab. Signed-off-by: Bernardo Gonzalez Kriegel First added 942 field and subfields to ACQ fw, then followed test plan. wo/patch 942 is not added, w/patch it is. Work as described. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Katrin Fischer changed: What|Removed |Added Attachment #101437|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 101505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101505&action=edit Bug 24276: First change indent No other changes than whitespace, guys. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #18 from Katrin Fischer --- +If the parameter only_mandatory => 1 is passed via $params, only the mandatory +defaults are being applied to the record. For the cataloguing editor it does not matter if the field is mandatory or not. As soon as you set a default, the value will appear in the record. So we are handling things differently here - but we also don't open the record for editing, so this makes sense to me. I have another issue tho: We apply the default from the ACQ framework, while we can specifically choose a framework to import the record in on the Z39.50/SRU form - this is not caused by this bug, but doesn't make sense to me. Especially for 942$c it would make a lot of sense to me to set different default for different frameworks and use them. What do you think, Marcel? Still passing as this is pre-bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100378|0 |1 is obsolete|| --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 101439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101439&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Bernardo Gonzalez Kriegel Test pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100377|0 |1 is obsolete|| --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 101438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101438&action=edit Bug 24276: Add FillWithDefaultValues call in neworderempty Apply mandatory defaults from the ACQ framework to records from external source in Acquisition. Test plan: [1] Add 'BK' as mandatory default in ACQ framework for 942$c. [2] Add order to basket via external source. [3] Check 942$c on detail page of new record, MARC tab. Signed-off-by: Bernardo Gonzalez Kriegel First added 942 field and subfields to ACQ fw, then followed test plan. wo/patch 942 is not added, w/patch it is. Work as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #100376|0 |1 is obsolete|| --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 101437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101437&action=edit Bug 24276: First change indent No other changes than whitespace, guys. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #14 from Marcel de Rooy --- (In reply to Bernardo Gonzalez Kriegel from comment #13) > Hi Marcel, > current ACQ framework does not have tag 942. > Do you think we need to add it and it's subfields? > > Patches applies cleanly, test pass. Thx for testing, Bernardo. No I do not think we should add it on this report per se. Surely, it could be done on its own. But it is a just an example of how we can apply mandatories. Another existing field could be used too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel --- Hi Marcel, current ACQ framework does not have tag 942. Do you think we need to add it and it's subfields? Patches applies cleanly, test pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 --- Comment #12 from Marcel de Rooy --- Rebased. Please test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What|Removed |Added Attachment #96513|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 100378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100378&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What|Removed |Added Attachment #96511|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 100377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100377&action=edit Bug 24276: Add FillWithDefaultValues call in neworderempty Apply mandatory defaults from the ACQ framework to records from external source in Acquisition. Test plan: [1] Add 'BK' as mandatory default in ACQ framework for 942$c. [2] Add order to basket via external source. [3] Check 942$c on detail page of new record, MARC tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What|Removed |Added Attachment #96510|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 100376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100376&action=edit Bug 24276: First change indent No other changes than whitespace, guys. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 David Roberts changed: What|Removed |Added CC|david.roberts@ptfs-europe.c | |om | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 David Roberts changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||david.roberts@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What|Removed |Added Attachment #96512|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 96513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96513&action=edit Bug 24276: Add unit tests for mandatory parameter of FillWithDefaultValues Test plan: Run t/db_dependent/Acquisition/FillWithDefaultValues.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory defaults to records from external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276 Marcel de Rooy changed: What|Removed |Added Summary|Acquisition: Apply |Acquisition: Apply ACQ |framework mandatory |framework mandatory |defaults to records from|defaults to records from |external sources|external sources -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
