[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|20.05.00, 19.11.04  |20.05.00, 19.11.04,
released in||19.05.09

--- Comment #9 from Lucas Gass  ---
backported to 19.05.x for 19.05.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-03-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.04
released in||
 Status|Pushed to master|Pushed to stable
 CC||j...@bywatersolutions.com

--- Comment #8 from Joy Nelson  ---
Pushed to 19.11.x for 19.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

--- Comment #7 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #99117|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 99131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99131&action=edit
Bug 24388: Remove uneeded test in lateorders.tt

The budget_lock is never set (and has never been).

Test plan:
For QAer only, make sure this never worked

Signed-off-by: Bernardo Gonzalez Kriegel 
No errors.
Variable budget_lock is not set in acqui/lateorders.pl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #98690|0   |1
is obsolete||

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Created attachment 99117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99117&action=edit
Bug 24388: Remove uneeded test in lateorders.tt

The budget_lock is never set (and has never been).

Test plan:
For QAer only, make sure this never worked

Signed-off-by: Bernardo Gonzalez Kriegel 
No errors.
Variable budget_lock is not set in acqui/lateorders.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #97125|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 98690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98690&action=edit
Bug 24388: Remove uneeded test in lateorders.tt

The budget_lock is never set (and has never been).

Test plan:
For QAer only, make sure this never worked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24161
 Depends on|24162   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162
[Bug 24162] Late orders improvements - display new columns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-02-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #3 from Jonathan Druart  
---
(In reply to Michal Denar from comment #2)
> Hi Jonathan,
> can you rebase this patch?
> 
> sing index info to reconstruct a base tree...
> M t/db_dependent/Koha/Acquisition/Basket.t
> Falling back to patching base and 3-way merge...
> Auto-merging t/db_dependent/Koha/Acquisition/Basket.t
> CONFLICT (content): Merge conflict in
> t/db_dependent/Koha/Acquisition/Basket.t
> error: Failed to merge in the changes.
> Patch failed at 0001 Bug 24161: Add tests

This patch is at the top of a long dependency list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||blac...@gmail.com

--- Comment #2 from Michal Denar  ---
Hi Jonathan,
can you rebase this patch?

sing index info to reconstruct a base tree...
M   t/db_dependent/Koha/Acquisition/Basket.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/Acquisition/Basket.t
CONFLICT (content): Merge conflict in t/db_dependent/Koha/Acquisition/Basket.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24161: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Jonathan Druart  changed:

   What|Removed |Added

Summary|Unless test in  |Useless test in
   |acqui/lateorders.tt |acqui/lateorders.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/