https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #25 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #24)
> I checked on the use of active_orders_count and it is only used in
> parcel.tt. This all looks okay. Do not allow order cancellation with
> delet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #24 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #22)
> Looking at Koha::Acquisition::Orders it feels like I might have mixed
> 'current' vs. 'active'. So a terminology problem. And 'filter_by_activ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Marcel de Rooy changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #23 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #22)
> Looking at Koha::Acquisition::Orders it feels like I might have mixed
> 'current' vs. 'active'. So a terminology problem. And 'filter_by_activ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #22 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #17)
> A bit late, but wondering why active_orders include completed lines ? Looks
> a bit strange to me..
Looking at Koha::Acquisition::Orders it f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #21 from Martin Renvoize ---
Not with how the API embeds get translated. The real fix is to fix our
database field names and database table names to generally be consistency..
but that would upset everyone with reports.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #20 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #19)
> Adding the orders relation alias is forward thinking for the API here. I
> agree with the approach Tomas took
Yeah no problem. But couldnt you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #19 from Martin Renvoize ---
Adding the orders relation alias is forward thinking for the API here. I agree
with the approach Tomas took
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Marcel de Rooy changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #18 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #0)
> Using the DBIC relationship with aqorders and count, we can get rid of it.
You could have used aqorders but added orders?
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Jonathan Druart changed:
What|Removed |Added
Blocks||24672
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Joy Nelson changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Bug 24430 depends on bug 24418, which changed state.
Bug 24418 Summary: Add Koha::Biblio->suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||24467
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks|24467 |
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Jonathan Druart changed:
What|Removed |Added
Blocks||24467
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #15 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing li
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #14
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Martin Renvoize changed:
What|Removed |Added
Attachment #97565|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Martin Renvoize changed:
What|Removed |Added
Attachment #97564|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Martin Renvoize changed:
What|Removed |Added
Attachment #97563|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Nicolas Legrand changed:
What|Removed |Added
CC||nicolas.legr...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #9 from Nick Clemens ---
Created attachment 97564
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97564&action=edit
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio
This patch introduce
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #10 from Nick Clemens ---
Created attachment 97565
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97565&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces
This patch replaces the only use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Nick Clemens changed:
What|Removed |Added
Attachment #97446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||24435
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||24418
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #5 from Tomás Cohen Arazi ---
Created attachment 97446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97446&action=edit
Bug 24430: Unit tests
Signed-off-by: Tomas Cohen Arazi
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #7 from Tomás Cohen Arazi ---
Created attachment 97448
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97448&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces
This patch replaces the only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #97415|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 97447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97447&action=edit
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio
This patch intr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #97414|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #97443|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #97416|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||17628, 20212
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 97414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97414&action=edit
Bug 24430: Unit tests
Signed-off-by: Tomas Cohen Arazi
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 97415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97415&action=edit
Bug 24430: Add ->orders and ->orders_count to Koha::Biblio
This patch introduces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 97416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97416&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces
This patch replaces the only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
43 matches
Mail list logo