[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #9 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Jonathan Druart changed: What|Removed |Added Attachment #98273|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 101408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101408=edit Bug 24463: Add a basket_group relationship for baskets This patch aims to bring consistency between the accessor name and the underlying relationship to ease things when using it from the API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! No behavior change! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- I see that this is the start of a tree of patches - Joubu, can we continue here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 --- Comment #5 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > (In reply to Jonathan Druart from comment #3) > > If we agree with such naming conventions (ie. create the rs when the DB > > column is poorly named), I think we should have a global plan, and do it > > widely. I do not think we should have 1 bug report per rs. > > I started adding them as needed on the bugs that will actually take > advantage of it. But you don't, this bug report only renames the DBIC rs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > If we agree with such naming conventions (ie. create the rs when the DB > column is poorly named), I think we should have a global plan, and do it > widely. I do not think we should have 1 bug report per rs. I started adding them as needed on the bugs that will actually take advantage of it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- If we agree with such naming conventions (ie. create the rs when the DB column is poorly named), I think we should have a global plan, and do it widely. I do not think we should have 1 bug report per rs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 David Nind changed: What|Removed |Added Attachment #97628|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 98273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98273=edit Bug 24463: Add a basket_group relationship for baskets This patch aims to bring consistency between the accessor name and the underlying relationship to ease things when using it from the API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! No behavior change! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Tomás Cohen Arazi changed: What|Removed |Added Blocks||24464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 [Bug 24464] Add K::A::Basket->creator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 97628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97628=edit Bug 24463: Add a basket_group relationship for baskets This patch aims to bring consistency between the accessor name and the underlying relationship to ease things when using it from the API. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! No behavior change! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
